summaryrefslogtreecommitdiffstats
path: root/recipes
Commit message (Collapse)AuthorAgeFilesLines
* otf-noto: install only one regular fontSamuli Piippo2018-02-071-2/+1
| | | | | | | | | Noto font sizes are big, so install only one font that is used in the demo. Task-number: QTBUG-65690 Change-Id: I02171fefa9326422002e417c715b9ae90e60bd76 Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>
* ttf-opensans: fetch files from git repoSamuli Piippo2018-02-071-6/+6
| | | | | | | Use git repo for the files, so there's no warnings about missing checksums. Change-Id: If37c144a9b41b7a1b8d8b389091897124b7e3d8e Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>
* Merge remote-tracking branch 'origin/morty' into pyroMikko Gronoff2018-02-052-53/+0
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Automotive related changes left intact for pyro, as they require further work than just a basic merge due component branching differences etc. * origin/morty [MERGED]: qt5: don't build tests by default qbsp: fix replace tags quickcompiler: update to 5.9.4 release revision meta-qt5: update to Qt 5.9.4 RC meta-qt5: update to Qt 5.9.4 snapshot meta-qt5: update meta layer poky: update revision ppp: remove obsolete patch meta-qt5: update meta layer internal-build: prepend mirror variables qtdeviceutilities: update revision meta-qt5: update meta layer poky: update revision * origin/morty [NOT MERGED]: Fix license checksum due to incremented year number Update GammaRay revision multiscreen-demo: update revision and fix startup automotive: update revisions sdk: add qtapplicationmanger staticdev package qtivi: enable ivigenerator for toolchain appman: add dependency to nativesdk-qtdeclarative qtivi: Update to the latest version and add PACKAGECONFIG options for qtsimulator Changes not staged for commit: recipes-qt/automotive/gammaray_git.bb recipes-qt/automotive/multiscreen-demo_git.bb recipes-qt/automotive/qtapplicationmanager_git.bb recipes-qt/automotive/qtivi_git.bb recipes-qt/packagegroups/nativesdk-packagegroup-b2qt-automotive-qt5-toolchain-host.bb recipes-qt/packagegroups/packagegroup-b2qt-automotive-qt5-toolchain-target.bb Conflicts: recipes-qt/automotive/gammaray_git.bb recipes-qt/automotive/neptune-ui_git.bb recipes-qt/automotive/qtapplicationmanager_git.bb recipes-qt/automotive/qtivi_git.bb recipes-qt/qt5/qtdeviceutilities.bb recipes-qt/qt5/qtquickcompiler_git.bb scripts/manifest.xml Task-number: QTBUG-65164 Change-Id: I98fe358aaaf55a609dc34f7b8cc65525d493ff26
| * ppp: remove obsolete patchMikko Gronoff2017-12-212-53/+0
| | | | | | | | | | | | | | | | Available via poky (commit 97d7e4ca751e6010da97e7f082dd13230fe3ef10 in morty branch) since latest poky revision update. Change-Id: I30818f49622037fc96d3af144eb94f78caf32494 Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* | connman: choose correct patch for connman versionTobias Olausson2017-12-203-1/+12
| | | | | | | | | | | | | | | | | | | | For building with rocko as the upstream, the connman version (and with that the systemd service file) has been updated. We should select the correct patch for the version of connman we're building. Change-Id: I3e620e383c25d32c2c2e054092cbca81538f4b8a Reviewed-by: Samuli Piippo <samuli.piippo@qt.io> Reviewed-by: Gordan Markus <gordan.markus@pelagicore.com>
* | apalis-imx6: Increase default playback volumeKari Oikarinen2017-12-122-0/+58
| | | | | | | | | | | | | | Task-number: QTBUG-53731 Change-Id: Id5a3d3a581e92c001c7400a70789ff4f16f34cb7 Reviewed-by: Sami Nurmenniemi <sami.nurmenniemi@qt.io> Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* | prebuild-python: get complete python modules packageSamuli Piippo2017-11-294-7/+14
| | | | | | | | | | | | | | | | | | | | | | | | The prebuild package used by QtCreator did not contain all the necessary python modules needed by gdb. Get complete package from python.org. Also make sure those are located by both python.exe and gdb. We still need the original package to provide all the development files not included in the embeddable zip file. Task-number: QTBUG-64855 Change-Id: I109eea70390560e76a668996dfff5bf03424765b Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>
* | Merge "Merge remote-tracking branch 'origin/morty' into pyro" into ↵Mikko Gronoff2017-11-201-8/+7
|\ \ | | | | | | | | | refs/staging/pyro
| * | Merge remote-tracking branch 'origin/morty' into pyroMikko Gronoff2017-11-191-8/+7
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * origin/morty: tegra: correctly append to DEPENDS poky: update to latest revision in morty branch meta-qt5: update layer otf-noto: get files from the git repo Add qdbd to automotive images apalis-imx6: lower default resolution on HDMI to 720p Fix for the broken gdb in windows toolchain Conflicts: recipes/gdb/gdb-cross-canadian_7.%.bbappend scripts/manifest.xml Change-Id: Ia02e9bea46758459e2792cd10174f3c38f4f7a10
| | * otf-noto: get files from the git repoSamuli Piippo2017-11-061-8/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The checksum of the zip file changes too often, which always breaks the build. Change to using the git repo for the files. Unfortunately the repo is massive (>1Gb), but at least it should not cause build breaks anymore. Task-number: QTBUG-64231 Change-Id: Iddfe71c8189caf4e66d78c46e9ca9410b333a8dd Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>
| | * Fix for the broken gdb in windows toolchainSamuli Piippo2017-10-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Needs updated meta-mingw layer. Task-number: QTBUG-63801 Change-Id: I2c390649d7c8e22d382b5eaa311fac620a04cbb6 Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>
* | | ota: fix build issue and add back to imageSamuli Piippo2017-11-201-1/+1
|/ / | | | | | | | | | | | | | | | | Add needed depedency to ostree and add qtotaupdate module back to image and toolchain. Task-number: QTBUG-64542 Change-Id: Ia98527d309de8289466a99551effd87f6b1b36b9 Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>
* | hunspell: refactor recipe to hunspell-dictsMikko Gronoff2017-10-311-21/+19
| | | | | | | | | | | | | | | | | | More recent hunspell (1.6.1) is available from meta-openembedded. Use that instead, leaving here a new recipe that only installs updated libreoffice 5.4.2 branch arabic & english dictionaries. Change-Id: I9d1acbed47e00771145682eda08dbbf6c532adbf Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* | libyaml: remove obsolete bbappendMikko Gronoff2017-10-121-30/+0
| | | | | | | | | | | | | | | | Enabled upstream in poky by commit: 7a932424cab787dde6a6787bdadd9b1162fd4500 libyaml: Enable nativesdk bake Change-Id: I3e140a0fd8f62d9dcdc132fe7cf8da160f0c7c8c Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* | rng-tools: include RNG daemon to imageSamuli Piippo2017-09-183-0/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The rngd reads from hardware random number generator device (/dev/hwrng) and feeds that to /dev/random. Better entropy at boot time is now required since Qt is using getentropy() for random numbers, which blocks on boot if there is not enough generated entropy. Unlike the upstream recipe, this one is configured to use /dev/hwrng instead of /dev/urandom, which means the device needs to have a working HWRNG configuration. Task-number: QTBUG-63188 Change-Id: Icead7576572d7614de8468f1cceaf522dd45dc8d Reviewed-by: Sami Nurmenniemi <sami.nurmenniemi@qt.io>
* | fix binutils-cross rebuild issue with mingwSamuli Piippo2017-09-181-0/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | Upstream poky recipe incorrectly empties LDGOLD value for binutils-cross based on the sdkmingw32 override. This causes all the target packages to be build twice: first when SDKMACHINE is empty, and second when time when SDKMACHINE is set to mingw32. The actual value use here must be exactly what is used in meta/recipes-devtools/binutils/binutils.inc Change-Id: Id6107bae78cf57669b04cea6467dcf11d1f5c913 Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>
* | emulator: fix conflicting glesstream packagesSamuli Piippo2017-09-041-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | qtglesstream-dummy-client is needed to provide qtbase with opengl headers and dummy library and the real qtglesstream is then built against qtbase to provide it actual implementation. Now qtglesstream-dummy-client is built to provide files to the sysroot, but not any packages, and qtglesstream is built to provide the packages, but to deploy nothing to the sysroot. Solves do_rootfs error: package packagegroup-b2qt-embedded-base-1.0-r0.all requires qtglesstream, but none of the providers can be installed Change-Id: Ib388599d9240a5ab9351692a4509adf721cc995c Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>
* | poky: update to 2.3 (pyro)Mikko Gronoff2017-08-176-108/+6
| | | | | | | | | | | | | | | | | | * Update poky, meta-openembedded etc. layers to pyro branches * Remove/update meta-boot2qt layer patches/recipes as needed Task-number: QTBUG-61283 Change-Id: I425609c99ef22a0cc904dd853b3bb281d32fbcad Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* | Merge remote-tracking branch 'origin/morty' into pyroSamuli Piippo2017-08-115-0/+70
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * origin/morty: qtivi: Use the latest version from 'dev' python3-virtualenv: Add a recipe for python3-virtualenv python3: Remove the multilib patch qtivi: Add a PACKAGECONFIG option for dlt qtivi: Use the option of the new configure system qtivi: Restructure the recipe according to the OE style guide Fix qdb connection meta-qt5: update to Qt 5.9.1 RC3 meta-qt5: update to Qt 5.9.1 RC2 Enable sound on raspberrypi meta-qt5: update to Qt 5.9.1 RC rpi: update meta-raspberrypi layer to latest morty branch Use actual Qt version for upload location qbsp: use correct creator type names for qdb plugin meta-qt5: update to Qt 5.9.1 Change-Id: I612e758baf79552b6478b3b85bcbd389a43f95a6
| * python3-virtualenv: Add a recipe for python3-virtualenvDominik Holland2017-07-181-0/+21
| | | | | | | | | | | | | | The recipe also supports native and nativsdk builds Change-Id: Iab2b66b7969a1ca7f444eece2f7a74ed3760364b Reviewed-by: Gordan Markus <gordan.markus@pelagicore.com>
| * python3: Remove the multilib patchDominik Holland2017-07-182-0/+2
| | | | | | | | | | | | | | | | This is needed to make the python3 binary work and find its modules Change-Id: Ief417b4217a11b721990f560b44221f1ad0f8f9d Reviewed-by: Gordan Markus <gordan.markus@pelagicore.com>
| * Fix qdb connectionSami Nurmenniemi2017-07-102-0/+47
| | | | | | | | | | | | | | | | | | | | | | Connman has gadget networks disabled by default. Service qdbd creates usb0 gadget connection. This results in race condition where usb0 disappears if connman is started late enough after qdbd. Fix is to enable gadget networks for connman so it doesn't force it off. Task-number: QTBUG-61718 Change-Id: I896b537bcfb03a1b92960166f0579a58ba6a2d6f Reviewed-by: Kari Oikarinen <kari.oikarinen@qt.io>
* | mingw: upgrade windows python to 3.5.2Samuli Piippo2017-08-105-25/+135
| | | | | | | | | | | | | | | | | | | | This adds support for 64bit windows toolchain with using different binary archives for the prebuild python when building i686 and x86_64 mingw toolchains. Task-number: QTBUG-58918 Change-Id: I1a02546749dd924fd3d2222bbbebf74b31dab07d Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>
* | gdb: fix build for mingw toolchainSamuli Piippo2017-08-101-0/+1
| | | | | | | | | | | | | | | | Build fails with "error: '::hypot' has not been declared" due to python bug (issue11566). Change-Id: I2d9f42ec4f3271f056488e5456be940cf9b0c69e Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>
* | Merge remote-tracking branch 'origin/morty' into pyroSamuli Piippo2017-06-1314-547/+0
|\| | | | | | | | | | | | | | | | | | | | | | | * origin/morty: dracut: remove bbappend BBB: add systemd service for powervr drivers Jetson-TX1: Add ability to mount root via NFS NUC: disable hw cursor for intel nuc adbd: remove component Update update-qt5-modules script handle qtlocation Change-Id: Ied32e11749d81af9ea74714f4d3607d2680bf327
| * dracut: remove bbappendGordan Markuš2017-06-121-38/+0
| | | | | | | | | | | | | | | | | | | | As of meta-openembedded krogoth branch dracut RDEPENDS on systemd optionally, using the bb.utils.contain() function, and RDEPENDS on util-linux. Change-Id: Ie505590c6215055c242d120ec7cfa9035b6a2f10 Reviewed-by: Erik Botö <erik.boto@pelagicore.com> Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
| * adbd: remove componentMikko Gronoff2017-06-0513-509/+0
| | | | | | | | | | | | | | | | QDB replaced ADB in 5.9. Remove obsoleted adbd from image and the recipe from meta layer. Change-Id: I26c6ed7a51886e8e52bc77be6edcbe5933be3068 Reviewed-by: Kari Oikarinen <kari.oikarinen@qt.io>
* | qt5: update to 5.10Samuli Piippo2017-06-071-0/+1
|/ | | | | | | | Qt Quick Compiler needs to be disabled. Use latest from meta-mingw to get c++11 pthread support. Change-Id: I03773d08e0c78e87601d73838c67148248244902 Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>
* Fix failing filesystem check for devices without working RTCSami Nurmenniemi2017-05-221-0/+9
| | | | | | | | | | | | | Devices without working RTC (or backup battery) forced system time during the boot to the build time of systemd. This interfered with the fsck ability to detect insane system times. As a result the boot time filesystem check failed because last mount time was in the future. Task-number: QTBUG-60587 Change-Id: I4c41a5183d56a6dd29707e5557781f722bd363c1 Reviewed-by: Kari Oikarinen <kari.oikarinen@qt.io> Reviewed-by: Samuli Piippo <samuli.piippo@qt.io> Reviewed-by: Kari Hormi <kari.hormi@qt.io>
* nuc: don't leave extra space for initramfsSamuli Piippo2017-05-111-0/+1
| | | | | | | | IMAGE_ROOTFS_EXTRA_SPACE is used in regular rootfs to leave extra space, but that's not needed in the initramfs. Change-Id: I327d86443143b834c0fe28e9ab7a3c3533573f3e Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>
* Use qdbd instead of adbd by defaultKari Oikarinen2017-05-031-0/+2
| | | | | | | | | | | Start qdbd by default instead of adbd. Changing to adbd can be done with `systemctl enable --now adbd`. qdbd needs Function FS, so update the comments related to those kernel config changes. Change-Id: I990a25f26141afe751555f5dc49f0304949dd9a6 Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* sdk: use python3 for toolchainSamuli Piippo2017-04-221-2/+2
| | | | | | | | | Python3 in now the defaut python version, include correct modules to the toolchain. Task-number: QTBUG-59974 Change-Id: I5b851bf7344c85469318a756b7e1a37afbb596ae Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>
* Merge remote-tracking branch 'origin/krogoth' into devMikko Gronoff2017-03-214-1/+81
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * origin/krogoth: AM: update revision Add appman versions of Kit and Qt to creator fonts: add recipe for GNU FreeFonts Add multiscreen automotive demo neptune: update to include fix for i18ndemo fonts: update URL for lohit font Update GammaRay to the same version as used by the QtAS 1.1 host tools emulator: correctly append qtsimulator configuration Update automotive components setup-environment: don't exit the shell on error neptune-ui: add runtime dependencies update meta-qt5 (merged upstream/master) SHA1 to manifest.xml AM: Add appman tools to automotive nativesdk configure-qtcreator: suppress unnecessary error Update GammaRay to the latest 2.7 branch Conflicts: recipes-qt/automotive/neptune-ui_git.bb recipes-qt/automotive/qtapplicationmanager_git.bb recipes-qt/qt5/qtlocation_git.bbappend scripts/manifest.xml Change-Id: I96601e7d7a1827a6631fe59d18101d2ad3b70871
| * fonts: add recipe for GNU FreeFontsSamuli Piippo2017-03-162-0/+50
| | | | | | | | | | | | | | | | | | ... and add FreeMono font to image. Task-number: AUTOSUITE-46 Change-Id: I22f519d09f600b6501fb7194199ad5dea831a76d Reviewed-by: Dominik Holland <dominik.holland@pelagicore.com> Reviewed-by: Nedim Hadzic <nedim.hadzic@pelagicore.com>
| * fonts: update URL for lohit fontSamuli Piippo2017-03-101-1/+1
| | | | | | | | | | | | | | fedorahosted.org was retired on March 1st, 2017. Change-Id: I84c465da283e5e3642f8c26086ccf381910a7b0d Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>
| * AM: Add appman tools to automotive nativesdkGordan Markuš2017-02-101-0/+30
| | | | | | | | | | | | | | Task-number: QTAUTO-274 Change-Id: I467e93dc25a314cda0a4c35fe990c2b1274bc251 Reviewed-by: Gordan Markus <gordan.markus@pelagicore.com> Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* | Don't include ntpKari Oikarinen2017-03-161-1/+0
| | | | | | | | | | | | | | | | systemd included on the images includes systemd-timesyncd so it is duplicating functionality that is already there. Change-Id: Ia7ec270b070e44037cd31171f7f136309ed162bf Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* | opengldummy: add LDFLAGSSamuli Piippo2017-03-151-2/+2
| | | | | | | | | | | | | | Fix QA Issue: No GNU_HASH in the elf binary. Change-Id: I9f890e5d1b8d2440d5523bdf80b9cf5c3d0309a7 Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>
* | ninja: remove our copy of the recipeSamuli Piippo2017-03-151-23/+0
| | | | | | | | | | | | | | Ninja is now available from upstream layers. Change-Id: Iad18c89283818d1dbaa57c9a72c07ee9b9273c16 Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>
* | opengldummy, virtualbox: Add LDFLAGS to fix build errorMikko Gronoff2017-03-142-2/+2
| | | | | | | | | | | | | | Fix QA Issue: No GNU_HASH in the elf binary. Change-Id: I7c49b2aab543131b3f374052b06339a31cdf760a Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* | ppp: correctly patch building with linux kernel 4.8 and newerMikko Gronoff2017-03-142-0/+53
| | | | | | | | | | | | | | | | | | | | poky/meta/recipes-connectivity/ppp module has patch included in morty branch that fixes build errors with kernel version 4.8 and up. However, this breaks builds with older kernels. Apply patch from ppp github fork that correctly addresses this issue and fixes the module building. Change-Id: I2c36c10464f7d28ca2543ec8fbf0164aace5c07a Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* | gnutls: add patch to fix build break with older kernels (< 3.4.17)Mikko Gronoff2017-03-142-0/+68
| | | | | | | | | | | | | | | | Add patch missing from poky morty branch to fix gnutls 3.5.3 build break with jetson-tx1 image build. Change-Id: I2c41989aef485ea9ca0b7927285c6558c2491c32 Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* | gypsy: remove gypsy from meta-boot2qt layerMikko Gronoff2017-03-141-36/+0
| | | | | | | | | | | | | | | | gypsy is broken / blacklisted in poky 2.2. Remove gypsy from qtlocation component & remove gypsy .bbappend from recipes completely. Change-Id: I612d0b66af86fb5736bb9b15a44febcd6a719a51 Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* | virtualbox: update guest additions 5.1.4 --> 5.1.14Mikko Gronoff2017-03-141-2/+2
| | | | | | | | | | | | | | | | | | virtualbox-guest-additions_5.1.4 does not compile for emulator target in poky 2.2.1. Update to latest 5.1.14 version solves build problems. Change-Id: Ic31b319aaecdebfacf1ff4e38dddf599332c65c6 Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* | ostree: add patch/workaround for gtkdocize build issueMikko Gronoff2017-03-142-0/+27
| | | | | | | | | | | | | | | | | | | | Poky 2.2 uses gtk-doc (instead of stub in previous branches). This causes build break in ostree's autogen.sh script as gtkdocize script uses wrong docdir variable. Pass docdir and srcdir variables to gtkdocize in ostree's autogen.sh. Change-Id: Ie500ad6d9b9abfd2b39829774760ec2fc5097c60 Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* | openssl: remove obsolete symbolic link appendsMikko Gronoff2017-03-141-4/+0
| | | | | | | | | | | | | | | | Old symbolic link creation for ssl certs is obsolete as the operation is now in place already Change-Id: Ib96ed730840369b3b1fa89c8a6d2c81e38da8998 Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* | mingw: do not use PN for DEPENDSSamuli Piippo2017-03-091-1/+1
| | | | | | | | | | | | | | | | Using _${PN} for DEPENDS does not work as expected, which meant that gdb never had python as a build dependency. Change-Id: Idfd5f0bef44c25b0fb13942d5a07675c2e536a00 Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>
* | python: fix PSFv2 license checksumMikko Gronoff2017-03-031-1/+1
| | | | | | | | | | Change-Id: I3806795c0a0170b5270de2d20399fef844282eaa Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* | python: add license checksum for prebuild python recipeMikko Gronoff2017-03-031-0/+2
| | | | | | | | | | | | | | | | | | | | In poky 2.2.1 nativesdk-prebuild-python.bb recipe fails due having a license defined but no license cheksum. No license file is present in the recipe src_uri zip file. Added Python-2.0 license file from poky common licenses folder. Change-Id: I6cd168efa55c49ad04d71b7c29b2295c2df03b86 Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* | adb: use LDFLAGS from environmentSamuli Piippo2017-02-091-1/+1
| | | | | | | | | | | | | | Fix QA Issue: No GNU_HASH in the elf binary. Change-Id: I23335a9bd077720ff06be189a4317e09153d6e63 Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>