summaryrefslogtreecommitdiffstats
path: root/recipes-devtools
Commit message (Collapse)AuthorAgeFilesLines
* libclc: Add dependency on spirv-llvm-translatorKhem Raj2021-03-011-3/+1
| | | | Signed-off-by: Khem Raj <raj.khem@gmail.com>
* spirv-llvm-translator: Add recipeKhem Raj2021-03-012-0/+66
| | | | Signed-off-by: Khem Raj <raj.khem@gmail.com>
* llvm: Recognise yoe and poky vendors as OE based distroKhem Raj2021-03-012-0/+26
| | | | | | This helps llvm decide correctly on gcc installation structure Signed-off-by: Khem Raj <raj.khem@gmail.com>
* clang: Update to 12.0.0 RC2Khem Raj2021-03-0134-411/+270
| | | | Signed-off-by: Khem Raj <raj.khem@gmail.com>
* clang: Upgrade to 11.1.0Khem Raj2021-02-201-1/+1
| | | | | | | | | * 1fdec59bffc1 [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS * 85fcd4655947 workflows: Re-enable lldb test on Mac OS X * 17e842f3785f workflows: Update action branch names * e18e509bdb45 workflows: Add job to check for ABI changes in libclang.so and libclang-cpp.so Signed-off-by: Khem Raj <raj.khem@gmail.com>
* libclc: Remove C++ language level overrideZoltán Böszörményi2021-02-181-2/+0
| | | | Signed-off-by: Zoltán Böszörményi <zboszor@pr.hu>
* clang: Merge llvm-common into clangZoltán Böszörményi2021-02-184-22/+9
| | | | Signed-off-by: Zoltán Böszörményi <zboszor@pr.hu>
* libclc: Depend on spirv-tools if LLVM version is 12 or newerZoltán Böszörményi2021-02-141-1/+3
| | | | Signed-off-by: Zoltán Böszörményi <zboszor@pr.hu>
* libclc: Add BBCLASSEXTEND = "native nativesdk"Zoltán Böszörményi2021-02-141-0/+2
| | | | Signed-off-by: Zoltán Böszörményi <zboszor@pr.hu>
* libclc: Don't override cmake specific compiler and linker optionsZoltán Böszörményi2021-02-141-3/+2
| | | | Signed-off-by: Zoltán Böszörményi <zboszor@pr.hu>
* compiler-rt: Disable building memprofKhem Raj2021-02-141-0/+1
| | | | | | | | | memprof/sanitizers need libcrypt to build, therefore remove it from building compiler-rt so we do not need libcrypt dependency, perhaps a new recipe to build sanitizers separately should be added which should also build memprof. Signed-off-by: Khem Raj <raj.khem@gmail.com>
* libclc: Add recipeZoltán Böszörményi2021-02-131-0/+38
| | | | | | This is a pre-requisite to enable OpenCL in Mesa. Signed-off-by: Zoltán Böszörményi <zboszor@pr.hu>
* llvm-project-source: Add patch to make libclc explicitly use python3Zoltán Böszörményi2021-02-132-0/+30
| | | | Signed-off-by: Zoltán Böszörményi <zboszor@pr.hu>
* llvm-project-source: Add a patch to fix LLVM bug 48921Zoltán Böszörményi2021-02-132-0/+86
| | | | | | | | | | The patch was taken from https://bugs.llvm.org/show_bug.cgi?id=48921 Unfortunately, LLVM 11 is already closed so the patch was only accepted into LLVM 12. Also reported at https://gitlab.freedesktop.org/mesa/mesa/-/issues/4107 Signed-off-by: Zoltán Böszörményi <zboszor@pr.hu>
* compiler-rt: Disable sanitizer buildsKhem Raj2021-02-011-3/+2
| | | | | | | | | | | Sanitizers include crypt.h from libcrypt to build, so when using llvm runtime this becomes important to break the cyclic dependency compiler-rt->libxcrypt->compiler-rt Fixes #425 Signed-off-by: Khem Raj <raj.khem@gmail.com>
* clang/llvm: Upgrade to 11.1.0-rc2Khem Raj2021-01-261-3/+3
| | | | Signed-off-by: Khem Raj <raj.khem@gmail.com>
* clang: for x86_64, set Yocto GCC install search pathHongxu Jia2021-01-252-0/+68
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Under Yocto host, while using clang-native to build, it searches install host gcc failed which causing include file not found [snip] |clang++ -target x86_64-linux -MMD -MF src/base/files/file_path_constants.o.d -I../../../tools/gn/src -I. \ -isystem/tmp-glibc/work/x86_64-linux/gn-native/87.0.4280.141-r0/recipe-sysroot-native/usr/include -O2 -pipe \ -std=c++17 -c ../../../tools/gn/src/base/files/file_path_constants.cc -o src/base/files/file_path_constants.o |../../../tools/gn/src/base/files/file_path_constants.cc:7:10: fatal error: 'iterator' file not found |#include <iterator> | ^~~~~~~~ [snip] Set three Yocto based GCC triple: poky, oe-core and wind river Before aplly the patch [snip] $ ../recipe-sysroot-native/usr/bin/clang++ -v clang version 11.0.1 (https://github.com/llvm/llvm-project 43ff75f2c3feef64f9d73328230d34dac8832a91) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: /buildarea/raid5/hjia/wrlinux-20/build_master-wr_browser_2021012017/build-gn-native/tmp-glibc/work/x86_64-linux/gn-native/87.0.4280.141-r0/chromium-87.0.4280.141/../recipe-sysroot-native/usr/bin [snip] After aplly the patch: [snip] $ clang-11 -v clang version 11.0.1 (https://github.com/llvm/llvm-project 22c3241ff9a6224261df48d0258957fd8acc3d64) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: /buildarea/raid5/hjia/wrlinux-20/build_master-wr_browser_2021012017/build/tmp-glibc/work/x86_64-linux/clang-native/11.0.1-r0/build/bin Found candidate GCC installation: /usr/lib//x86_64-wrs-linux/10.1.0 Found candidate GCC installation: /usr/lib/gcc/x86_64-wrs-linux/10.1.0 Selected GCC installation: /usr/lib//x86_64-wrs-linux/10.1.0 Candidate multilib: .;@m64 Selected multilib: .;@m64 [snip] BTW, it is hardly to insert a triple by the replacement of TARGET_SYS (=${TARGET_ARCH}${TARGET_VENDOR}-${TARGET_OS}), since TARGET_VENDOR is different between clang and clang-native Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
* clang: Update to 11.0.1 rc2Khem Raj2020-12-231-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Changes in this bump * 43ff75f2c3fe [AArch64][GlobalISel] Promote scalar G_SHL constant shift amounts to s64. * 9caca7241d44 [AArch64][GlobalISel] Use the look-through constant helper for the shift s32->s64 custom legalization. * d104e582838f [CMake] Avoid __FakeVCSRevision.h with no git repository * f5f8d86dc4c9 Don't error for zero-length arange entries * 280e47ea0e83 [AArch64][GlobalISel] Narrow 128-bit regs to 64-bit regs in emitTestBit * 9e16c5bfae6e [AArch64][GlobalISel] Look through a G_ZEXT when trying to match shift-extended register offsets. * 6ec777c2f649 [Support] PR42623: Avoid setting the delete-on-close bit if a TempFile doesn't reside on a local drive * f684355e0292 [Support][Windows] Fix incorrect GetFinalPathNameByHandleW() return value check in realPathFromHandle() * 98f575ff55bf Don't reject calls to MinGW's unusual _setjmp declaration. * 0312bec0d757 Recognize setjmp and friends as builtins even if jmp_buf is not declared yet. * fdab756331f3 [Sema] Handle objc_super special lookup when checking builtin compatibility * adf845300c9c [Sema] Introduce BuiltinAttr, per-declaration builtin-ness * 200eb1abe2a1 Stop ExtractTypeForDeductionGuide from recursing on TypeSourceInfo * 700baa009dc6 [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize * 861b2a24bc49 [KernelAddressSanitizer] Fix globals exclusion for indirect aliases * 8511a8df838f [InstCombine] canonicalizeSaturatedAdd(): last fold is only valid for strict comparison (PR48390) * 934376da5851 [NFC][InstCombine] Add test coverage for @llvm.uadd.sat canonicalization * fc23bc9b30bf [SemaTemplate] Stop passing insertion position around during VarTemplate instantiation * ca8de9ad8895 [X86] Fix crash with i64 bitreverse on 32-bit targets with XOP. Signed-off-by: Khem Raj <raj.khem@gmail.com>
* rpm: Use gcc for building rpm on all mips archesKhem Raj2020-12-141-2/+2
| | | | | | llvm openmp implementation is not yet ported to mips Signed-off-by: Khem Raj <raj.khem@gmail.com>
* clang: Update to latest on 11.x releaseKhem Raj2020-12-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Brings in following fixes * abeec5d081f [lldb] Report old modules from ModuleList::ReplaceEquivalent * b618cf7a378 [lldb] GetSharedModule: Collect old modules in SmallVector * 93fffe98d5c [lldb] Minidump: check for .text hash match with directory * 393eac16e49 Add hashing of the .text section to ProcessMinidump. * 98fa273339a [lldb] Normalize paths in new test * 561e1ce1a82 [lldb] Fix GetRemoteSharedModule fallback logic * 852f4d8eb6d [Sparc] Remove cast that truncates immediate operands to 32 bits. * b091768e60e [LLD][COFF] Fix crash with /summary and PCH input files * 59012b685fd [CUDA] Another attempt to fix early inclusion of <new> from libstdc++ * aa29049404e [CUDA] Unbreak CUDA compilation with -std=c++20 * 14d60e9a80d [X86][AVX] Only share broadcasts of different widths from the same SDValue of the same SDNode (PR48215) * a21e609d6a2 [X86] Add broadcast merge test case for PR48215 * 0feb4bc5295 Fix missed SI_RETURN_TO_EPILOG in pre-emit peephole * b430f94d005 [Clang][CodeGen][RISCV] Fix hard float ABI for struct with empty struct and complex * a4eaecf122e [Clang][CodeGen][RISCV] Fix hard float ABI test cases with empty struct * ba223fa19d3 [Clang][CodeGen][RISCV] Add hard float ABI tests with empty struct * edc57e7e7ca Guard `find_library(tensorflow_c_api ...)` by checking for TENSORFLOW_C_LIB_PATH to be set by the user * 542174d77de Implement .variant_pcs directive * 724f62a5024 Add fatal error for unnamed SVE variadic arguments * a60b9f1bf32 Add fatal error when running out of registers for SVE tuple call arguments * 79cac55bf04 Fix unwind info relocation with large code model on AArch64 * bb852a09ae3 [GNU ObjC] Fix a regression listing methods twice. * 2cf5c80ab6d [HIP] Fix static-lib test CHECK bug * 19a8a7445dd [HIP] Fix HIP test on windows due to lld suffix * 8b89bc0de0e [WebAssembly] Don't fold frame offset for global addresses * a082c730b89 [WebAssembly] Fix FastISel address calculation bug * 12c4c6cd770 (tag: llvmorg-11.0.1-rc1) Build reproducible tarballs for releases * fd623ba8061 Fix crash after looking up dwo_id=0 in CU index. * f590845f501 Revert "[clang-format] Fix AlignConsecutive on PP blocks" * 890fdb8031e [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in complex wrapper headers. * 075cca34483 [RTDYLD] support absolute relocations where needed * d8e8ae195a2 Revert "[SemaTemplate] Stop passing insertion position around during VarTemplate instantiation" * e4500bab8b2 [AArch64][GlobalISel] Handle rtcGPR64RegClassID in AArch64RegisterBankInfo::getRegBankFromRegClass() * 03565ffd5da [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds * 8ac70957806 [SemaTemplate] Stop passing insertion position around during VarTemplate instantiation * bbe6cbbed8c [stack-clash] Fix probing of dynamic alloca * aac36687f79 Fix interaction between stack alignment and inline-asm stack clash protection * a1e0363c740 Fix limit behavior of dynamic alloca * 3e8d9807d66 [X86] Don't produce bad x86andp nodes for i1 vectors * 973b95e0a84 [MCA][LSUnit] Correctly update the internal group flags on store barrier execution. Fixes PR48024. * 06f479cba3a [CUDA] Extract CUDA version from cuda.h if version.txt is not found * d50044e809d [CUDA] Improve clang's ability to detect recent CUDA versions. Signed-off-by: Khem Raj <raj.khem@gmail.com>
* rpm: Use gcc on arches where llvm omp is not availableKhem Raj2020-11-171-0/+6
| | | | | | | rpm needs omp, therefore it wont compile with clang on architectures not supporting llvm libomp e.g. rv32 Signed-off-by: Khem Raj <raj.khem@gmail.com>
* clang: Fix the __NR_futex_time64 patchKhem Raj2020-11-171-12/+7
| | | | Signed-off-by: Khem Raj <raj.khem@gmail.com>
* clang: Update to latest on release/11.x branchKhem Raj2020-11-151-2/+2
| | | | | | | | | | | | | | | | | | | | | | The minor release is bumped to 11.0.1 Changes is this bump are * 0874e7ef66c Allow init_priority values <= 100 and > 65535 within system headers. * 02004c9e7c9 [ADT] Fix for ImmutableMapRef * 85ce339f1bd [cmake] Fix build of attribute plugin example on Windows * ef4ffcafbb2 [DAE] MarkLive in MarkValue(MaybeLive) if any use is live * 3c687677678 DeferredDiagnosticsEmitter crashes * 701addff1b7 [clang][Sema] Fix PR47676: Handle dependent AltiVec C-style cast * 5ad2592b5dc [X86] Fix cpu name typos * 8fc424f26bf Add release tarballs for libclc * 83716db47f9 [ELF] -r: don't crash when a non-SHF_LINK_ORDER orphan is added before a SHF_LINK_ORDER orphan * 1ff84a04aeb BPF: fix incorrect DAG2DAG load optimization * 38399ced95b [ConstantFold] Make areGlobalsPotentiallyEqual less aggressive. * b59b6b662bb Import github action definitions from release/10.x branch * 3039965645c Bump version to 11.0.1 Signed-off-by: Khem Raj <raj.khem@gmail.com>
* clang: Update riscv32 fix to match upstream submitted versionKhem Raj2020-11-151-11/+19
| | | | Signed-off-by: Khem Raj <raj.khem@gmail.com>
* lto: Override LTO variable from oe-core for thin-ltoKhem Raj2020-11-131-3/+3
| | | | | | If thin-lto is used in DISTRO_FEATURES then enable thin-lto Signed-off-by: Khem Raj <raj.khem@gmail.com>
* openmp: Disable for riscv32Khem Raj2020-10-271-0/+1
| | | | | | Port is not available yet Signed-off-by: Khem Raj <raj.khem@gmail.com>
* build shared nativesdk clangDaniel Dittmann2020-10-211-1/+1
| | | | Signed-off-by: Daniel Dittmann <daniel.dittmann@rohde-schwarz.com>
* Disable LLDB on riscv{32,64}David Abdurachmanov2020-10-161-1/+6
| | | | | | | | | There is no upstream support for RISCV in LLDB at this point thus disable it. Not disabling it would result in undefined references due to lack of RISCV implementation. Signed-off-by: David Abdurachmanov <david.abdurachmanov@sifive.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
* Fix get_clang_arch and LLVM targetsDavid Abdurachmanov2020-10-161-2/+2
| | | | | | | | | | | | | | | | | | | LLVM_TARGET_ARCH must be riscv32 or riscv64, which results in LLVM_NATIVE_ARCH being RISCV. We cannot pass RISCV to LLVM_TARGET_ARCH as that will cause "Unknown architecture" error at configure time. We already have all architectures listed in LLVM_TARGETS_TO_BUILD thus there is no need to append additional ones. That results in LLVM_NATIVE_ARCH being listed multiple times, e.g.: -DLLVM_TARGETS_TO_BUILD='AMDGPU;AArch64;ARM;BPF;Mips;PowerPC;RISCV;X86;RISCV;RISCV;RISCV' Furthermore get_clang_host_arch(), get_clang_target_arch() and get_clang_arch() now return riscv32 or riscv64, which is not a valid value for -DLLVM_TARGETS_TO_BUILD. The valid value is RISCV here. Signed-off-by: David Abdurachmanov <david.abdurachmanov@sifive.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
* Allow riscv32 and riscv64 in COMPATIBLE_HOSTDavid Abdurachmanov2020-10-161-3/+0
| | | | | Signed-off-by: David Abdurachmanov <david.abdurachmanov@sifive.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
* openmp: enable for riscv{32,64}David Abdurachmanov2020-10-161-2/+0
| | | | | Signed-off-by: David Abdurachmanov <david.abdurachmanov@sifive.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
* clang: Use python3 explicitly in scriptsKhem Raj2020-10-152-0/+116
| | | | Signed-off-by: Khem Raj <raj.khem@gmail.com>
* clang: Define LLVM_HOST_TRIPLEKhem Raj2020-10-151-0/+1
| | | | | | This helps ensure that lldb-server gets correct tripets on target Signed-off-by: Khem Raj <raj.khem@gmail.com>
* CastXML: new recipeDaniel McGregor2020-10-081-0/+29
| | | | | | | | | CastXML is an AST analysis tool similar to and succeeding gccxml. It is used to generate an XML description of a C or C++ abstract syntax tree. Signed-off-by: Daniel McGregor <daniel.mcgregor@vecima.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
* clang: Update to 11.0.0-rc6Khem Raj2020-10-081-1/+1
| | | | | | | | | * 176249bd673 (tag: llvmorg-11.0.0-rc6, upstream/release/11.x, origin/release/11.x) [CodeGen][TailDuplicator] Don't duplicate blocks with INLINEASM_BR * e84852be644 Add ability to turn off -fpch-instantiate-templates in clang-cl * 121babae56e [SelectionDAG] Don't remove unused negated constant immediately * f80e6d63423 ReleaseNotes: mention the machine outliner for ARM Signed-off-by: Khem Raj <raj.khem@gmail.com>
* clang: Update to latest on 11.x releaseKhem Raj2020-10-031-1/+1
| | | | | | | * 636ecdd1479 (upstream/release/11.x, origin/release/11.x) Fix indentation for PowerPC ReleaseNotes * b6efbd6b5f2 LLVM release notes: JIT changes Signed-off-by: Khem Raj <raj.khem@gmail.com>
* clang: Match Build targets for host and target clangKhem Raj2020-10-031-9/+5
| | | | | | | | | | | | | This is to help llvm-config detect settings correctly, without this mesa fails to build with llvm-pipe Fixes | File "/mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux/mesa/2_20.1.8-r0/recipe-sysroot-native/usr/lib/python3.8/site-packages/me sonbuild/dependencies/dev.py", line 284, in _set_new_link_args | mode = self.get_config_value(['--shared-mode'], 'link_args')[0] | IndexError: list index out of range Signed-off-by: Khem Raj <raj.khem@gmail.com>
* clang: Do not build all native targets for target as wellKhem Raj2020-10-021-2/+8
| | | | | | | | | | | | | | Just build BPF and AMDGPU (needed by mesa) when building target clang along with the target arch Pass -DNDEBUG -g0 to CXXFLAGS to strip debug info, current amount of debug info is is humungous ( even with -g1 ) some binaries are > 1G in size, it takes a long time to link them and also package them since we have a strip debug info step which takes forever This should speedup clang build significantly Signed-off-by: Khem Raj <raj.khem@gmail.com>
* clang: Update to 11.0.0-rc5Khem Raj2020-10-011-1/+1
| | | | | | | | | | | | | | | * 60a25202a7d [APFloat] prevent NaN morphing into Inf on conversion (PR43907) * a3aee2678d0 [GlobalISel] Fix multiply with overflow intrinsics legalization generating invalid MIR. * dda0a1867cc [LLVM 11] Add SystemZ changes to release notes * eb83b551d3e Fix mysterious failure of SupportTests FileCheckTest.Binop * 29392497305 [LLVM-C] Turn a ShuffleVector Constant Into a Getter. * 9e367bd69b0 C API: functions to get mask of a ShuffleVector * 1e4b179bf82 [CodeGen] Do not call `emitGlobalConstantLargeInt` for constant requires 8 bytes to store * 184a13d362e AArch64/GlobalISel: Narrow stack passed argument access size * 81eb1c1fa75 AArch64/GlobalISel: Reduced patch for bug 47619 * e9adcbfad0d release notes: mention zig as an external project Signed-off-by: Khem Raj <raj.khem@gmail.com>
* make file command output in brief mode when searching for binaries to stripDaniel Wagener2020-09-251-2/+2
| | | | | | | otherwise we grep around in the absolute path to the binary which leads to false positives when e.g. user THelfer put their tree under ~ Signed-off-by: Daniel Wagener <daniel.wagener@kernelconcepts.de>
* clang: Create symlinks with cross compile tuplesKhem Raj2020-09-251-0/+3
| | | | | | | | | This helps in running ptests e.g. perl which encodes the compiler during cross-compile and it is <cross-compile>-clang and not simply `clang` since these tests are configured and compiled on build host and run on target, its requied to have same names on target as well. Signed-off-by: Khem Raj <raj.khem@gmail.com>
* clang: Update to 11.0.0-rc3Khem Raj2020-09-221-1/+1
| | | | | | | | | | | * 0b56e5490dc clang-tools-extra: Drop doxygen link from index.rst * 1b80e741f51 llvm index.rst: Drop in-progress warning * 8aca41f39c2 (tag: llvmorg-11.0.0-rc3) [clang][docs] Fix documentation of -O * b513e1963f3 [CodeGen] Fixing inconsistent ABI mangling of vlaues in SelectionDAGBuilder * 6250d494453 PR47468: Fix findPHICopyInsertPoint, so that copies aren't incorrectly inserted after an INLINEASM_BR. * 410b0dc84bb [llvm] Add contains(KeyType) -> bool methods to SmallPtrSet Signed-off-by: Khem Raj <raj.khem@gmail.com>
* clang: Update to latest 11.x release branchKhem Raj2020-09-221-1/+1
| | | | | | | | * b78e5de029c [SelectionDAG] Check any use of negation result before removal * 4fe4e35452e [Flang] Add GettingInvolved documentation page and sidebar. * 80e2fc1e6e6 [X86][ELF] Prefer lowering MC_GlobalAddress operands to .Lfoo$local for STV_DEFAULT only Signed-off-by: Khem Raj <raj.khem@gmail.com>
* clang: Update to latest on 11.x release branchKhem Raj2020-09-161-1/+1
| | | | Signed-off-by: Khem Raj <raj.khem@gmail.com>
* clang: Update to latest on 11.x branchKhem Raj2020-09-131-1/+1
| | | | Signed-off-by: Khem Raj <raj.khem@gmail.com>
* clang: fix build failure, unrecogn. link option '-fuse-ld=gold' (#368)Winfried Dobbe2020-09-111-1/+1
| | | | | | | | | Command 'bitbake <myimage> -c populate_sdk' fails with clang-9: error: invalid linker name in argument '-fuse-ld=gold'. Using the lld linker fixes the problem. This commit resolves #368 . Signed-off-by: Winfried Dobbe <winfried.dobbe@xmsnet.nl>
* clang: Update to latest clang-11 branchKhem Raj2020-09-071-1/+1
| | | | Signed-off-by: Khem Raj <raj.khem@gmail.com>
* clang: Update to latest release/11.xKhem Raj2020-08-271-1/+1
| | | | Signed-off-by: Khem Raj <raj.khem@gmail.com>
* libcxx: Fix build on rv32 and use compiler-rt on rv32/rv64Khem Raj2020-08-212-2/+32
| | | | Signed-off-by: Khem Raj <raj.khem@gmail.com>
* clang: Update to 11.x release branchKhem Raj2020-08-2127-203/+234
| | | | Signed-off-by: Khem Raj <raj.khem@gmail.com>