summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChris Rogers <crogers122@gmail.com>2023-03-10 10:36:34 -0500
committerArmin Kuster <akuster808@gmail.com>2023-03-18 16:16:42 -0400
commit7ae42df58f2bcc730153715c3339a6875b0b2497 (patch)
treec5b539594fb72af182e397b90b32347913ad62b5
parent068acc4ec714165cab50e46018136e4bcef81815 (diff)
downloadmeta-openembedded-7ae42df58f2bcc730153715c3339a6875b0b2497.tar.gz
xterm: Remove undeclared variables introduced by backport
CVE-2022-45063 ported onto the dunfell baseline introduces two variables that cause xterm to fail compilation with the error ./fontutils.c:4143:13: error: 'added' undeclared (first use in this function) These two variables don't appear to be defined at all in findXftGlyph for xterm_353, so they should be removed. Fixes: 10148c538ebc("xterm : Fix CVE-2022-45063 code execution via OSC 50 input sequences] CVE-2022-45063") Signed-off-by: Chris Rogers <crogers122@gmail.com> Tested-by: Jason Andryuk <jandryuk@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
-rw-r--r--meta-oe/recipes-graphics/xorg-app/xterm/CVE-2022-45063.patch21
1 files changed, 6 insertions, 15 deletions
diff --git a/meta-oe/recipes-graphics/xorg-app/xterm/CVE-2022-45063.patch b/meta-oe/recipes-graphics/xorg-app/xterm/CVE-2022-45063.patch
index 8d1be32106..e63169a209 100644
--- a/meta-oe/recipes-graphics/xorg-app/xterm/CVE-2022-45063.patch
+++ b/meta-oe/recipes-graphics/xorg-app/xterm/CVE-2022-45063.patch
@@ -574,16 +574,7 @@ index 4b0ef85..d9bfaf8 100644
574 } 574 }
575 } 575 }
576 } 576 }
577@@ -4119,6 +4140,8 @@ findXftGlyph(XtermWidget xw, XftFont *given, unsigned wc) 577@@ -4317,7 +4338,7 @@ lookupOneFontSize(XtermWidget xw, int fontnum)
578 }
579 #endif
580 if (foundXftGlyph(xw, check, wc)) {
581+ (void) added;
582+ (void) actual;
583 markXftOpened(xw, which, n, wc);
584 reportXftFonts(xw, check, "fallback", tag, myReport);
585 result = check;
586@@ -4317,7 +4340,7 @@ lookupOneFontSize(XtermWidget xw, int fontnum)
587 578
588 memset(&fnt, 0, sizeof(fnt)); 579 memset(&fnt, 0, sizeof(fnt));
589 screen->menu_font_sizes[fontnum] = -1; 580 screen->menu_font_sizes[fontnum] = -1;
@@ -592,7 +583,7 @@ index 4b0ef85..d9bfaf8 100644
592 if (fontnum <= fontMenu_lastBuiltin 583 if (fontnum <= fontMenu_lastBuiltin
593 || strcmp(fnt.fn, DEFFONT)) { 584 || strcmp(fnt.fn, DEFFONT)) {
594 screen->menu_font_sizes[fontnum] = FontSize(fnt.fs); 585 screen->menu_font_sizes[fontnum] = FontSize(fnt.fs);
595@@ -4722,13 +4745,14 @@ HandleSetFont(Widget w GCC_UNUSED, 586@@ -4722,13 +4743,14 @@ HandleSetFont(Widget w GCC_UNUSED,
596 } 587 }
597 } 588 }
598 589
@@ -608,7 +599,7 @@ index 4b0ef85..d9bfaf8 100644
608 599
609 TRACE(("SetVTFont(which=%d, f_n=%s, f_b=%s)\n", which, 600 TRACE(("SetVTFont(which=%d, f_n=%s, f_b=%s)\n", which,
610 (fonts && fonts->f_n) ? fonts->f_n : "<null>", 601 (fonts && fonts->f_n) ? fonts->f_n : "<null>",
611@@ -4737,34 +4761,31 @@ SetVTFont(XtermWidget xw, 602@@ -4737,34 +4759,31 @@ SetVTFont(XtermWidget xw,
612 if (IsIcon(screen)) { 603 if (IsIcon(screen)) {
613 Bell(xw, XkbBI_MinorError, 0); 604 Bell(xw, XkbBI_MinorError, 0);
614 } else if (which >= 0 && which < NMENUFONTS) { 605 } else if (which >= 0 && which < NMENUFONTS) {
@@ -659,7 +650,7 @@ index 4b0ef85..d9bfaf8 100644
659 } 650 }
660 651
661 USE_CACHED(f_n, fNorm); 652 USE_CACHED(f_n, fNorm);
662@@ -4774,7 +4795,7 @@ SetVTFont(XtermWidget xw, 653@@ -4774,7 +4793,7 @@ SetVTFont(XtermWidget xw,
663 USE_CACHED(f_wb, fWBold); 654 USE_CACHED(f_wb, fWBold);
664 #endif 655 #endif
665 if (xtermLoadFont(xw, 656 if (xtermLoadFont(xw,
@@ -668,7 +659,7 @@ index 4b0ef85..d9bfaf8 100644
668 doresize, which)) { 659 doresize, which)) {
669 /* 660 /*
670 * If successful, save the data so that a subsequent query via 661 * If successful, save the data so that a subsequent query via
671@@ -4786,10 +4807,8 @@ SetVTFont(XtermWidget xw, 662@@ -4786,10 +4805,8 @@ SetVTFont(XtermWidget xw,
672 SAVE_FNAME(f_w, fWide); 663 SAVE_FNAME(f_w, fWide);
673 SAVE_FNAME(f_wb, fWBold); 664 SAVE_FNAME(f_wb, fWBold);
674 #endif 665 #endif
@@ -680,7 +671,7 @@ index 4b0ef85..d9bfaf8 100644
680 Bell(xw, XkbBI_MinorError, 0); 671 Bell(xw, XkbBI_MinorError, 0);
681 } 672 }
682 FREE_FNAME(f_n); 673 FREE_FNAME(f_n);
683@@ -4802,7 +4821,8 @@ SetVTFont(XtermWidget xw, 674@@ -4802,7 +4819,8 @@ SetVTFont(XtermWidget xw,
684 } else { 675 } else {
685 Bell(xw, XkbBI_MinorError, 0); 676 Bell(xw, XkbBI_MinorError, 0);
686 } 677 }