diff options
author | Sinan Kaya <okaya@kernel.org> | 2021-08-23 15:13:11 +0000 |
---|---|---|
committer | Armin Kuster <akuster808@gmail.com> | 2022-09-11 13:49:52 -0400 |
commit | ad1dcf68b6c1d71c495ca93a0390d24269aa1822 (patch) | |
tree | 2d5ba1cb97571ab47f1bb0f931f57f87afac17df | |
parent | cd8d2f689fd03b3ebd345e3df4788f93a83c08f0 (diff) | |
download | meta-openembedded-ad1dcf68b6c1d71c495ca93a0390d24269aa1822.tar.gz |
c-ares: remove custom patches
Current patch is breaking the library dependencies added by cmake
especially when you are static linking.
Applications need the ws2_32 library to be linked for mingw32
and with the existing patch this is not getting passed to the users.
Current patch seems to address this issue:
https://github.com/c-ares/c-ares/issues/373
Both issues are resolved in 1.17.2:
1.17.2-r0/git $ find . | grep c-ares-config.cmake.in
./c-ares-config.cmake.in
1.17.2-r0/git $ find . | grep libcares.pc.cmake
./libcares.pc.cmake
Conflicts:
meta-oe/recipes-support/c-ares/c-ares_1.17.2.bb
Signed-off-by: Sinan Kaya <okaya@kernel.org>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
(cherry picked from commit 621bdc1993d2e8da08b9b240043dc13481cd644f)
Signed-off-by: Ranjitsinh Rathod <ranjitsinh.rathod@kpit.com>
Signed-off-by: Akash Hadke <akash.hadke@kpit.com>
Signed-off-by: Armin Kuster <akuster808@gmail.vom>
3 files changed, 1 insertions, 108 deletions
diff --git a/meta-oe/recipes-support/c-ares/c-ares/0001-fix-configure-error-mv-libcares.pc.cmakein-to-libcar.patch b/meta-oe/recipes-support/c-ares/c-ares/0001-fix-configure-error-mv-libcares.pc.cmakein-to-libcar.patch deleted file mode 100644 index 8f15f8424c..0000000000 --- a/meta-oe/recipes-support/c-ares/c-ares/0001-fix-configure-error-mv-libcares.pc.cmakein-to-libcar.patch +++ /dev/null | |||
@@ -1,27 +0,0 @@ | |||
1 | From f2f1e134bf5d9d0789942848e03006af8d926cf8 Mon Sep 17 00:00:00 2001 | ||
2 | From: Wang Mingyu <wangmy@cn.fujitsu.com> | ||
3 | Date: Tue, 17 Mar 2020 12:53:35 +0800 | ||
4 | Subject: [PATCH] fix configure error : mv libcares.pc.cmakein to | ||
5 | libcares.pc.cmake | ||
6 | |||
7 | Signed-off-by: Wang Mingyu <wangmy@cn.fujitsu.com> | ||
8 | --- | ||
9 | CMakeLists.txt | 2 +- | ||
10 | 1 file changed, 1 insertion(+), 1 deletion(-) | ||
11 | |||
12 | diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
13 | index 3a5878d..c2e5740 100644 | ||
14 | --- a/CMakeLists.txt | ||
15 | +++ b/CMakeLists.txt | ||
16 | @@ -563,7 +563,7 @@ IF (CARES_STATIC) | ||
17 | ENDIF() | ||
18 | |||
19 | # Write ares_config.h configuration file. This is used only for the build. | ||
20 | -CONFIGURE_FILE (libcares.pc.cmakein ${PROJECT_BINARY_DIR}/libcares.pc @ONLY) | ||
21 | +CONFIGURE_FILE (libcares.pc.cmake ${PROJECT_BINARY_DIR}/libcares.pc @ONLY) | ||
22 | |||
23 | |||
24 | |||
25 | -- | ||
26 | 2.17.1 | ||
27 | |||
diff --git a/meta-oe/recipes-support/c-ares/c-ares/cmake-install-libcares.pc.patch b/meta-oe/recipes-support/c-ares/c-ares/cmake-install-libcares.pc.patch deleted file mode 100644 index c6f9c6de61..0000000000 --- a/meta-oe/recipes-support/c-ares/c-ares/cmake-install-libcares.pc.patch +++ /dev/null | |||
@@ -1,77 +0,0 @@ | |||
1 | From 2cc41bee63223cb398ea932aad6ecc94ff5b61dd Mon Sep 17 00:00:00 2001 | ||
2 | From: Changqing Li <changqing.li@windriver.com> | ||
3 | Date: Tue, 24 Jul 2018 13:33:33 +0800 | ||
4 | Subject: [PATCH] cmake: Install libcares.pc | ||
5 | |||
6 | Prepare and install libcares.pc file during cmake build, so libraries | ||
7 | using pkg-config to find libcares will not fail. | ||
8 | |||
9 | Signed-off-by: Alexey Firago <alexey_firago@mentor.com> | ||
10 | |||
11 | update to 1.14.0, fix patch warning | ||
12 | |||
13 | Signed-off-by: Changqing Li <changqing.li@windriver.com> | ||
14 | |||
15 | --- | ||
16 | CMakeLists.txt | 23 +++++++++++++++++------ | ||
17 | 1 file changed, 17 insertions(+), 6 deletions(-) | ||
18 | |||
19 | diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
20 | index 08c0247..0020d6b 100644 | ||
21 | --- a/CMakeLists.txt | ||
22 | +++ b/CMakeLists.txt | ||
23 | @@ -214,22 +214,25 @@ ADD_DEFINITIONS(${SYSFLAGS}) | ||
24 | |||
25 | |||
26 | # Tell C-Ares about libraries to depend on | ||
27 | +# Also pass these libraries to pkg-config file | ||
28 | +SET(CARES_PRIVATE_LIBS_LIST) | ||
29 | IF (HAVE_LIBRESOLV) | ||
30 | - LIST (APPEND CARES_DEPENDENT_LIBS resolv) | ||
31 | + LIST (APPEND CARES_PRIVATE_LIBS_LIST "-lresolv") | ||
32 | ENDIF () | ||
33 | IF (HAVE_LIBNSL) | ||
34 | - LIST (APPEND CARES_DEPENDENT_LIBS nsl) | ||
35 | + LIST (APPEND CARES_PRIVATE_LIBS_LIST "-lnsl") | ||
36 | ENDIF () | ||
37 | IF (HAVE_LIBSOCKET) | ||
38 | - LIST (APPEND CARES_DEPENDENT_LIBS socket) | ||
39 | + LIST (APPEND CARES_PRIVATE_LIBS_LIST "-lsocket") | ||
40 | ENDIF () | ||
41 | IF (HAVE_LIBRT) | ||
42 | - LIST (APPEND CARES_DEPENDENT_LIBS rt) | ||
43 | + LIST (APPEND CARES_PRIVATE_LIBS_LIST "-lrt") | ||
44 | ENDIF () | ||
45 | IF (WIN32) | ||
46 | - LIST (APPEND CARES_DEPENDENT_LIBS ws2_32 Advapi32) | ||
47 | + LIST (APPEND CARES_PRIVATE_LIBS_LIST "-lws2_32") | ||
48 | ENDIF () | ||
49 | |||
50 | +string (REPLACE ";" " " CARES_PRIVATE_LIBS "${CARES_PRIVATE_LIBS_LIST}") | ||
51 | |||
52 | # When checking for symbols, we need to make sure we set the proper | ||
53 | # headers, libraries, and definitions for the detection to work properly | ||
54 | @@ -551,6 +554,15 @@ ENDIF() | ||
55 | # Record toplevel CMakeLists.txt path | ||
56 | set(CARES_TOPLEVEL_DIR "${CMAKE_CURRENT_SOURCE_DIR}") | ||
57 | |||
58 | +# Pass required CFLAGS to pkg-config in case of static library | ||
59 | +IF (CARES_STATIC) | ||
60 | + SET (CPPFLAG_CARES_STATICLIB "-DCARES_STATICLIB") | ||
61 | +ENDIF() | ||
62 | + | ||
63 | +# Write ares_config.h configuration file. This is used only for the build. | ||
64 | +CONFIGURE_FILE (libcares.pc.cmakein ${PROJECT_BINARY_DIR}/libcares.pc @ONLY) | ||
65 | + | ||
66 | + | ||
67 | |||
68 | # TRANSFORM_MAKEFILE_INC | ||
69 | # | ||
70 | @@ -624,7 +636,6 @@ IF (CARES_INSTALL) | ||
71 | INSTALL (FILES "${CMAKE_CURRENT_BINARY_DIR}/libcares.pc" COMPONENT Devel DESTINATION "${CMAKE_INSTALL_LIBDIR}/pkgconfig") | ||
72 | ENDIF () | ||
73 | |||
74 | - | ||
75 | # Legacy chain-building variables (provided for compatibility with old code). | ||
76 | # Don't use these, external code should be updated to refer to the aliases directly (e.g., Cares::cares). | ||
77 | SET (CARES_FOUND 1 CACHE INTERNAL "CARES LIBRARY FOUND") | ||
diff --git a/meta-oe/recipes-support/c-ares/c-ares_1.17.2.bb b/meta-oe/recipes-support/c-ares/c-ares_1.17.2.bb index 3c3e27b531..447a1fd770 100644 --- a/meta-oe/recipes-support/c-ares/c-ares_1.17.2.bb +++ b/meta-oe/recipes-support/c-ares/c-ares_1.17.2.bb | |||
@@ -5,10 +5,7 @@ SECTION = "libs" | |||
5 | LICENSE = "MIT" | 5 | LICENSE = "MIT" |
6 | LIC_FILES_CHKSUM = "file://LICENSE.md;md5=fb997454c8d62aa6a47f07a8cd48b006" | 6 | LIC_FILES_CHKSUM = "file://LICENSE.md;md5=fb997454c8d62aa6a47f07a8cd48b006" |
7 | 7 | ||
8 | SRC_URI = "git://github.com/c-ares/c-ares.git;branch=main \ | 8 | SRC_URI = "git://github.com/c-ares/c-ares.git;branch=main" |
9 | file://cmake-install-libcares.pc.patch \ | ||
10 | file://0001-fix-configure-error-mv-libcares.pc.cmakein-to-libcar.patch \ | ||
11 | " | ||
12 | SRCREV = "6654436a307a5a686b008c1d4c93b0085da6e6d8" | 9 | SRCREV = "6654436a307a5a686b008c1d4c93b0085da6e6d8" |
13 | 10 | ||
14 | UPSTREAM_CHECK_GITTAGREGEX = "cares-(?P<pver>\d+_(\d_?)+)" | 11 | UPSTREAM_CHECK_GITTAGREGEX = "cares-(?P<pver>\d+_(\d_?)+)" |