summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAdrian Freihofer <adrian.freihofer@gmail.com>2024-08-19 10:45:25 +0200
committerArmin Kuster <akuster808@gmail.com>2024-08-21 16:45:33 -0400
commit17aacc80f78f2a6aee45d564ec309a0874774387 (patch)
tree2c49257f9506b0c06e800471a277c3098cc302cb
parentbe2127dce57882ffcc6eb1e6e4af18afb89429f4 (diff)
downloadmeta-openembedded-17aacc80f78f2a6aee45d564ec309a0874774387.tar.gz
networkmanager: remove modemmanager rdepends
This reverts commit: 5edb8335dc46450fd6bcdbb3fcf55336b32bd422 The Networkmanager package must not depend on ModemManager. Only the Networkmanager-wwan package should depend on the ModemManager package. The mobile-broadband-provider-info is fully optional and it is often not required for embedded devices. Let the user choose if it gets installed or not. Adding it explicitely to IMAGE_INSTALL is simple. Adding an RRECOMMENS would work as well. But adding an RDEPENDS is bad. In general, NetworkManager packaging is intended to provide a set of binary packages suitable for building many different images. NetworkManager is designed to be used for binary packages distributions where it is not possible to rebuild NetworkManager just to install Modemmanager. Also for OE, where a rebuilding is possible, a rebuild is a disadvantage. So please do not destroy this flexibility by adding RDEPENDS, which are firstly wrong and secondly only suitable for your specific needs. Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
-rw-r--r--meta-networking/recipes-connectivity/networkmanager/networkmanager_1.46.0.bb2
1 files changed, 1 insertions, 1 deletions
diff --git a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.46.0.bb b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.46.0.bb
index 8184fcf1a1..1b4003df18 100644
--- a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.46.0.bb
+++ b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.46.0.bb
@@ -99,7 +99,7 @@ PACKAGECONFIG[polkit] = "-Dpolkit=true,-Dpolkit=false,polkit"
99PACKAGECONFIG[bluez5] = "-Dbluez5_dun=true,-Dbluez5_dun=false,bluez5" 99PACKAGECONFIG[bluez5] = "-Dbluez5_dun=true,-Dbluez5_dun=false,bluez5"
100# consolekit is not picked by shlibs, so add it to RDEPENDS too 100# consolekit is not picked by shlibs, so add it to RDEPENDS too
101PACKAGECONFIG[consolekit] = "-Dsession_tracking_consolekit=true,-Dsession_tracking_consolekit=false,consolekit,consolekit" 101PACKAGECONFIG[consolekit] = "-Dsession_tracking_consolekit=true,-Dsession_tracking_consolekit=false,consolekit,consolekit"
102PACKAGECONFIG[modemmanager] = "-Dmodem_manager=true,-Dmodem_manager=false,modemmanager mobile-broadband-provider-info,modemmanager mobile-broadband-provider-info" 102PACKAGECONFIG[modemmanager] = "-Dmodem_manager=true,-Dmodem_manager=false,modemmanager mobile-broadband-provider-info"
103PACKAGECONFIG[ppp] = "-Dppp=true -Dpppd=${sbindir}/pppd,-Dppp=false,ppp" 103PACKAGECONFIG[ppp] = "-Dppp=true -Dpppd=${sbindir}/pppd,-Dppp=false,ppp"
104PACKAGECONFIG[dnsmasq] = "-Ddnsmasq=${bindir}/dnsmasq" 104PACKAGECONFIG[dnsmasq] = "-Ddnsmasq=${bindir}/dnsmasq"
105PACKAGECONFIG[nss] = "-Dcrypto=nss,,nss" 105PACKAGECONFIG[nss] = "-Dcrypto=nss,,nss"