diff options
| -rw-r--r-- | meta-oe/recipes-kernel/minicoredumper/files/0001-corestripper-Fix-uninitialized-warning.patch | 53 | ||||
| -rw-r--r-- | meta-oe/recipes-kernel/minicoredumper/minicoredumper_2.0.7.bb | 1 |
2 files changed, 54 insertions, 0 deletions
diff --git a/meta-oe/recipes-kernel/minicoredumper/files/0001-corestripper-Fix-uninitialized-warning.patch b/meta-oe/recipes-kernel/minicoredumper/files/0001-corestripper-Fix-uninitialized-warning.patch new file mode 100644 index 0000000000..8b90d33e1b --- /dev/null +++ b/meta-oe/recipes-kernel/minicoredumper/files/0001-corestripper-Fix-uninitialized-warning.patch | |||
| @@ -0,0 +1,53 @@ | |||
| 1 | From bb44bb643cd2a2f937331b4d1a76b03556b718a2 Mon Sep 17 00:00:00 2001 | ||
| 2 | From: Khem Raj <raj.khem@gmail.com> | ||
| 3 | Date: Tue, 23 Jan 2024 11:36:41 -0800 | ||
| 4 | Subject: [PATCH] corestripper: Fix uninitialized warning | ||
| 5 | |||
| 6 | Clang finds more open paths where ret can be uninitialized | ||
| 7 | |||
| 8 | Fixes | ||
| 9 | | ../../../git/src/minicoredumper/corestripper.c:2768:13: error: variable 'ret' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] | ||
| 10 | | 2768 | } else if (di->core_fd >= 0) { | ||
| 11 | | | ^~~~~~~~~~~~~~~~ | ||
| 12 | | ../../../git/src/minicoredumper/corestripper.c:2773:9: note: uninitialized use occurs here | ||
| 13 | | 2773 | return ret; | ||
| 14 | | | ^~~ | ||
| 15 | | ../../../git/src/minicoredumper/corestripper.c:2768:9: note: remove the 'if' if its condition is always true | ||
| 16 | | 2768 | } else if (di->core_fd >= 0) { | ||
| 17 | | | ^~~~~~~~~~~~~~~~~~~~~ | ||
| 18 | | ../../../git/src/minicoredumper/corestripper.c:2763:9: note: initialize the variable 'ret' to silence this warning | ||
| 19 | | 2763 | int ret; | ||
| 20 | | | ^ | ||
| 21 | | | = 0 | ||
| 22 | |||
| 23 | Upstream-Status: Submitted [https://github.com/diamon/minicoredumper/pull/15] | ||
| 24 | Signed-off-by: Khem Raj <raj.khem@gmail.com> | ||
| 25 | --- | ||
| 26 | src/minicoredumper/corestripper.c | 4 ++-- | ||
| 27 | 1 file changed, 2 insertions(+), 2 deletions(-) | ||
| 28 | |||
| 29 | diff --git a/src/minicoredumper/corestripper.c b/src/minicoredumper/corestripper.c | ||
| 30 | index 3eb9089..e9e3936 100644 | ||
| 31 | --- a/src/minicoredumper/corestripper.c | ||
| 32 | +++ b/src/minicoredumper/corestripper.c | ||
| 33 | @@ -2707,7 +2707,7 @@ static int dump_data_content_file(struct dump_info *di, | ||
| 34 | char *tmp_path; | ||
| 35 | FILE *file; | ||
| 36 | int len; | ||
| 37 | - int ret; | ||
| 38 | + int ret = -1; | ||
| 39 | |||
| 40 | len = strlen(di->dst_dir) + strlen("/dumps/") + 32 + | ||
| 41 | strlen(dd->ident) + 1; | ||
| 42 | @@ -2760,7 +2760,7 @@ out: | ||
| 43 | static int dump_data_content(struct dump_info *di, struct mcd_dump_data *dd, | ||
| 44 | const char *symname) | ||
| 45 | { | ||
| 46 | - int ret; | ||
| 47 | + int ret = -1; | ||
| 48 | |||
| 49 | if (dd->ident) { | ||
| 50 | /* dump to external file */ | ||
| 51 | -- | ||
| 52 | 2.43.0 | ||
| 53 | |||
diff --git a/meta-oe/recipes-kernel/minicoredumper/minicoredumper_2.0.7.bb b/meta-oe/recipes-kernel/minicoredumper/minicoredumper_2.0.7.bb index 0c38271418..726aa60ce7 100644 --- a/meta-oe/recipes-kernel/minicoredumper/minicoredumper_2.0.7.bb +++ b/meta-oe/recipes-kernel/minicoredumper/minicoredumper_2.0.7.bb | |||
| @@ -15,6 +15,7 @@ SRC_URI = "git://github.com/diamon/minicoredumper;protocol=https;branch=master \ | |||
| 15 | file://minicoredumper.service \ | 15 | file://minicoredumper.service \ |
| 16 | file://minicoredumper.init \ | 16 | file://minicoredumper.init \ |
| 17 | file://run-ptest \ | 17 | file://run-ptest \ |
| 18 | file://0001-corestripper-Fix-uninitialized-warning.patch \ | ||
| 18 | " | 19 | " |
| 19 | 20 | ||
| 20 | S = "${WORKDIR}/git" | 21 | S = "${WORKDIR}/git" |
