diff options
-rw-r--r-- | meta-oe/recipes-kernel/crash/crash-cross-canadian_8.0.4.bb (renamed from meta-oe/recipes-kernel/crash/crash-cross-canadian_8.0.2.bb) | 0 | ||||
-rw-r--r-- | meta-oe/recipes-kernel/crash/crash.inc | 3 | ||||
-rw-r--r-- | meta-oe/recipes-kernel/crash/crash/0001-make-src-string-const-in-strlcpy.patch | 69 | ||||
-rw-r--r-- | meta-oe/recipes-kernel/crash/crash_8.0.4.bb (renamed from meta-oe/recipes-kernel/crash/crash_8.0.2.bb) | 0 |
4 files changed, 1 insertions, 71 deletions
diff --git a/meta-oe/recipes-kernel/crash/crash-cross-canadian_8.0.2.bb b/meta-oe/recipes-kernel/crash/crash-cross-canadian_8.0.4.bb index 04be12602c..04be12602c 100644 --- a/meta-oe/recipes-kernel/crash/crash-cross-canadian_8.0.2.bb +++ b/meta-oe/recipes-kernel/crash/crash-cross-canadian_8.0.4.bb | |||
diff --git a/meta-oe/recipes-kernel/crash/crash.inc b/meta-oe/recipes-kernel/crash/crash.inc index 8d700ed484..04318b1505 100644 --- a/meta-oe/recipes-kernel/crash/crash.inc +++ b/meta-oe/recipes-kernel/crash/crash.inc | |||
@@ -22,9 +22,8 @@ SRC_URI = "git://github.com/crash-utility/${BPN}.git;branch=master;protocol=http | |||
22 | file://0001-cross_add_configure_option.patch \ | 22 | file://0001-cross_add_configure_option.patch \ |
23 | file://donnot-extract-gdb-during-do-compile.patch \ | 23 | file://donnot-extract-gdb-during-do-compile.patch \ |
24 | file://gdb_build_jobs_and_not_write_crash_target.patch \ | 24 | file://gdb_build_jobs_and_not_write_crash_target.patch \ |
25 | file://0001-make-src-string-const-in-strlcpy.patch \ | ||
26 | " | 25 | " |
27 | SRCREV = "f1cd581d1c4afa5b8ffdfaa6a3ea9f545fe4ec91" | 26 | SRCREV = "a6832f608cb5d473739cf33bbf84ab1df8d98fd5" |
28 | 27 | ||
29 | SRC_URI[gdb.sha256sum] = "b33ad58d687487a821ec8d878daab0f716be60d0936f2e3ac5cf08419ce70350" | 28 | SRC_URI[gdb.sha256sum] = "b33ad58d687487a821ec8d878daab0f716be60d0936f2e3ac5cf08419ce70350" |
30 | 29 | ||
diff --git a/meta-oe/recipes-kernel/crash/crash/0001-make-src-string-const-in-strlcpy.patch b/meta-oe/recipes-kernel/crash/crash/0001-make-src-string-const-in-strlcpy.patch deleted file mode 100644 index 546973e0ac..0000000000 --- a/meta-oe/recipes-kernel/crash/crash/0001-make-src-string-const-in-strlcpy.patch +++ /dev/null | |||
@@ -1,69 +0,0 @@ | |||
1 | From 4ee56105881d7bb1da1e668ac5bb47a4e0846676 Mon Sep 17 00:00:00 2001 | ||
2 | From: Lianbo Jiang <lijiang@redhat.com> | ||
3 | Date: Wed, 5 Jul 2023 10:02:59 +0800 | ||
4 | Subject: [PATCH] Fix compilation error due to new strlcpy function that glibc | ||
5 | added | ||
6 | MIME-Version: 1.0 | ||
7 | Content-Type: text/plain; charset=UTF-8 | ||
8 | Content-Transfer-Encoding: 8bit | ||
9 | |||
10 | The crash-utility has its own strlcpy(), but recently the latest glibc | ||
11 | has also implemented the strlcpy function, which is derived from | ||
12 | OpenBSD. Eventually this caused the following compilation error: | ||
13 | |||
14 | # make -j8 lzo | ||
15 | ... | ||
16 | In file included from global_data.c:18: | ||
17 | defs.h:5556:8: error: conflicting types for ‘strlcpy’; have ‘size_t(char *, char *, size_t)’ {aka ‘long unsigned int(char *, char *, long unsigned int)’} | ||
18 | 5556 | size_t strlcpy(char *, char *, size_t); | ||
19 | | ^~~~~~~ | ||
20 | In file included from memory.c:19: | ||
21 | defs.h:5556:8: error: conflicting types for ‘strlcpy’; have ‘size_t(char *, char *, size_t)’ {aka ‘long unsigned int(char *, char *, long unsigned int)’} | ||
22 | 5556 | size_t strlcpy(char *, char *, size_t); | ||
23 | | ^~~~~~~ | ||
24 | ... | ||
25 | |||
26 | To fix the issue, let's declare the strlcpy() as a weak function and | ||
27 | keep the same parameter types as the glibc function has. | ||
28 | |||
29 | Related glibc commits: | ||
30 | 454a20c8756c ("Implement strlcpy and strlcat [BZ #178]") | ||
31 | d2fda60e7c40 ("manual: Manual update for strlcat, strlcpy, wcslcat, wclscpy") | ||
32 | 388ae538ddcb ("hurd: Add strlcpy, strlcat, wcslcpy, wcslcat to libc.abilist") | ||
33 | |||
34 | Upstream-Status: Backport [https://github.com/kraj/crash/commit/4ee56105881d7bb1da1e668ac5bb47a4e0846676] | ||
35 | Signed-off-by: Lianbo Jiang <lijiang@redhat.com> | ||
36 | --- | ||
37 | defs.h | 2 +- | ||
38 | tools.c | 2 +- | ||
39 | 2 files changed, 2 insertions(+), 2 deletions(-) | ||
40 | |||
41 | diff --git a/defs.h b/defs.h | ||
42 | index 8f7d1fa..26afe23 100644 | ||
43 | --- a/defs.h | ||
44 | +++ b/defs.h | ||
45 | @@ -5553,7 +5553,7 @@ uint32_t swap32(uint32_t, int); | ||
46 | uint64_t swap64(uint64_t, int); | ||
47 | ulong *get_cpumask_buf(void); | ||
48 | int make_cpumask(char *, ulong *, int, int *); | ||
49 | -size_t strlcpy(char *, char *, size_t); | ||
50 | +size_t strlcpy(char *, const char *, size_t) __attribute__ ((__weak__)); | ||
51 | struct rb_node *rb_first(struct rb_root *); | ||
52 | struct rb_node *rb_parent(struct rb_node *, struct rb_node *); | ||
53 | struct rb_node *rb_right(struct rb_node *, struct rb_node *); | ||
54 | diff --git a/tools.c b/tools.c | ||
55 | index 392a797..0f2db10 100644 | ||
56 | --- a/tools.c | ||
57 | +++ b/tools.c | ||
58 | @@ -6795,7 +6795,7 @@ make_cpumask_error: | ||
59 | * always be NULL-terminated. | ||
60 | */ | ||
61 | size_t | ||
62 | -strlcpy(char *dest, char *src, size_t size) | ||
63 | +strlcpy(char *dest, const char *src, size_t size) | ||
64 | { | ||
65 | size_t ret = strlen(src); | ||
66 | |||
67 | -- | ||
68 | 2.41.0 | ||
69 | |||
diff --git a/meta-oe/recipes-kernel/crash/crash_8.0.2.bb b/meta-oe/recipes-kernel/crash/crash_8.0.4.bb index cc46ab9ea7..cc46ab9ea7 100644 --- a/meta-oe/recipes-kernel/crash/crash_8.0.2.bb +++ b/meta-oe/recipes-kernel/crash/crash_8.0.4.bb | |||