From c26bc83d3ab5f21d47ebbd1b316032b877cae66c Mon Sep 17 00:00:00 2001 From: Khem Raj Date: Fri, 2 Sep 2022 13:05:53 -0700 Subject: gphoto2: Upgrade to 2.5.28 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit License-Update: Copyright symbol added - Copyright 1991, 1999 Free Software Foundation, Inc. + Copyright © 1991, 1999 Free Software Foundation, Inc. Also upgrade libgphoto2 to 2.5.30 Fix build with musl while here Signed-off-by: Khem Raj --- .../0001-configure.ac-remove-AM_PO_SUBDIRS.patch | 13 ++--- ...Use-pthread_t-abstract-type-for-thead-IDs.patch | 39 ++++++++++++++ ...k-for-popt-with-GP_CHECK_LIBRARY-function.patch | 32 ------------ meta-oe/recipes-graphics/gphoto2/gphoto2_2.5.27.bb | 22 -------- meta-oe/recipes-graphics/gphoto2/gphoto2_2.5.28.bb | 20 ++++++++ .../0001-configure.ac-remove-AM_PO_SUBDIRS.patch | 31 +++++------ .../recipes-graphics/gphoto2/libgphoto2_2.5.27.bb | 60 ---------------------- .../recipes-graphics/gphoto2/libgphoto2_2.5.30.bb | 58 +++++++++++++++++++++ 8 files changed, 133 insertions(+), 142 deletions(-) create mode 100644 meta-oe/recipes-graphics/gphoto2/gphoto2/0001-gphoto2-Use-pthread_t-abstract-type-for-thead-IDs.patch delete mode 100644 meta-oe/recipes-graphics/gphoto2/gphoto2/0002-Look-for-popt-with-GP_CHECK_LIBRARY-function.patch delete mode 100644 meta-oe/recipes-graphics/gphoto2/gphoto2_2.5.27.bb create mode 100644 meta-oe/recipes-graphics/gphoto2/gphoto2_2.5.28.bb delete mode 100644 meta-oe/recipes-graphics/gphoto2/libgphoto2_2.5.27.bb create mode 100644 meta-oe/recipes-graphics/gphoto2/libgphoto2_2.5.30.bb diff --git a/meta-oe/recipes-graphics/gphoto2/gphoto2/0001-configure.ac-remove-AM_PO_SUBDIRS.patch b/meta-oe/recipes-graphics/gphoto2/gphoto2/0001-configure.ac-remove-AM_PO_SUBDIRS.patch index 7800fdd570..eaef8180ee 100644 --- a/meta-oe/recipes-graphics/gphoto2/gphoto2/0001-configure.ac-remove-AM_PO_SUBDIRS.patch +++ b/meta-oe/recipes-graphics/gphoto2/gphoto2/0001-configure.ac-remove-AM_PO_SUBDIRS.patch @@ -9,18 +9,13 @@ This is done twice together with oe autotools.bbclass. configure.ac | 1 - 1 file changed, 1 deletion(-) -diff --git a/configure.ac b/configure.ac -index bb5b795..93fbaf2 100644 --- a/configure.ac +++ b/configure.ac -@@ -64,7 +64,6 @@ GP_GETTEXT_HACK([],[Lutz Müller and others],[${MAIL_GPHOTO_TRANSLATION}]) +@@ -46,7 +46,6 @@ dnl i18n support + dnl --------------------------------------------------------------------------- + GP_GETTEXT_HACK([],[Lutz Müller and others],[${MAIL_GPHOTO_TRANSLATION}]) ALL_LINGUAS="az cs da de en_GB es eu fi fr hu id is it ja nl pa pl pt_BR ro ru rw sk sr sv uk vi zh_CN zh_TW" +-AM_PO_SUBDIRS() AM_GNU_GETTEXT_VERSION([0.14.1]) AM_GNU_GETTEXT([external]) --AM_PO_SUBDIRS() AM_ICONV() - GP_GETTEXT_FLAGS() - --- -1.9.1 - diff --git a/meta-oe/recipes-graphics/gphoto2/gphoto2/0001-gphoto2-Use-pthread_t-abstract-type-for-thead-IDs.patch b/meta-oe/recipes-graphics/gphoto2/gphoto2/0001-gphoto2-Use-pthread_t-abstract-type-for-thead-IDs.patch new file mode 100644 index 0000000000..a27c02cefc --- /dev/null +++ b/meta-oe/recipes-graphics/gphoto2/gphoto2/0001-gphoto2-Use-pthread_t-abstract-type-for-thead-IDs.patch @@ -0,0 +1,39 @@ +From 23c67e93e51f700d0aeecfc08277e39f51201fc3 Mon Sep 17 00:00:00 2001 +From: Khem Raj +Date: Fri, 2 Sep 2022 12:59:46 -0700 +Subject: [PATCH] gphoto2: Use pthread_t abstract type for thead IDs + +This is not a plain old datatype in every libc, e.g. with musl this +would fail in type conversion + +Upstream-Status: Submitted [https://github.com/gphoto/gphoto2/pull/535] +Signed-off-by: Khem Raj +--- + gphoto2/main.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/gphoto2/main.c b/gphoto2/main.c +index 2bf5964..9a6b05d 100644 +--- a/gphoto2/main.c ++++ b/gphoto2/main.c +@@ -1198,7 +1198,7 @@ thread_func (void *data) + pthread_cleanup_pop (1); + } + +-static unsigned int ++static pthread_t + start_timeout_func (Camera *camera, unsigned int timeout, + CameraTimeoutFunc func, void __unused__ *data) + { +@@ -1219,7 +1219,7 @@ start_timeout_func (Camera *camera, unsigned int timeout, + } + + static void +-stop_timeout_func (Camera __unused__ *camera, unsigned int id, ++stop_timeout_func (Camera __unused__ *camera, pthread_t id, + void __unused__ *data) + { + pthread_t tid = id; +-- +2.37.3 + diff --git a/meta-oe/recipes-graphics/gphoto2/gphoto2/0002-Look-for-popt-with-GP_CHECK_LIBRARY-function.patch b/meta-oe/recipes-graphics/gphoto2/gphoto2/0002-Look-for-popt-with-GP_CHECK_LIBRARY-function.patch deleted file mode 100644 index e6c7dd6675..0000000000 --- a/meta-oe/recipes-graphics/gphoto2/gphoto2/0002-Look-for-popt-with-GP_CHECK_LIBRARY-function.patch +++ /dev/null @@ -1,32 +0,0 @@ -From 884d4c9bbd2dc147d614a5fabc25dbea7a71cd48 Mon Sep 17 00:00:00 2001 -From: Andreas Baak -Date: Sun, 12 Jul 2015 02:13:58 -0700 -Subject: [PATCH] Look for popt with GP_CHECK_LIBRARY function - -The previously used proprietary function GP_CHECK_POPT -defined in /.m4m/gp-check-opt.m4 is not ready for cross -compilation since it looks for the library and headers -in the host system. Yocto reports the following error: -"QA Issue: gphoto2: The compile log indicates that host -include and/or library paths were used." -Using the GP_CHECK_LIBRARY function fixes this problem ---- - configure.ac | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -diff --git a/configure.ac b/configure.ac -index 93fbaf2..6d661f0 100644 ---- a/configure.ac -+++ b/configure.ac -@@ -285,7 +285,7 @@ GP_CONFIG_MSG([Text preview support],[$aa_msg]) - dnl --------------------------------------------------------------------------- - dnl popt.h: Simplifies handling of command-line options enormously. - dnl --------------------------------------------------------------------------- --GP_CHECK_POPT([mandatory]) -+GP_CHECK_LIBRARY([POPT], [popt], [], [popt.h], [], [], [mandatory]) - - - dnl --------------------------------------------------------------------------- --- -1.9.1 - diff --git a/meta-oe/recipes-graphics/gphoto2/gphoto2_2.5.27.bb b/meta-oe/recipes-graphics/gphoto2/gphoto2_2.5.27.bb deleted file mode 100644 index 84ff677238..0000000000 --- a/meta-oe/recipes-graphics/gphoto2/gphoto2_2.5.27.bb +++ /dev/null @@ -1,22 +0,0 @@ -SUMMARY = "gphoto2 - a command-line frontend to libgphoto2" -HOMEPAGE = "http://www.gphoto.com/" -LICENSE = "GPL-2.0-only" -LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552" - -DEPENDS = "libgphoto2 popt readline" -RDEPENDS:gphoto2 = "libgphoto2" - -SRC_URI = "${SOURCEFORGE_MIRROR}/gphoto/gphoto2-${PV}.tar.bz2;name=gphoto2 \ - file://0001-configure.ac-remove-AM_PO_SUBDIRS.patch \ - file://0002-Look-for-popt-with-GP_CHECK_LIBRARY-function.patch \ -" - -SRC_URI[gphoto2.md5sum] = "92d39b383c0e0354b4d3af1af7b8b416" -SRC_URI[gphoto2.sha256sum] = "30054e93a1bb59f501aabd5018713177ea04ce0cb28935319bd6ca80061e8d38" - -inherit autotools pkgconfig gettext - -EXTRA_OECONF += "--with-jpeg-prefix=${STAGING_INCDIR} \ - --without-cdk \ -" - diff --git a/meta-oe/recipes-graphics/gphoto2/gphoto2_2.5.28.bb b/meta-oe/recipes-graphics/gphoto2/gphoto2_2.5.28.bb new file mode 100644 index 0000000000..fe33940475 --- /dev/null +++ b/meta-oe/recipes-graphics/gphoto2/gphoto2_2.5.28.bb @@ -0,0 +1,20 @@ +SUMMARY = "gphoto2 - a command-line frontend to libgphoto2" +HOMEPAGE = "http://www.gphoto.com/" +LICENSE = "GPL-2.0-only" +LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552" + +DEPENDS = "libgphoto2 popt readline" +RDEPENDS:gphoto2 = "libgphoto2" + +SRC_URI = "${SOURCEFORGE_MIRROR}/gphoto/gphoto2-${PV}.tar.bz2;name=gphoto2 \ + file://0001-configure.ac-remove-AM_PO_SUBDIRS.patch \ + file://0001-gphoto2-Use-pthread_t-abstract-type-for-thead-IDs.patch \ +" +SRC_URI[gphoto2.sha256sum] = "2a648dcdf12da19e208255df4ebed3e7d2a02f905be4165f2443c984cf887375" + +inherit autotools pkgconfig gettext + +EXTRA_OECONF += "--with-jpeg-prefix=${STAGING_INCDIR} \ + --without-cdk \ +" + diff --git a/meta-oe/recipes-graphics/gphoto2/libgphoto2/0001-configure.ac-remove-AM_PO_SUBDIRS.patch b/meta-oe/recipes-graphics/gphoto2/libgphoto2/0001-configure.ac-remove-AM_PO_SUBDIRS.patch index 8093676adc..f93650f86c 100644 --- a/meta-oe/recipes-graphics/gphoto2/libgphoto2/0001-configure.ac-remove-AM_PO_SUBDIRS.patch +++ b/meta-oe/recipes-graphics/gphoto2/libgphoto2/0001-configure.ac-remove-AM_PO_SUBDIRS.patch @@ -19,30 +19,23 @@ Signed-off-by: Andreas Müller libgphoto2_port/configure.ac | 1 - 2 files changed, 0 insertions(+), 2 deletions(-) -diff --git a/configure.ac b/configure.ac -index 2f8e1b8..2e90acf 100644 --- a/configure.ac +++ b/configure.ac -@@ -209,7 +209,6 @@ ALL_LINGUAS="cs da de es eu fr hu it ja nl pl ru sv uk vi zh_CN" - GP_GETTEXT_HACK([${PACKAGE}-${LIBGPHOTO2_CURRENT_MIN}],[The gPhoto Team],[${MAIL_GPHOTO_TRANSLATION}]) - AM_GNU_GETTEXT_VERSION([0.14.1]) - AM_GNU_GETTEXT([external]) +@@ -282,7 +282,6 @@ dnl ------------------------------------ + GP_GETTEXT_SETUP([GETTEXT_PACKAGE_LIBGPHOTO2], + [${PACKAGE}-${LIBGPHOTO2_CURRENT_MIN}], + [po]) -AM_PO_SUBDIRS() + AM_GNU_GETTEXT_VERSION([0.19.1]) + AM_GNU_GETTEXT([external]) AM_ICONV() - GP_GETTEXT_FLAGS() - -diff --git a/libgphoto2_port/configure.ac b/libgphoto2_port/configure.ac -index 0b66d58..df47357 100644 --- a/libgphoto2_port/configure.ac +++ b/libgphoto2_port/configure.ac -@@ -124,7 +124,6 @@ GP_GETTEXT_HACK([${PACKAGE}-${LIBGPHOTO2_PORT_CURRENT_MIN}],[Lutz Mueller and ot - ALL_LINGUAS="cs da de es eu fi fr it ja nl pl pt_BR ru sk sr sv uk vi zh_CN zh_TW" - AM_GNU_GETTEXT_VERSION([0.14.1]) - AM_GNU_GETTEXT([external]) +@@ -122,7 +122,6 @@ dnl ------------------------------------ + GP_GETTEXT_SETUP([GETTEXT_PACKAGE_LIBGPHOTO2_PORT], + [${PACKAGE}-${LIBGPHOTO2_PORT_CURRENT_MIN}], + [po]) -AM_PO_SUBDIRS() + AM_GNU_GETTEXT_VERSION([0.19.1]) + AM_GNU_GETTEXT([external]) AM_ICONV() - GP_GETTEXT_FLAGS() - --- -1.7.4.4 - diff --git a/meta-oe/recipes-graphics/gphoto2/libgphoto2_2.5.27.bb b/meta-oe/recipes-graphics/gphoto2/libgphoto2_2.5.27.bb deleted file mode 100644 index 41600be2e1..0000000000 --- a/meta-oe/recipes-graphics/gphoto2/libgphoto2_2.5.27.bb +++ /dev/null @@ -1,60 +0,0 @@ -SUMMARY = "libgphoto2 allows you to access digital cameras" -SECTION = "libs" -LICENSE = "LGPL-2.1-only" -LIC_FILES_CHKSUM = "file://COPYING;md5=0448d3676bc0de00406af227d341a4d1" - -DEPENDS = "libtool jpeg virtual/libusb0 libexif zlib libxml2" - -# The .fdi and .rules files were generated with: -# libgphoto2-2.5.8/packaging/generic$ qemu-arm -s 1048576 -r 2.6.24 -L /OE/angstrom-dev/staging/armv5te-angstrom-linux-gnueabi/ .libs/print-camera-list -# They are release specific, so please regen when adding new releases - -SRC_URI = "${SOURCEFORGE_MIRROR}/gphoto/libgphoto2-${PV}.tar.bz2;name=libgphoto2 \ - file://40-libgphoto2.rules \ - file://0001-configure.ac-remove-AM_PO_SUBDIRS.patch \ -" - -SRC_URI[libgphoto2.md5sum] = "83a2f96dade72e95dffb8e5fa9628d7e" -SRC_URI[libgphoto2.sha256sum] = "f8b85478c44948a0b0b52c4d4dfda2de1d7bcb7b262c76bd1ae306d9c63240d7" - -inherit autotools pkgconfig gettext lib_package - -EXTRA_OECONF = " --with-drivers=all udevscriptdir=${nonarch_base_libdir}/udev ac_cv_lib_ltdl_lt_dlcaller_register=yes" - -PACKAGECONFIG ??= "" -PACKAGECONFIG[gd] = ",--without-gdlib,gd" -PACKAGECONFIG[serial] = "--enable-serial,--disable-serial,lockdev" - -do_configure:prepend() { - rm -rf ${S}/libgphoto2_port/auto-m4/* - rm -rf ${S}/auto-m4/* -} - -do_configure:append() { - cp ${STAGING_DATADIR_NATIVE}/gettext/po/Makefile.in.in ${S}/libgphoto2_port/po/ - cd ${S}/libgphoto2_port/ - autoreconf -Wcross --verbose --install --force ${EXTRA_AUTORECONF} $acpaths - - # remove WORKDIR information from config to improve reproducibility - # libgphoto2_port recheck config will set the WORKDIR info again, so dont do that - sed -i 's/'$(echo ${WORKDIR} | sed 's_/_\\/_g')'/../g' ${B}/config.h - sed -i 's/'$(echo ${WORKDIR} | sed 's_/_\\/_g')'/../g' ${B}/libgphoto2_port/config.status - sed -i '/config\.status/ s/\-\-recheck//' ${B}/libgphoto2_port/Makefile - cd ${S} -} - -do_install:append() { - install -d ${D}${sysconfdir}/udev/rules.d/ - install -m 0644 ${WORKDIR}/*.rules ${D}${sysconfdir}/udev/rules.d/ -} - -PACKAGES =+ "libgphotoport libgphoto2-camlibs" -FILES:libgphoto2-camlibs = "${libdir}/libgphoto2*/*/*.so*" -RRECOMMENDS:${PN} = "libgphoto2-camlibs" - -FILES:libgphotoport = "${libdir}/libgphoto2_port.so.*" - -FILES:${PN} += "${nonarch_base_libdir}/udev/*" -FILES:${PN}-dbg += "${libdir}/*/*/.debug" -FILES:${PN}-dev += "${libdir}/*/*/*.la" -FILES:${PN}-doc += "${datadir}/libgphoto2_port/0.12.0/vcamera/README.txt" diff --git a/meta-oe/recipes-graphics/gphoto2/libgphoto2_2.5.30.bb b/meta-oe/recipes-graphics/gphoto2/libgphoto2_2.5.30.bb new file mode 100644 index 0000000000..0f2800a95f --- /dev/null +++ b/meta-oe/recipes-graphics/gphoto2/libgphoto2_2.5.30.bb @@ -0,0 +1,58 @@ +SUMMARY = "libgphoto2 allows you to access digital cameras" +SECTION = "libs" +LICENSE = "LGPL-2.1-only" +LIC_FILES_CHKSUM = "file://COPYING;md5=477378d78dfeeaa93826ee4ec7c643fb" + +DEPENDS = "libtool jpeg virtual/libusb0 libexif zlib libxml2" + +# The .fdi and .rules files were generated with: +# libgphoto2-2.5.8/packaging/generic$ qemu-arm -s 1048576 -r 2.6.24 -L /OE/angstrom-dev/staging/armv5te-angstrom-linux-gnueabi/ .libs/print-camera-list +# They are release specific, so please regen when adding new releases + +SRC_URI = "${SOURCEFORGE_MIRROR}/gphoto/libgphoto2-${PV}.tar.bz2;name=libgphoto2 \ + file://40-libgphoto2.rules \ + file://0001-configure.ac-remove-AM_PO_SUBDIRS.patch \ +" +SRC_URI[libgphoto2.sha256sum] = "ee61a1dac6ad5cf711d114e06b90a6d431961a6e7ec59f4b757a7cd77b1c0fb4" + +inherit autotools pkgconfig gettext lib_package + +EXTRA_OECONF = " --with-drivers=all udevscriptdir=${nonarch_base_libdir}/udev ac_cv_lib_ltdl_lt_dlcaller_register=yes" + +PACKAGECONFIG ??= "" +PACKAGECONFIG[gd] = ",--without-gdlib,gd" +PACKAGECONFIG[serial] = "--enable-serial,--disable-serial,lockdev" + +do_configure:prepend() { + rm -rf ${S}/libgphoto2_port/auto-m4/* + rm -rf ${S}/auto-m4/* +} + +do_configure:append() { + cp ${STAGING_DATADIR_NATIVE}/gettext/po/Makefile.in.in ${S}/libgphoto2_port/po/ + cd ${S}/libgphoto2_port/ + autoreconf -Wcross --verbose --install --force ${EXTRA_AUTORECONF} $acpaths + + # remove WORKDIR information from config to improve reproducibility + # libgphoto2_port recheck config will set the WORKDIR info again, so dont do that + sed -i 's/'$(echo ${WORKDIR} | sed 's_/_\\/_g')'/../g' ${B}/config.h + sed -i 's/'$(echo ${WORKDIR} | sed 's_/_\\/_g')'/../g' ${B}/libgphoto2_port/config.status + sed -i '/config\.status/ s/\-\-recheck//' ${B}/libgphoto2_port/Makefile + cd ${S} +} + +do_install:append() { + install -d ${D}${sysconfdir}/udev/rules.d/ + install -m 0644 ${WORKDIR}/*.rules ${D}${sysconfdir}/udev/rules.d/ +} + +PACKAGES =+ "libgphotoport libgphoto2-camlibs" +FILES:libgphoto2-camlibs = "${libdir}/libgphoto2*/*/*.so*" +RRECOMMENDS:${PN} = "libgphoto2-camlibs" + +FILES:libgphotoport = "${libdir}/libgphoto2_port.so.*" + +FILES:${PN} += "${nonarch_base_libdir}/udev/*" +FILES:${PN}-dbg += "${libdir}/*/*/.debug" +FILES:${PN}-dev += "${libdir}/*/*/*.la" +FILES:${PN}-doc += "${datadir}/libgphoto2_port/0.12.?/vcamera/README.txt" -- cgit v1.2.3-54-g00ecf