From dfdc9b3cc73e6fe88cc12792ba00e14642572339 Mon Sep 17 00:00:00 2001 From: Milan Crha Date: Thu, 15 May 2025 17:49:11 +0200 Subject: [PATCH] soup-multipart: Verify boundary limits for multipart body It could happen that the boundary started at a place which resulted into a negative number, which in an unsigned integer is a very large value. Check the body size is not a negative value before setting it. Closes https://gitlab.gnome.org/GNOME/libsoup/-/issues/449 Part-of: CVE: CVE-2025-4948 Upstream-Status: Backport [https://gitlab.gnome.org/GNOME/libsoup/-/merge_requests/463/diffs?commit_id=f2f28afe0b3b2b3009ab67d6874457ec6bac70c0] Signed-off-by: Changqing Li --- libsoup/soup-multipart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libsoup/soup-multipart.c b/libsoup/soup-multipart.c index dd93973..ce2fc10 100644 --- a/libsoup/soup-multipart.c +++ b/libsoup/soup-multipart.c @@ -214,7 +214,7 @@ soup_multipart_new_from_message (SoupMessageHeaders *headers, */ part_body = soup_buffer_new_subbuffer (flattened, split - flattened->data, - end - 2 - split); + end - 2 >= split ? end - 2 - split : 0); g_ptr_array_add (multipart->bodies, part_body); start = end; -- 2.34.1