summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKhem Raj <raj.khem@gmail.com>2020-01-02 12:38:39 -0800
committerMartin Jansa <Martin.Jansa@gmail.com>2020-01-07 11:19:25 +0100
commit3d47a5698ba73fc36212b391efb50e88ed7080d5 (patch)
treee60a0f86d946f377a485f78c7feb8fa0936a54ac
parentd8f0db7f8dfab14fbc309d215e2674078a871664 (diff)
downloadmeta-qt5-3d47a5698ba73fc36212b391efb50e88ed7080d5.tar.gz
qt5-creator: Make clang-format patch work with multiple clang versions
FormatStyle APIs keeps changing with clang versions. So there is no better way than checking for clang version to decide types, this ensures that it can build with various clang revs Signed-off-by: Khem Raj <raj.khem@gmail.com>
-rw-r--r--recipes-qt/qt5/qt5-creator/0001-clangformat-AllowShortIfStatementsOnASingleLine-is-n.patch31
1 files changed, 24 insertions, 7 deletions
diff --git a/recipes-qt/qt5/qt5-creator/0001-clangformat-AllowShortIfStatementsOnASingleLine-is-n.patch b/recipes-qt/qt5/qt5-creator/0001-clangformat-AllowShortIfStatementsOnASingleLine-is-n.patch
index 1bc3632d..7338f02b 100644
--- a/recipes-qt/qt5/qt5-creator/0001-clangformat-AllowShortIfStatementsOnASingleLine-is-n.patch
+++ b/recipes-qt/qt5/qt5-creator/0001-clangformat-AllowShortIfStatementsOnASingleLine-is-n.patch
@@ -18,19 +18,36 @@ Signed-off-by: Khem Raj <raj.khem@gmail.com>
18 src/plugins/clangformat/clangformatutils.cpp | 2 +- 18 src/plugins/clangformat/clangformatutils.cpp | 2 +-
19 1 file changed, 1 insertion(+), 1 deletion(-) 19 1 file changed, 1 insertion(+), 1 deletion(-)
20 20
21diff --git a/src/plugins/clangformat/clangformatutils.cpp b/src/plugins/clangformat/clangformatutils.cpp
22index 09a3150c89..7d8a95ae18 100644
23--- a/src/plugins/clangformat/clangformatutils.cpp 21--- a/src/plugins/clangformat/clangformatutils.cpp
24+++ b/src/plugins/clangformat/clangformatutils.cpp 22+++ b/src/plugins/clangformat/clangformatutils.cpp
25@@ -60,7 +60,7 @@ static clang::format::FormatStyle qtcStyle() 23@@ -57,10 +57,18 @@ static clang::format::FormatStyle qtcSty
24 style.AlignOperands = true;
25 style.AlignTrailingComments = true;
26 style.AllowAllParametersOfDeclarationOnNextLine = true;
27+#if Q_CC_CLANG < 1000
26 style.AllowShortBlocksOnASingleLine = false; 28 style.AllowShortBlocksOnASingleLine = false;
29+#else
30+ style.AllowShortBlocksOnASingleLine = FormatStyle::SBS_Never;
31+#endif
27 style.AllowShortCaseLabelsOnASingleLine = false; 32 style.AllowShortCaseLabelsOnASingleLine = false;
28 style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_Inline; 33 style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_Inline;
29- style.AllowShortIfStatementsOnASingleLine = false; 34+#if Q_CC_CLANG < 900
35 style.AllowShortIfStatementsOnASingleLine = false;
36+#else
30+ style.AllowShortIfStatementsOnASingleLine = FormatStyle::SIS_Never; 37+ style.AllowShortIfStatementsOnASingleLine = FormatStyle::SIS_Never;
38+#endif
31 style.AllowShortLoopsOnASingleLine = false; 39 style.AllowShortLoopsOnASingleLine = false;
32 style.AlwaysBreakAfterReturnType = FormatStyle::RTBS_None; 40 style.AlwaysBreakAfterReturnType = FormatStyle::RTBS_None;
33 style.AlwaysBreakBeforeMultilineStrings = false; 41 style.AlwaysBreakBeforeMultilineStrings = false;
34-- 42@@ -68,7 +76,11 @@ static clang::format::FormatStyle qtcSty
352.23.0 43 style.BinPackArguments = false;
36 44 style.BinPackParameters = false;
45 style.BraceWrapping.AfterClass = true;
46+#if Q_CC_CLANG < 1000
47 style.BraceWrapping.AfterControlStatement = false;
48+#else
49+ style.BraceWrapping.AfterControlStatement = FormatStyle::BWACS_Never;
50+#endif
51 style.BraceWrapping.AfterEnum = false;
52 style.BraceWrapping.AfterFunction = true;
53 style.BraceWrapping.AfterNamespace = false;