diff options
author | Mikko Gronoff <mikko.gronoff@qt.io> | 2019-08-07 10:27:09 +0300 |
---|---|---|
committer | Mikko Gronoff <mikko.gronoff@qt.io> | 2019-08-13 12:03:25 +0000 |
commit | 7388cd427d99ac7920394a31f176c0eb92521837 (patch) | |
tree | 82fc75b5ab0861a1f68fc52373660270a6818b21 /recipes-qt/qt5/qtwebengine | |
parent | 77ba83f3fbf777add748a437b80c19c6a1a5f989 (diff) | |
download | meta-qt5-7388cd427d99ac7920394a31f176c0eb92521837.tar.gz |
meta-qt5: update submodules
Change-Id: I4ec55015ee1006f7a61049bf1a8442476f129a8e
Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
Diffstat (limited to 'recipes-qt/qt5/qtwebengine')
4 files changed, 31 insertions, 192 deletions
diff --git a/recipes-qt/qt5/qtwebengine/0004-Fix-linker-too-long-argument-list.patch b/recipes-qt/qt5/qtwebengine/0004-Fix-linker-too-long-argument-list.patch deleted file mode 100644 index f42a1d19..00000000 --- a/recipes-qt/qt5/qtwebengine/0004-Fix-linker-too-long-argument-list.patch +++ /dev/null | |||
@@ -1,46 +0,0 @@ | |||
1 | From deb9d4818d5206314f290f22330ed3b7fc33d338 Mon Sep 17 00:00:00 2001 | ||
2 | From: Michal Klocek <michal.klocek@qt.io> | ||
3 | Date: Thu, 16 May 2019 21:58:06 +0200 | ||
4 | Subject: [PATCH] Fix linker too long argument list | ||
5 | |||
6 | For yocto builds linker can get quite long path | ||
7 | since all archives are listed as absolute paths. | ||
8 | This can end up as "execvp: /bin/sh: Argument list too long" | ||
9 | |||
10 | Use rsp files also for archives. | ||
11 | |||
12 | Change-Id: I096e2f35ed72b68261bf465e84baddd1f78cd917 | ||
13 | Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> | ||
14 | --- | ||
15 | src/core/core_module.pro | 17 ++++++++++------- | ||
16 | 1 file changed, 10 insertions(+), 7 deletions(-) | ||
17 | |||
18 | diff --git a/src/core/core_module.pro b/src/core/core_module.pro | ||
19 | index e2fa3494..10169a49 100644 | ||
20 | --- a/src/core/core_module.pro | ||
21 | +++ b/src/core/core_module.pro | ||
22 | @@ -25,14 +25,17 @@ isEmpty(NINJA_LIBS): error("Missing library files from QtWebEngineCore linking p | ||
23 | NINJA_OBJECTS = $$eval($$list($$NINJA_OBJECTS)) | ||
24 | # Do manual response file linking for macOS and Linux | ||
25 | |||
26 | -RSP_FILE = $$OUT_PWD/$$getConfigDir()/$${TARGET}.rsp | ||
27 | -for(object, NINJA_OBJECTS): RSP_CONTENT += $$object | ||
28 | -write_file($$RSP_FILE, RSP_CONTENT) | ||
29 | -macos:LIBS_PRIVATE += -Wl,-filelist,$$shell_quote($$RSP_FILE) | ||
30 | -linux:LIBS_PRIVATE += @$$RSP_FILE | ||
31 | +RSP_OBJECT_FILE = $$OUT_PWD/$$getConfigDir()/$${TARGET}_o.rsp | ||
32 | +for(object, NINJA_OBJECTS): RSP_O_CONTENT += $$object | ||
33 | +write_file($$RSP_OBJECT_FILE, RSP_O_CONTENT) | ||
34 | +RSP_ARCHIVE_FILE = $$OUT_PWD/$$getConfigDir()/$${TARGET}_a.rsp | ||
35 | +for(archive, NINJA_ARCHIVES): RSP_A_CONTENT += $$archive | ||
36 | +write_file($$RSP_ARCHIVE_FILE, RSP_A_CONTENT) | ||
37 | +macos:LIBS_PRIVATE += -Wl,-filelist,$$shell_quote($$RSP_OBJECT_FILE) | ||
38 | +linux:LIBS_PRIVATE += @$${RSP_OBJECT_FILE} | ||
39 | # QTBUG-58710 add main rsp file on windows | ||
40 | -win32:QMAKE_LFLAGS += @$$RSP_FILE | ||
41 | -linux: LIBS_PRIVATE += -Wl,--start-group $$NINJA_ARCHIVES -Wl,--end-group | ||
42 | +win32:QMAKE_LFLAGS += @$${RSP_OBJECT_FILE} | ||
43 | +linux: LIBS_PRIVATE += -Wl,--start-group @$${RSP_ARCHIVE_FILE} -Wl,--end-group | ||
44 | else: LIBS_PRIVATE += $$NINJA_ARCHIVES | ||
45 | LIBS_PRIVATE += $$NINJA_LIB_DIRS $$NINJA_LIBS | ||
46 | # GN's LFLAGS doesn't always work across all the Linux configurations we support. | ||
diff --git a/recipes-qt/qt5/qtwebengine/0005-Make-linker-call-look-great-again.patch b/recipes-qt/qt5/qtwebengine/0005-Make-linker-call-look-great-again.patch deleted file mode 100644 index 74afaac1..00000000 --- a/recipes-qt/qt5/qtwebengine/0005-Make-linker-call-look-great-again.patch +++ /dev/null | |||
@@ -1,115 +0,0 @@ | |||
1 | From 9ef91351545ef5543b469ef24282334b3d068a2b Mon Sep 17 00:00:00 2001 | ||
2 | From: Michal Klocek <michal.klocek@qt.io> | ||
3 | Date: Fri, 17 May 2019 15:49:23 +0200 | ||
4 | Subject: [PATCH] Make linker call look great again | ||
5 | |||
6 | Fix issues with messed up linker path: | ||
7 | |||
8 | * do not use LIBS_PRIVATE on linux at least for passing object | ||
9 | and archive responses files. | ||
10 | * do not use QT and QT_PRIVATE with same libs, it simply | ||
11 | includes libs in LIB and LIB_PRIVATE so doubles linker libs. | ||
12 | * remove bogus dependency for gui and core for webengineheaders pseudo module. | ||
13 | * remove unused egl config flag | ||
14 | |||
15 | Fixes: QTBUG-75832 | ||
16 | Task-number: QTBUG-75357 | ||
17 | Change-Id: I1720394e636e3f89d546f372b10932dd4ad395fe | ||
18 | Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> | ||
19 | --- | ||
20 | src/core/core_chromium.pri | 2 -- | ||
21 | src/core/core_common.pri | 4 ++-- | ||
22 | src/core/core_headers.pro | 1 + | ||
23 | src/core/core_module.pro | 13 ++++++------- | ||
24 | 4 files changed, 9 insertions(+), 11 deletions(-) | ||
25 | |||
26 | diff --git a/src/core/core_chromium.pri b/src/core/core_chromium.pri | ||
27 | index 4d8db0d1..d8ef25d8 100644 | ||
28 | --- a/src/core/core_chromium.pri | ||
29 | +++ b/src/core/core_chromium.pri | ||
30 | @@ -33,8 +33,6 @@ RCC_DIR = $$OUT_PWD/$$getConfigDir()/.rcc | ||
31 | # whenever we are cross compiling. | ||
32 | qtConfig(webengine-embedded-build): DEFINES += QTWEBENGINE_EMBEDDED_SWITCHES | ||
33 | |||
34 | -qtConfig(egl): CONFIG += egl | ||
35 | - | ||
36 | INCLUDEPATH += $$PWD $$PWD/api | ||
37 | |||
38 | clang_cl { | ||
39 | diff --git a/src/core/core_common.pri b/src/core/core_common.pri | ||
40 | index 8375d89e..51f5e21b 100644 | ||
41 | --- a/src/core/core_common.pri | ||
42 | +++ b/src/core/core_common.pri | ||
43 | @@ -2,8 +2,8 @@ | ||
44 | # gyp/ninja will take care of the compilation, qmake/make will finish with linking and install. | ||
45 | |||
46 | TARGET = QtWebEngineCore | ||
47 | -QT += qml quick | ||
48 | -QT_PRIVATE += quick-private gui-private core-private webenginecoreheaders-private | ||
49 | +QT += qml-private quick-private gui-private core-private | ||
50 | +QT_PRIVATE += webenginecoreheaders-private | ||
51 | |||
52 | qtConfig(webengine-geolocation): QT += positioning | ||
53 | qtConfig(webengine-webchannel): QT += webchannel | ||
54 | diff --git a/src/core/core_headers.pro b/src/core/core_headers.pro | ||
55 | index 21b5d58c..cd5352eb 100644 | ||
56 | --- a/src/core/core_headers.pro | ||
57 | +++ b/src/core/core_headers.pro | ||
58 | @@ -1,5 +1,6 @@ | ||
59 | TARGET = QtWebEngineCore | ||
60 | CONFIG += no_private_module header_module internal_module no_plist | ||
61 | +QT -= core gui | ||
62 | MODULE = webenginecoreheaders | ||
63 | MODULE_CFG_FILE = qtwebenginecore-config | ||
64 | load(qt_module) | ||
65 | diff --git a/src/core/core_module.pro b/src/core/core_module.pro | ||
66 | index 10169a49..2bfbc65b 100644 | ||
67 | --- a/src/core/core_module.pro | ||
68 | +++ b/src/core/core_module.pro | ||
69 | @@ -10,8 +10,6 @@ linking_pri = $$OUT_PWD/$$getConfigDir()/$${TARGET}.pri | ||
70 | error("Could not find the linking information that gn should have generated.") | ||
71 | } | ||
72 | |||
73 | -load(qt_module) | ||
74 | - | ||
75 | api_library_name = qtwebenginecoreapi$$qtPlatformTargetSuffix() | ||
76 | api_library_path = $$OUT_PWD/api/$$getConfigDir() | ||
77 | |||
78 | @@ -32,10 +30,10 @@ RSP_ARCHIVE_FILE = $$OUT_PWD/$$getConfigDir()/$${TARGET}_a.rsp | ||
79 | for(archive, NINJA_ARCHIVES): RSP_A_CONTENT += $$archive | ||
80 | write_file($$RSP_ARCHIVE_FILE, RSP_A_CONTENT) | ||
81 | macos:LIBS_PRIVATE += -Wl,-filelist,$$shell_quote($$RSP_OBJECT_FILE) | ||
82 | -linux:LIBS_PRIVATE += @$${RSP_OBJECT_FILE} | ||
83 | +linux:QMAKE_LFLAGS += @$${RSP_OBJECT_FILE} | ||
84 | # QTBUG-58710 add main rsp file on windows | ||
85 | win32:QMAKE_LFLAGS += @$${RSP_OBJECT_FILE} | ||
86 | -linux: LIBS_PRIVATE += -Wl,--start-group @$${RSP_ARCHIVE_FILE} -Wl,--end-group | ||
87 | +linux:QMAKE_LFLAGS += -Wl,--start-group @$${RSP_ARCHIVE_FILE} -Wl,--end-group | ||
88 | else: LIBS_PRIVATE += $$NINJA_ARCHIVES | ||
89 | LIBS_PRIVATE += $$NINJA_LIB_DIRS $$NINJA_LIBS | ||
90 | # GN's LFLAGS doesn't always work across all the Linux configurations we support. | ||
91 | @@ -74,7 +72,7 @@ osx { | ||
92 | # API library as response file to the linker. | ||
93 | QMAKE_LFLAGS += @$${api_library_path}$${QMAKE_DIR_SEP}$${api_library_name}.lib.objects | ||
94 | } else { | ||
95 | - LIBS_PRIVATE += -Wl,-whole-archive -l$$api_library_name -Wl,-no-whole-archive | ||
96 | + QMAKE_LFLAGS += -Wl,-whole-archive -l$$api_library_name -Wl,-no-whole-archive | ||
97 | } | ||
98 | |||
99 | win32 { | ||
100 | @@ -87,8 +85,6 @@ win32 { | ||
101 | # and doesn't let Chromium get access to libc symbols through dlsym. | ||
102 | CONFIG -= bsymbolic_functions | ||
103 | |||
104 | -qtConfig(egl): CONFIG += egl | ||
105 | - | ||
106 | linux:qtConfig(separate_debug_info): QMAKE_POST_LINK="cd $(DESTDIR) && $(STRIP) --strip-unneeded $(TARGET)" | ||
107 | |||
108 | REPACK_DIR = $$OUT_PWD/$$getConfigDir() | ||
109 | @@ -157,3 +153,6 @@ OTHER_FILES = \ | ||
110 | $$files(../3rdparty/chromium/*.gypi, true) \ | ||
111 | $$files(../3rdparty/chromium/*.gn, true) \ | ||
112 | $$files(../3rdparty/chromium/*.gni, true) | ||
113 | + | ||
114 | +load(qt_module) | ||
115 | + | ||
diff --git a/recipes-qt/qt5/qtwebengine/chromium/0019-chromium-fix-build-with-clang.patch b/recipes-qt/qt5/qtwebengine/chromium/0019-chromium-fix-build-with-clang.patch index 7823482b..8000969b 100644 --- a/recipes-qt/qt5/qtwebengine/chromium/0019-chromium-fix-build-with-clang.patch +++ b/recipes-qt/qt5/qtwebengine/chromium/0019-chromium-fix-build-with-clang.patch | |||
@@ -1,4 +1,4 @@ | |||
1 | From 249b99b4b54468b428a156f33e2a72066c82e9c2 Mon Sep 17 00:00:00 2001 | 1 | From a26e5b6c8cf6fccbd473ca61b2d0038703bb0b99 Mon Sep 17 00:00:00 2001 |
2 | From: Khem Raj <raj.khem@gmail.com> | 2 | From: Khem Raj <raj.khem@gmail.com> |
3 | Date: Sat, 2 Feb 2019 19:28:59 -0800 | 3 | Date: Sat, 2 Feb 2019 19:28:59 -0800 |
4 | Subject: [PATCH] chromium: fix build with clang | 4 | Subject: [PATCH] chromium: fix build with clang |
@@ -10,24 +10,10 @@ Signed-off-by: Khem Raj <raj.khem@gmail.com> | |||
10 | 1 file changed, 2 insertions(+), 25 deletions(-) | 10 | 1 file changed, 2 insertions(+), 25 deletions(-) |
11 | 11 | ||
12 | diff --git a/chromium/build/config/compiler/BUILD.gn b/chromium/build/config/compiler/BUILD.gn | 12 | diff --git a/chromium/build/config/compiler/BUILD.gn b/chromium/build/config/compiler/BUILD.gn |
13 | index d223a4f6fd4..1c42c49ea4a 100644 | 13 | index 127d0c4..eca0ce1 100644 |
14 | --- a/chromium/build/config/compiler/BUILD.gn | 14 | --- a/chromium/build/config/compiler/BUILD.gn |
15 | +++ b/chromium/build/config/compiler/BUILD.gn | 15 | +++ b/chromium/build/config/compiler/BUILD.gn |
16 | @@ -561,13 +561,6 @@ config("compiler") { | 16 | @@ -746,8 +746,6 @@ config("compiler_cpu_abi") { |
17 | } | ||
18 | } | ||
19 | |||
20 | - # Tells the compiler not to use absolute paths when passing the default | ||
21 | - # paths to the tools it invokes. We don't want this because we don't | ||
22 | - # really need it and it can mess up the goma cache entries. | ||
23 | - if (is_clang && !is_nacl) { | ||
24 | - cflags += [ "-no-canonical-prefixes" ] | ||
25 | - } | ||
26 | - | ||
27 | # C11/C++11 compiler flags setup. | ||
28 | # --------------------------- | ||
29 | if (is_linux || is_android || (is_nacl && is_clang) || current_os == "aix") { | ||
30 | @@ -799,8 +792,6 @@ config("compiler_cpu_abi") { | ||
31 | } | 17 | } |
32 | } else if (current_cpu == "arm") { | 18 | } else if (current_cpu == "arm") { |
33 | if (is_clang && !is_android && !is_nacl) { | 19 | if (is_clang && !is_android && !is_nacl) { |
@@ -36,7 +22,7 @@ index d223a4f6fd4..1c42c49ea4a 100644 | |||
36 | } | 22 | } |
37 | if (!is_nacl) { | 23 | if (!is_nacl) { |
38 | cflags += [ | 24 | cflags += [ |
39 | @@ -813,8 +804,6 @@ config("compiler_cpu_abi") { | 25 | @@ -760,8 +758,6 @@ config("compiler_cpu_abi") { |
40 | } | 26 | } |
41 | } else if (current_cpu == "arm64") { | 27 | } else if (current_cpu == "arm64") { |
42 | if (is_clang && !is_android && !is_nacl && !is_fuchsia) { | 28 | if (is_clang && !is_android && !is_nacl && !is_fuchsia) { |
@@ -45,7 +31,7 @@ index d223a4f6fd4..1c42c49ea4a 100644 | |||
45 | } | 31 | } |
46 | } else if (current_cpu == "mipsel" && !is_nacl) { | 32 | } else if (current_cpu == "mipsel" && !is_nacl) { |
47 | ldflags += [ "-Wl,--hash-style=sysv" ] | 33 | ldflags += [ "-Wl,--hash-style=sysv" ] |
48 | @@ -823,9 +812,6 @@ config("compiler_cpu_abi") { | 34 | @@ -770,9 +766,6 @@ config("compiler_cpu_abi") { |
49 | if (is_android) { | 35 | if (is_android) { |
50 | cflags += [ "--target=mipsel-linux-android" ] | 36 | cflags += [ "--target=mipsel-linux-android" ] |
51 | ldflags += [ "--target=mipsel-linux-android" ] | 37 | ldflags += [ "--target=mipsel-linux-android" ] |
@@ -55,7 +41,7 @@ index d223a4f6fd4..1c42c49ea4a 100644 | |||
55 | } | 41 | } |
56 | } else { | 42 | } else { |
57 | cflags += [ "-EL" ] | 43 | cflags += [ "-EL" ] |
58 | @@ -904,10 +890,7 @@ config("compiler_cpu_abi") { | 44 | @@ -851,10 +844,7 @@ config("compiler_cpu_abi") { |
59 | } else if (current_cpu == "mips" && !is_nacl) { | 45 | } else if (current_cpu == "mips" && !is_nacl) { |
60 | ldflags += [ "-Wl,--hash-style=sysv" ] | 46 | ldflags += [ "-Wl,--hash-style=sysv" ] |
61 | if (custom_toolchain == "") { | 47 | if (custom_toolchain == "") { |
@@ -67,7 +53,7 @@ index d223a4f6fd4..1c42c49ea4a 100644 | |||
67 | cflags += [ "-EB" ] | 53 | cflags += [ "-EB" ] |
68 | ldflags += [ "-EB" ] | 54 | ldflags += [ "-EB" ] |
69 | } | 55 | } |
70 | @@ -954,9 +937,6 @@ config("compiler_cpu_abi") { | 56 | @@ -901,9 +891,6 @@ config("compiler_cpu_abi") { |
71 | if (is_android) { | 57 | if (is_android) { |
72 | cflags += [ "--target=mips64el-linux-android" ] | 58 | cflags += [ "--target=mips64el-linux-android" ] |
73 | ldflags += [ "--target=mips64el-linux-android" ] | 59 | ldflags += [ "--target=mips64el-linux-android" ] |
@@ -77,7 +63,7 @@ index d223a4f6fd4..1c42c49ea4a 100644 | |||
77 | } | 63 | } |
78 | } else { | 64 | } else { |
79 | cflags += [ | 65 | cflags += [ |
80 | @@ -1013,10 +993,7 @@ config("compiler_cpu_abi") { | 66 | @@ -960,10 +947,7 @@ config("compiler_cpu_abi") { |
81 | } else if (current_cpu == "mips64") { | 67 | } else if (current_cpu == "mips64") { |
82 | ldflags += [ "-Wl,--hash-style=sysv" ] | 68 | ldflags += [ "-Wl,--hash-style=sysv" ] |
83 | if (custom_toolchain == "") { | 69 | if (custom_toolchain == "") { |
@@ -89,3 +75,17 @@ index d223a4f6fd4..1c42c49ea4a 100644 | |||
89 | cflags += [ | 75 | cflags += [ |
90 | "-EB", | 76 | "-EB", |
91 | "-mabi=64", | 77 | "-mabi=64", |
78 | @@ -1137,13 +1121,6 @@ config("compiler_deterministic") { | ||
79 | } | ||
80 | } | ||
81 | } | ||
82 | - | ||
83 | - # Tells the compiler not to use absolute paths when passing the default | ||
84 | - # paths to the tools it invokes. We don't want this because we don't | ||
85 | - # really need it and it can mess up the goma cache entries. | ||
86 | - if (is_clang && !is_nacl) { | ||
87 | - cflags += [ "-no-canonical-prefixes" ] | ||
88 | - } | ||
89 | } | ||
90 | |||
91 | config("clang_revision") { | ||
diff --git a/recipes-qt/qt5/qtwebengine/chromium/0021-chromium-Exclude-CRC32-for-32bit-arm.patch b/recipes-qt/qt5/qtwebengine/chromium/0021-chromium-Exclude-CRC32-for-32bit-arm.patch index a0b73a7b..7730e712 100644 --- a/recipes-qt/qt5/qtwebengine/chromium/0021-chromium-Exclude-CRC32-for-32bit-arm.patch +++ b/recipes-qt/qt5/qtwebengine/chromium/0021-chromium-Exclude-CRC32-for-32bit-arm.patch | |||
@@ -1,4 +1,4 @@ | |||
1 | From b882013421036a05ea8c909292cc38d05fc29c89 Mon Sep 17 00:00:00 2001 | 1 | From ffb83a8c687c18ec05bcf3397f08f6387b4c1ac2 Mon Sep 17 00:00:00 2001 |
2 | From: Khem Raj <raj.khem@gmail.com> | 2 | From: Khem Raj <raj.khem@gmail.com> |
3 | Date: Tue, 5 Feb 2019 14:32:20 -0800 | 3 | Date: Tue, 5 Feb 2019 14:32:20 -0800 |
4 | Subject: [PATCH] chromium: Exclude CRC32 for 32bit arm | 4 | Subject: [PATCH] chromium: Exclude CRC32 for 32bit arm |
@@ -15,20 +15,20 @@ Signed-off-by: Khem Raj <raj.khem@gmail.com> | |||
15 | 1 file changed, 4 insertions(+), 2 deletions(-) | 15 | 1 file changed, 4 insertions(+), 2 deletions(-) |
16 | 16 | ||
17 | diff --git a/chromium/third_party/zlib/BUILD.gn b/chromium/third_party/zlib/BUILD.gn | 17 | diff --git a/chromium/third_party/zlib/BUILD.gn b/chromium/third_party/zlib/BUILD.gn |
18 | index 05907b481ac..dbc4be143cd 100644 | 18 | index b9f1bba..e8a5c58 100644 |
19 | --- a/chromium/third_party/zlib/BUILD.gn | 19 | --- a/chromium/third_party/zlib/BUILD.gn |
20 | +++ b/chromium/third_party/zlib/BUILD.gn | 20 | +++ b/chromium/third_party/zlib/BUILD.gn |
21 | @@ -74,9 +74,11 @@ if (use_arm_neon_optimizations) { | 21 | @@ -77,9 +77,11 @@ if (use_arm_neon_optimizations) { |
22 | # implement the CRC32* instructions. These are optional in ARMv8.0." | 22 | # Disabled for iPhone, as described in DDI0487C_a_armv8_arm: |
23 | # - Fuchsia just added a syscall for feature detection. | 23 | # "All implementations of the ARMv8.1 architecture are required to |
24 | # TODO(cavalcantii): crbug.com/810125. | 24 | # implement the CRC32* instructions. These are optional in ARMv8.0." |
25 | + defines = [] | 25 | + defines = [] |
26 | if (is_clang && (!is_ios && !is_fuchsia)) { | 26 | if (is_clang && !is_ios) { |
27 | - defines = [ "CRC32_ARMV8_CRC32" ] | 27 | - defines = [ "CRC32_ARMV8_CRC32" ] |
28 | - if (is_android) { | 28 | - if (is_android) { |
29 | + if (current_cpu == "arm64") { | 29 | + if (current_cpu == "arm64") { |
30 | + defines += [ "CRC32_ARMV8_CRC32" ] | 30 | + defines += [ "CRC32_ARMV8_CRC32" ] |
31 | + } if (is_android) { | 31 | + } if (is_android) { |
32 | defines += [ "ARMV8_OS_ANDROID" ] | 32 | defines += [ "ARMV8_OS_ANDROID" ] |
33 | } else if (is_linux || is_chromeos) { | 33 | } else if (is_linux || is_chromeos) { |
34 | defines += [ "ARMV8_OS_LINUX" ] | 34 | defines += [ "ARMV8_OS_LINUX" ] |