diff options
3 files changed, 82 insertions, 0 deletions
diff --git a/recipes-qt/qt5/qtdeclarative-git/0001-Fix-wrong-calculation-of-viewPort-for-transitions.patch b/recipes-qt/qt5/qtdeclarative-git/0001-Fix-wrong-calculation-of-viewPort-for-transitions.patch new file mode 100644 index 00000000..5f201f97 --- /dev/null +++ b/recipes-qt/qt5/qtdeclarative-git/0001-Fix-wrong-calculation-of-viewPort-for-transitions.patch | |||
@@ -0,0 +1,41 @@ | |||
1 | From b93b61260b8eda33c01cef542777efbae2e8c570 Mon Sep 17 00:00:00 2001 | ||
2 | From: =?UTF-8?q?Florian=20H=C3=A4nel?= <florian.haenel@basyskom.com> | ||
3 | Date: Wed, 5 Jun 2013 19:23:32 +0200 | ||
4 | Subject: [PATCH 1/2] Fix wrong calculation of viewPort for transitions | ||
5 | |||
6 | Viewport is calculated wrong for horizontal layout in a second instance | ||
7 | |||
8 | Task-number: QTBUG-29944 | ||
9 | Task-Number: QTBUG-31546 | ||
10 | |||
11 | Upstream-Status: Pending | ||
12 | |||
13 | Looks like backport of https://codereview.qt-project.org/49226 but this | ||
14 | one was applied in previous patch, this change looks the same but is | ||
15 | in different part of qquickitemview.cpp and ISN'T applied yet in dev | ||
16 | branch. | ||
17 | |||
18 | Signed-off-by: Florian Haenel <florian.haenel@lge.com> | ||
19 | Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> | ||
20 | |||
21 | Change-Id: I136ae4484278d14f796613505e3f38c65ec51ebe | ||
22 | --- | ||
23 | src/quick/items/qquickitemview.cpp | 2 +- | ||
24 | 1 file changed, 1 insertion(+), 1 deletion(-) | ||
25 | |||
26 | diff --git a/src/quick/items/qquickitemview.cpp b/src/quick/items/qquickitemview.cpp | ||
27 | index d774091..aa489eb 100644 | ||
28 | --- a/src/quick/items/qquickitemview.cpp | ||
29 | +++ b/src/quick/items/qquickitemview.cpp | ||
30 | @@ -1815,7 +1815,7 @@ void QQuickItemViewPrivate::layout() | ||
31 | |||
32 | prepareVisibleItemTransitions(); | ||
33 | |||
34 | - QRectF viewBounds(0, position(), q->width(), q->height()); | ||
35 | + QRectF viewBounds(q->contentX(), q->contentY(), q->width(), q->height()); | ||
36 | for (QList<FxViewItem*>::Iterator it = releasePendingTransition.begin(); | ||
37 | it != releasePendingTransition.end(); ) { | ||
38 | FxViewItem *item = *it; | ||
39 | -- | ||
40 | 1.8.2.1 | ||
41 | |||
diff --git a/recipes-qt/qt5/qtdeclarative-git/0002-Fix-null-pointer-access-in-QQuickVisualDataModelPriv.patch b/recipes-qt/qt5/qtdeclarative-git/0002-Fix-null-pointer-access-in-QQuickVisualDataModelPriv.patch new file mode 100644 index 00000000..a61f8de2 --- /dev/null +++ b/recipes-qt/qt5/qtdeclarative-git/0002-Fix-null-pointer-access-in-QQuickVisualDataModelPriv.patch | |||
@@ -0,0 +1,37 @@ | |||
1 | From b47cfc601cf5d3c67289f72f43293846371993e2 Mon Sep 17 00:00:00 2001 | ||
2 | From: =?UTF-8?q?Florian=20H=C3=A4nel?= <florian.haenel@basyskom.com> | ||
3 | Date: Mon, 3 Jun 2013 13:40:09 +0200 | ||
4 | Subject: [PATCH 2/2] Fix null-pointer access in QQuickVisualDataModelPrivate | ||
5 | |||
6 | I observed null cachItem->contextData which lead to null-pointer access | ||
7 | on cacheItem->contextData->destroy(). | ||
8 | |||
9 | Task-number: QTBUG-31439 | ||
10 | |||
11 | Upstream-Status: Backport https://codereview.qt-project.org/57789 | ||
12 | |||
13 | Signed-of-by: Florian Haenel <florian.haenel@lge.com> | ||
14 | Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> | ||
15 | |||
16 | Change-Id: I91f28a3ee1ac83446ecde1801a1cb7962fb883f3 | ||
17 | --- | ||
18 | src/qml/types/qqmldelegatemodel.cpp | 3 ++- | ||
19 | 1 file changed, 2 insertions(+), 1 deletion(-) | ||
20 | |||
21 | diff --git a/src/qml/types/qqmldelegatemodel.cpp b/src/qml/types/qqmldelegatemodel.cpp | ||
22 | index 16572c4..f457538 100644 | ||
23 | --- a/src/qml/types/qqmldelegatemodel.cpp | ||
24 | +++ b/src/qml/types/qqmldelegatemodel.cpp | ||
25 | @@ -835,7 +835,8 @@ void QQmlDelegateModelPrivate::incubatorStatusChanged(QQDMIncubationTask *incuba | ||
26 | delete cacheItem->object; | ||
27 | cacheItem->object = 0; | ||
28 | cacheItem->scriptRef -= 1; | ||
29 | - cacheItem->contextData->destroy(); | ||
30 | + if (cacheItem->contextData) | ||
31 | + cacheItem->contextData->destroy(); | ||
32 | cacheItem->contextData = 0; | ||
33 | |||
34 | if (!cacheItem->isReferenced()) { | ||
35 | -- | ||
36 | 1.8.2.1 | ||
37 | |||
diff --git a/recipes-qt/qt5/qtdeclarative_git.bb b/recipes-qt/qt5/qtdeclarative_git.bb index b7f79bf2..e1418db5 100644 --- a/recipes-qt/qt5/qtdeclarative_git.bb +++ b/recipes-qt/qt5/qtdeclarative_git.bb | |||
@@ -3,4 +3,8 @@ require ${PN}.inc | |||
3 | 3 | ||
4 | PR = "${INC_PR}.0" | 4 | PR = "${INC_PR}.0" |
5 | 5 | ||
6 | SRC_URI += "file://0001-Fix-wrong-calculation-of-viewPort-for-transitions.patch \ | ||
7 | file://0002-Fix-null-pointer-access-in-QQuickVisualDataModelPriv.patch \ | ||
8 | " | ||
9 | |||
6 | SRCREV = "1d594c4e10caa9258f00bb7bcf61c307d027633b" | 10 | SRCREV = "1d594c4e10caa9258f00bb7bcf61c307d027633b" |