summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorniko.mauno@vaisala.com <niko.mauno@vaisala.com>2020-09-10 16:17:49 +0000
committerArmin Kuster <akuster808@gmail.com>2020-09-12 08:55:28 -0700
commitfd23d5256513cdf6641d8dd421a5c75a9b78b7d9 (patch)
tree968e3067c57fb4c59d68e41ed557e5f0e9d388f6
parentad55aaca1be60f6c1b066782e7ee6f6f323ffbbf (diff)
downloadmeta-security-fd23d5256513cdf6641d8dd421a5c75a9b78b7d9.tar.gz
dm-verity-img.bbclass: Reorder parse-time check
Relocate checking if DM_VERITY_IMAGE and DM_VERITY_IMAGE_TYPE are defined as non-empty strings before DM_VERITY_IMAGE vs. PN comparison is performed. By doing so we start seeing following kind of bitbake parse-time console warnings in case either DM_VERITY_IMAGE or DM_VERITY_IMAGE_TYPE is not set, when 'dm-verity-img' is defined in IMAGE_CLASSES: WARNING: .../meta/recipes-core/images/core-image-minimal.bb: dm-verity-img class inherited but not used WARNING: .../meta-openembedded/meta-oe/recipes-core/images/meta-oe-ptest-image.bb: dm-verity-img class inherited but not used whereas before this change this warning was printed only once, when image pointed by <DM_VERITY_IMAGE> was parsed (and recipe with that name could be found in BBFILES mask scipe), and DM_VERITY_IMAGE_TYPE was not set. Signed-off-by: Niko Mauno <niko.mauno@vaisala.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
-rw-r--r--classes/dm-verity-img.bbclass6
1 files changed, 3 insertions, 3 deletions
diff --git a/classes/dm-verity-img.bbclass b/classes/dm-verity-img.bbclass
index 6faed5b..6ad0f75 100644
--- a/classes/dm-verity-img.bbclass
+++ b/classes/dm-verity-img.bbclass
@@ -68,13 +68,13 @@ python __anonymous() {
68 image_fstypes = d.getVar('IMAGE_FSTYPES') 68 image_fstypes = d.getVar('IMAGE_FSTYPES')
69 pn = d.getVar('PN') 69 pn = d.getVar('PN')
70 70
71 if verity_image != pn:
72 return # This doesn't concern this image
73
74 if not verity_image or not verity_type: 71 if not verity_image or not verity_type:
75 bb.warn('dm-verity-img class inherited but not used') 72 bb.warn('dm-verity-img class inherited but not used')
76 return 73 return
77 74
75 if verity_image != pn:
76 return # This doesn't concern this image
77
78 if len(verity_type.split()) is not 1: 78 if len(verity_type.split()) is not 1:
79 bb.fatal('DM_VERITY_IMAGE_TYPE must contain exactly one type') 79 bb.fatal('DM_VERITY_IMAGE_TYPE must contain exactly one type')
80 80