From aef07c424d67f64de6f3a4efa127c6dfc1645c97 Mon Sep 17 00:00:00 2001 From: Bruce Ashfield Date: Fri, 5 Apr 2013 10:29:39 -0400 Subject: libvirt: add dtrace pkgconfig option If the host machine has dtrace, or systemtap development libraries installed, libvirt will detect their headers and enable dtrace probe support. But since we don't have a dependency on dtrace, the build will fail with: | compilation terminated. | In file included from ./internal.h:297:0, | from util/bitmap.h:27, | from util/bitmap.c:33: | ./libvirt_probes.h:9:21: fatal error: sys/sdt.h: No such file or directory There are three problems: - a host contamination issue - dtrace/probes being automatically enabled - a lack of integrated systemtap/dtrace solution Fixing any of the above will make the problem go away, to fix currently broken builds, we can fix the problem by adding dtrace as a PACKAGECONFIG option, and leaving it disabled. This change doesn't add a dtrace/systemtap dependency to the config entry, since they haven't been confirmed at this point. In the future, we should either fix the host contamination or do a full systemtap/dtrae integration, but for now, simply disabling it is the best choice. Signed-off-by: Bruce Ashfield --- recipes-extended/libvirt/libvirt_1.0.3.bb | 1 + 1 file changed, 1 insertion(+) diff --git a/recipes-extended/libvirt/libvirt_1.0.3.bb b/recipes-extended/libvirt/libvirt_1.0.3.bb index 372e8743..bf8c9ec8 100644 --- a/recipes-extended/libvirt/libvirt_1.0.3.bb +++ b/recipes-extended/libvirt/libvirt_1.0.3.bb @@ -128,6 +128,7 @@ PACKAGECONFIG[remote] = "--with-remote,--without-remote" PACKAGECONFIG[macvtap] = "--with-macvtap=yes,--with-macvtap=no,libnl,libnl" PACKAGECONFIG[libvirtd] = "--with-libvirtd,--without-libvirtd" PACKAGECONFIG[netcf] = "--with-netcf,--without-netcf,netcf,netcf" +PACKAGECONFIG[dtrace] = "--with-dtrace,--without-dtrace,," # Enable the Python tool support require libvirt-python.inc -- cgit v1.2.3-54-g00ecf