From f20fc414f30803c126bea4222d9fb2bb73c2b07f Mon Sep 17 00:00:00 2001 From: Nathan Rossi Date: Sun, 4 Nov 2018 20:58:15 -0800 Subject: machine-xilinx-default.inc: Add dtb files for IMAGE_BOOT_FILES Add all available dtb sources to the IMAGE_BOOT_FILES variable. For device-tree recipe generated dtbs the files available are only known after they files are deployed, so a wildcard pattern is used for these files. Note that this pattern appears before the kernel device trees due to the preference to use custom non-kernel device trees where available. This ordering is needed so that recipes like u-boot-zynq-uenv can pick the first device tree to select as the default. The kernel device trees are specifically selected based on the value of KERNEL_DEVICETREE, this avoid the duplication of kernel image type prefixed files along side having the actual files that the kernel builds. Additionally remove all instances of "${MACHINE}.dtb" as they no longer need to be specified and are incorrect due to the nesting of the files in the `devicetree` directory. Signed-off-by: Nathan Rossi Signed-off-by: Manjukumar Matha --- .../conf/machine/include/machine-xilinx-default.inc | 10 ++++++++-- meta-xilinx-bsp/conf/machine/microzed-zynq7.conf | 1 - meta-xilinx-bsp/conf/machine/picozed-zynq7.conf | 1 - meta-xilinx-bsp/conf/machine/qemu-zynq7.conf | 1 - meta-xilinx-bsp/conf/machine/zybo-linux-bd-zynq7.conf | 1 - meta-xilinx-contrib/conf/machine/minized-zynq7.conf | 1 - 6 files changed, 8 insertions(+), 7 deletions(-) diff --git a/meta-xilinx-bsp/conf/machine/include/machine-xilinx-default.inc b/meta-xilinx-bsp/conf/machine/include/machine-xilinx-default.inc index e4c99b8f..153a47fb 100644 --- a/meta-xilinx-bsp/conf/machine/include/machine-xilinx-default.inc +++ b/meta-xilinx-bsp/conf/machine/include/machine-xilinx-default.inc @@ -57,12 +57,18 @@ def get_default_image_boot_files(d): if d.getVar("UBOOT_BINARY"): files.append(d.getVar("UBOOT_BINARY")) + # device trees (device-tree only), these are first as they are likely desired over the kernel ones + if "device-tree" in (d.getVar("MACHINE_ESSENTIAL_EXTRA_RDEPENDS") or ""): + files.append("devicetree/*.dtb") + + # device trees (kernel only) if d.getVar("KERNEL_DEVICETREE"): dtbs = d.getVar("KERNEL_DEVICETREE").split(" ") dtbs = [os.path.basename(d) for d in dtbs] - if len(dtbs) != 0: - files += [d.getVar("KERNEL_IMAGETYPE") + "-" + dtb for dtb in dtbs] + for dtb in dtbs: + files.append(dtb) + return " ".join(files) XSERVER_EXT ?= "" diff --git a/meta-xilinx-bsp/conf/machine/microzed-zynq7.conf b/meta-xilinx-bsp/conf/machine/microzed-zynq7.conf index 188c5c5d..f5fee8c4 100644 --- a/meta-xilinx-bsp/conf/machine/microzed-zynq7.conf +++ b/meta-xilinx-bsp/conf/machine/microzed-zynq7.conf @@ -27,7 +27,6 @@ KERNEL_DEVICETREE = "zynq-microzed.dtb" IMAGE_BOOT_FILES += " \ boot.bin \ - zynq-microzed.dtb \ uEnv.txt \ " diff --git a/meta-xilinx-bsp/conf/machine/picozed-zynq7.conf b/meta-xilinx-bsp/conf/machine/picozed-zynq7.conf index a9067b90..28570af7 100644 --- a/meta-xilinx-bsp/conf/machine/picozed-zynq7.conf +++ b/meta-xilinx-bsp/conf/machine/picozed-zynq7.conf @@ -31,7 +31,6 @@ MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "device-tree" IMAGE_BOOT_FILES += " \ boot.bin \ - devicetree/${MACHINE}.dtb \ uEnv.txt \ " diff --git a/meta-xilinx-bsp/conf/machine/qemu-zynq7.conf b/meta-xilinx-bsp/conf/machine/qemu-zynq7.conf index 65bd46ad..97251048 100644 --- a/meta-xilinx-bsp/conf/machine/qemu-zynq7.conf +++ b/meta-xilinx-bsp/conf/machine/qemu-zynq7.conf @@ -14,7 +14,6 @@ MACHINE_FEATURES = "ext2 vfat" SERIAL_CONSOLE = "115200 ttyPS0" MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "device-tree" -IMAGE_BOOT_FILES += "devicetree/${MACHINE}.dtb" # Use the networking setup from qemuarm FILESOVERRIDES_append_pn-init-ifupdown = ":qemuarm" diff --git a/meta-xilinx-bsp/conf/machine/zybo-linux-bd-zynq7.conf b/meta-xilinx-bsp/conf/machine/zybo-linux-bd-zynq7.conf index 6cc89510..aec8bf68 100644 --- a/meta-xilinx-bsp/conf/machine/zybo-linux-bd-zynq7.conf +++ b/meta-xilinx-bsp/conf/machine/zybo-linux-bd-zynq7.conf @@ -32,7 +32,6 @@ EXTRA_IMAGEDEPENDS += " \ IMAGE_BOOT_FILES += " \ boot.bin \ - devicetree/${MACHINE}.dtb \ bitstream \ uEnv.txt \ " diff --git a/meta-xilinx-contrib/conf/machine/minized-zynq7.conf b/meta-xilinx-contrib/conf/machine/minized-zynq7.conf index 5bacdd50..ec706b6e 100644 --- a/meta-xilinx-contrib/conf/machine/minized-zynq7.conf +++ b/meta-xilinx-contrib/conf/machine/minized-zynq7.conf @@ -24,6 +24,5 @@ MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "device-tree" MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += "linux-firmware-bcm43430" IMAGE_BOOT_FILES += " \ - devicetree/${MACHINE}.dtb \ uEnv.txt \ " -- cgit v1.2.3-54-g00ecf