diff options
| -rw-r--r-- | meta/recipes-devtools/rpm/files/0001-CVE-2021-3521.patch | 57 | ||||
| -rw-r--r-- | meta/recipes-devtools/rpm/files/0001-Do-not-hardcode-lib-rpm-as-the-installation-path-for.patch | 14 | ||||
| -rw-r--r-- | meta/recipes-devtools/rpm/files/0001-configure.ac-add-linux-gnux32-variant-to-triplet-han.patch | 31 | ||||
| -rw-r--r-- | meta/recipes-devtools/rpm/files/0002-CVE-2021-3521.patch | 64 | ||||
| -rw-r--r-- | meta/recipes-devtools/rpm/files/0003-CVE-2021-3521.patch | 329 | ||||
| -rw-r--r-- | meta/recipes-devtools/rpm/rpm_4.17.1.bb (renamed from meta/recipes-devtools/rpm/rpm_4.17.0.bb) | 6 |
6 files changed, 40 insertions, 461 deletions
diff --git a/meta/recipes-devtools/rpm/files/0001-CVE-2021-3521.patch b/meta/recipes-devtools/rpm/files/0001-CVE-2021-3521.patch deleted file mode 100644 index 044b4dd2a0..0000000000 --- a/meta/recipes-devtools/rpm/files/0001-CVE-2021-3521.patch +++ /dev/null | |||
| @@ -1,57 +0,0 @@ | |||
| 1 | From 9a6871126f472feea057d5f803505ec8cc78f083 Mon Sep 17 00:00:00 2001 | ||
| 2 | From: Panu Matilainen <pmatilai@redhat.com> | ||
| 3 | Date: Thu, 30 Sep 2021 09:56:20 +0300 | ||
| 4 | Subject: [PATCH 1/3] Refactor pgpDigParams construction to helper function | ||
| 5 | |||
| 6 | No functional changes, just to reduce code duplication and needed by | ||
| 7 | the following commits. | ||
| 8 | |||
| 9 | CVE: CVE-2021-3521 | ||
| 10 | Upstream-Status: Backport [https://github.com/rpm-software-management/rpm/commit/9f03f42e2] | ||
| 11 | |||
| 12 | Signed-off-by: Changqing Li <changqing.li@windriver.com> | ||
| 13 | --- | ||
| 14 | rpmio/rpmpgp.c | 13 +++++++++---- | ||
| 15 | 1 file changed, 9 insertions(+), 4 deletions(-) | ||
| 16 | |||
| 17 | diff --git a/rpmio/rpmpgp.c b/rpmio/rpmpgp.c | ||
| 18 | index d0688ebe9a..e472b5320f 100644 | ||
| 19 | --- a/rpmio/rpmpgp.c | ||
| 20 | +++ b/rpmio/rpmpgp.c | ||
| 21 | @@ -1041,6 +1041,13 @@ unsigned int pgpDigParamsAlgo(pgpDigParams digp, unsigned int algotype) | ||
| 22 | return algo; | ||
| 23 | } | ||
| 24 | |||
| 25 | +static pgpDigParams pgpDigParamsNew(uint8_t tag) | ||
| 26 | +{ | ||
| 27 | + pgpDigParams digp = xcalloc(1, sizeof(*digp)); | ||
| 28 | + digp->tag = tag; | ||
| 29 | + return digp; | ||
| 30 | +} | ||
| 31 | + | ||
| 32 | int pgpPrtParams(const uint8_t * pkts, size_t pktlen, unsigned int pkttype, | ||
| 33 | pgpDigParams * ret) | ||
| 34 | { | ||
| 35 | @@ -1058,8 +1065,7 @@ int pgpPrtParams(const uint8_t * pkts, size_t pktlen, unsigned int pkttype, | ||
| 36 | if (pkttype && pkt.tag != pkttype) { | ||
| 37 | break; | ||
| 38 | } else { | ||
| 39 | - digp = xcalloc(1, sizeof(*digp)); | ||
| 40 | - digp->tag = pkt.tag; | ||
| 41 | + digp = pgpDigParamsNew(pkt.tag); | ||
| 42 | } | ||
| 43 | } | ||
| 44 | |||
| 45 | @@ -1105,8 +1111,7 @@ int pgpPrtParamsSubkeys(const uint8_t *pkts, size_t pktlen, | ||
| 46 | digps = xrealloc(digps, alloced * sizeof(*digps)); | ||
| 47 | } | ||
| 48 | |||
| 49 | - digps[count] = xcalloc(1, sizeof(**digps)); | ||
| 50 | - digps[count]->tag = PGPTAG_PUBLIC_SUBKEY; | ||
| 51 | + digps[count] = pgpDigParamsNew(PGPTAG_PUBLIC_SUBKEY); | ||
| 52 | /* Copy UID from main key to subkey */ | ||
| 53 | digps[count]->userid = xstrdup(mainkey->userid); | ||
| 54 | |||
| 55 | -- | ||
| 56 | 2.17.1 | ||
| 57 | |||
diff --git a/meta/recipes-devtools/rpm/files/0001-Do-not-hardcode-lib-rpm-as-the-installation-path-for.patch b/meta/recipes-devtools/rpm/files/0001-Do-not-hardcode-lib-rpm-as-the-installation-path-for.patch index 6d236ac400..c6cf9d4c88 100644 --- a/meta/recipes-devtools/rpm/files/0001-Do-not-hardcode-lib-rpm-as-the-installation-path-for.patch +++ b/meta/recipes-devtools/rpm/files/0001-Do-not-hardcode-lib-rpm-as-the-installation-path-for.patch | |||
| @@ -1,4 +1,4 @@ | |||
| 1 | From 8d013fe154a162305f76141151baf767dd04b598 Mon Sep 17 00:00:00 2001 | 1 | From 4ab6a4c5bbad65c3401016bb26b87214cdd0c59b Mon Sep 17 00:00:00 2001 |
| 2 | From: Alexander Kanavin <alex.kanavin@gmail.com> | 2 | From: Alexander Kanavin <alex.kanavin@gmail.com> |
| 3 | Date: Mon, 27 Feb 2017 09:43:30 +0200 | 3 | Date: Mon, 27 Feb 2017 09:43:30 +0200 |
| 4 | Subject: [PATCH] Do not hardcode "lib/rpm" as the installation path for | 4 | Subject: [PATCH] Do not hardcode "lib/rpm" as the installation path for |
| @@ -14,10 +14,10 @@ Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> | |||
| 14 | 3 files changed, 4 insertions(+), 4 deletions(-) | 14 | 3 files changed, 4 insertions(+), 4 deletions(-) |
| 15 | 15 | ||
| 16 | diff --git a/configure.ac b/configure.ac | 16 | diff --git a/configure.ac b/configure.ac |
| 17 | index eb7d6941b..10a889b5d 100644 | 17 | index 372875fc4..1b7add9ee 100644 |
| 18 | --- a/configure.ac | 18 | --- a/configure.ac |
| 19 | +++ b/configure.ac | 19 | +++ b/configure.ac |
| 20 | @@ -871,7 +871,7 @@ else | 20 | @@ -884,7 +884,7 @@ else |
| 21 | usrprefix=$prefix | 21 | usrprefix=$prefix |
| 22 | fi | 22 | fi |
| 23 | 23 | ||
| @@ -27,10 +27,10 @@ index eb7d6941b..10a889b5d 100644 | |||
| 27 | 27 | ||
| 28 | AC_SUBST(OBJDUMP) | 28 | AC_SUBST(OBJDUMP) |
| 29 | diff --git a/macros.in b/macros.in | 29 | diff --git a/macros.in b/macros.in |
| 30 | index a1f795e5f..689e784ef 100644 | 30 | index d53ab5ed5..9d10441c8 100644 |
| 31 | --- a/macros.in | 31 | --- a/macros.in |
| 32 | +++ b/macros.in | 32 | +++ b/macros.in |
| 33 | @@ -933,7 +933,7 @@ package or when debugging this package.\ | 33 | @@ -911,7 +911,7 @@ package or when debugging this package.\ |
| 34 | %_sharedstatedir %{_prefix}/com | 34 | %_sharedstatedir %{_prefix}/com |
| 35 | %_localstatedir %{_prefix}/var | 35 | %_localstatedir %{_prefix}/var |
| 36 | %_lib lib | 36 | %_lib lib |
| @@ -40,7 +40,7 @@ index a1f795e5f..689e784ef 100644 | |||
| 40 | %_infodir %{_datadir}/info | 40 | %_infodir %{_datadir}/info |
| 41 | %_mandir %{_datadir}/man | 41 | %_mandir %{_datadir}/man |
| 42 | diff --git a/rpm.am b/rpm.am | 42 | diff --git a/rpm.am b/rpm.am |
| 43 | index 7b57f433b..9bbb9ee96 100644 | 43 | index ebe4e40d1..e6920e258 100644 |
| 44 | --- a/rpm.am | 44 | --- a/rpm.am |
| 45 | +++ b/rpm.am | 45 | +++ b/rpm.am |
| 46 | @@ -1,10 +1,10 @@ | 46 | @@ -1,10 +1,10 @@ |
| @@ -55,4 +55,4 @@ index 7b57f433b..9bbb9ee96 100644 | |||
| 55 | +rpmconfigdir = $(libdir)/rpm | 55 | +rpmconfigdir = $(libdir)/rpm |
| 56 | 56 | ||
| 57 | # Libtool version (current-revision-age) for all our libraries | 57 | # Libtool version (current-revision-age) for all our libraries |
| 58 | rpm_version_info = 11:0:2 | 58 | rpm_version_info = 12:0:3 |
diff --git a/meta/recipes-devtools/rpm/files/0001-configure.ac-add-linux-gnux32-variant-to-triplet-han.patch b/meta/recipes-devtools/rpm/files/0001-configure.ac-add-linux-gnux32-variant-to-triplet-han.patch new file mode 100644 index 0000000000..2174a79e75 --- /dev/null +++ b/meta/recipes-devtools/rpm/files/0001-configure.ac-add-linux-gnux32-variant-to-triplet-han.patch | |||
| @@ -0,0 +1,31 @@ | |||
| 1 | From 8f51462d41d8fe942d5d0a06f08d47f625141995 Mon Sep 17 00:00:00 2001 | ||
| 2 | From: Alexander Kanavin <alex@linutronix.de> | ||
| 3 | Date: Thu, 4 Aug 2022 12:15:08 +0200 | ||
| 4 | Subject: [PATCH] configure.ac: add linux-gnux32 variant to triplet handling | ||
| 5 | |||
| 6 | x32 is a 64 bit x86 ABI with 32 bit pointers. | ||
| 7 | |||
| 8 | Upstream-Status: Submitted [https://github.com/rpm-software-management/rpm/pull/2143] | ||
| 9 | Signed-off-by: Alexander Kanavin <alex@linutronix.de> | ||
| 10 | --- | ||
| 11 | configure.ac | 4 ++++ | ||
| 12 | 1 file changed, 4 insertions(+) | ||
| 13 | |||
| 14 | diff --git a/configure.ac b/configure.ac | ||
| 15 | index 372875fc49..7d6a3d274e 100644 | ||
| 16 | --- a/configure.ac | ||
| 17 | +++ b/configure.ac | ||
| 18 | @@ -845,6 +845,10 @@ if echo "$host_os" | grep '.*-gnuabi64$' > /dev/null ; then | ||
| 19 | host_os=`echo "${host_os}" | sed 's/-gnuabi64$//'` | ||
| 20 | host_os_gnu=-gnuabi64 | ||
| 21 | fi | ||
| 22 | +if echo "$host_os" | grep '.*-gnux32$' > /dev/null ; then | ||
| 23 | + host_os=`echo "${host_os}" | sed 's/-gnux32$//'` | ||
| 24 | + host_os_gnu=-gnux32 | ||
| 25 | +fi | ||
| 26 | if echo "$host_os" | grep '.*-gnu$' > /dev/null ; then | ||
| 27 | host_os=`echo "${host_os}" | sed 's/-gnu$//'` | ||
| 28 | fi | ||
| 29 | -- | ||
| 30 | 2.30.2 | ||
| 31 | |||
diff --git a/meta/recipes-devtools/rpm/files/0002-CVE-2021-3521.patch b/meta/recipes-devtools/rpm/files/0002-CVE-2021-3521.patch deleted file mode 100644 index 683b57d455..0000000000 --- a/meta/recipes-devtools/rpm/files/0002-CVE-2021-3521.patch +++ /dev/null | |||
| @@ -1,64 +0,0 @@ | |||
| 1 | From c4b1bee51bbdd732b94b431a951481af99117703 Mon Sep 17 00:00:00 2001 | ||
| 2 | From: Panu Matilainen <pmatilai@redhat.com> | ||
| 3 | Date: Thu, 30 Sep 2021 09:51:10 +0300 | ||
| 4 | Subject: [PATCH 2/3] Process MPI's from all kinds of signatures | ||
| 5 | |||
| 6 | No immediate effect but needed by the following commits. | ||
| 7 | |||
| 8 | CVE: CVE-2021-3521 | ||
| 9 | Upstream-Status: Backport [https://github.com/rpm-software-management/rpm/commit/b5e8bc74b] | ||
| 10 | |||
| 11 | Signed-off-by: Changqing Li <changqing.li@windriver.com> | ||
| 12 | |||
| 13 | --- | ||
| 14 | rpmio/rpmpgp.c | 13 +++++-------- | ||
| 15 | 1 file changed, 5 insertions(+), 8 deletions(-) | ||
| 16 | |||
| 17 | diff --git a/rpmio/rpmpgp.c b/rpmio/rpmpgp.c | ||
| 18 | index 25f67048fd..509e777e6d 100644 | ||
| 19 | --- a/rpmio/rpmpgp.c | ||
| 20 | +++ b/rpmio/rpmpgp.c | ||
| 21 | @@ -543,7 +543,7 @@ pgpDigAlg pgpDigAlgFree(pgpDigAlg alg) | ||
| 22 | return NULL; | ||
| 23 | } | ||
| 24 | |||
| 25 | -static int pgpPrtSigParams(pgpTag tag, uint8_t pubkey_algo, uint8_t sigtype, | ||
| 26 | +static int pgpPrtSigParams(pgpTag tag, uint8_t pubkey_algo, | ||
| 27 | const uint8_t *p, const uint8_t *h, size_t hlen, | ||
| 28 | pgpDigParams sigp) | ||
| 29 | { | ||
| 30 | @@ -556,10 +556,8 @@ static int pgpPrtSigParams(pgpTag tag, uint8_t pubkey_algo, uint8_t sigtype, | ||
| 31 | int mpil = pgpMpiLen(p); | ||
| 32 | if (pend - p < mpil) | ||
| 33 | break; | ||
| 34 | - if (sigtype == PGPSIGTYPE_BINARY || sigtype == PGPSIGTYPE_TEXT) { | ||
| 35 | - if (sigalg->setmpi(sigalg, i, p)) | ||
| 36 | - break; | ||
| 37 | - } | ||
| 38 | + if (sigalg->setmpi(sigalg, i, p)) | ||
| 39 | + break; | ||
| 40 | p += mpil; | ||
| 41 | } | ||
| 42 | |||
| 43 | @@ -619,7 +617,7 @@ static int pgpPrtSig(pgpTag tag, const uint8_t *h, size_t hlen, | ||
| 44 | } | ||
| 45 | |||
| 46 | p = ((uint8_t *)v) + sizeof(*v); | ||
| 47 | - rc = pgpPrtSigParams(tag, v->pubkey_algo, v->sigtype, p, h, hlen, _digp); | ||
| 48 | + rc = pgpPrtSigParams(tag, v->pubkey_algo, p, h, hlen, _digp); | ||
| 49 | } break; | ||
| 50 | case 4: | ||
| 51 | { pgpPktSigV4 v = (pgpPktSigV4)h; | ||
| 52 | @@ -677,8 +675,7 @@ static int pgpPrtSig(pgpTag tag, const uint8_t *h, size_t hlen, | ||
| 53 | p += 2; | ||
| 54 | if (p > hend) | ||
| 55 | return 1; | ||
| 56 | - | ||
| 57 | - rc = pgpPrtSigParams(tag, v->pubkey_algo, v->sigtype, p, h, hlen, _digp); | ||
| 58 | + rc = pgpPrtSigParams(tag, v->pubkey_algo, p, h, hlen, _digp); | ||
| 59 | } break; | ||
| 60 | default: | ||
| 61 | rpmlog(RPMLOG_WARNING, _("Unsupported version of signature: V%d\n"), version); | ||
| 62 | -- | ||
| 63 | 2.17.1 | ||
| 64 | |||
diff --git a/meta/recipes-devtools/rpm/files/0003-CVE-2021-3521.patch b/meta/recipes-devtools/rpm/files/0003-CVE-2021-3521.patch deleted file mode 100644 index a5ec802501..0000000000 --- a/meta/recipes-devtools/rpm/files/0003-CVE-2021-3521.patch +++ /dev/null | |||
| @@ -1,329 +0,0 @@ | |||
| 1 | From 07676ca03ad8afcf1ca95a2353c83fbb1d970b9b Mon Sep 17 00:00:00 2001 | ||
| 2 | From: Panu Matilainen <pmatilai@redhat.com> | ||
| 3 | Date: Thu, 30 Sep 2021 09:59:30 +0300 | ||
| 4 | Subject: [PATCH 3/3] Validate and require subkey binding signatures on PGP | ||
| 5 | public keys | ||
| 6 | |||
| 7 | All subkeys must be followed by a binding signature by the primary key | ||
| 8 | as per the OpenPGP RFC, enforce the presence and validity in the parser. | ||
| 9 | |||
| 10 | The implementation is as kludgey as they come to work around our | ||
| 11 | simple-minded parser structure without touching API, to maximise | ||
| 12 | backportability. Store all the raw packets internally as we decode them | ||
| 13 | to be able to access previous elements at will, needed to validate ordering | ||
| 14 | and access the actual data. Add testcases for manipulated keys whose | ||
| 15 | import previously would succeed. | ||
| 16 | |||
| 17 | Depends on the two previous commits: | ||
| 18 | 7b399fcb8f52566e6f3b4327197a85facd08db91 and | ||
| 19 | 236b802a4aa48711823a191d1b7f753c82a89ec5 | ||
| 20 | |||
| 21 | Fixes CVE-2021-3521. | ||
| 22 | |||
| 23 | Upstream-Status: Backport [https://github.com/rpm-software-management/rpm/commit/bd36c5dc9] | ||
| 24 | CVE:CVE-2021-3521 | ||
| 25 | |||
| 26 | Signed-off-by: Changqing Li <changqing.li@windriver.com> | ||
| 27 | |||
| 28 | --- | ||
| 29 | rpmio/rpmpgp.c | 99 +++++++++++++++++-- | ||
| 30 | tests/Makefile.am | 3 + | ||
| 31 | tests/data/keys/CVE-2021-3521-badbind.asc | 25 +++++ | ||
| 32 | .../data/keys/CVE-2021-3521-nosubsig-last.asc | 25 +++++ | ||
| 33 | tests/data/keys/CVE-2021-3521-nosubsig.asc | 37 +++++++ | ||
| 34 | tests/rpmsigdig.at | 28 ++++++ | ||
| 35 | 6 files changed, 209 insertions(+), 8 deletions(-) | ||
| 36 | create mode 100644 tests/data/keys/CVE-2021-3521-badbind.asc | ||
| 37 | create mode 100644 tests/data/keys/CVE-2021-3521-nosubsig-last.asc | ||
| 38 | create mode 100644 tests/data/keys/CVE-2021-3521-nosubsig.asc | ||
| 39 | |||
| 40 | diff --git a/rpmio/rpmpgp.c b/rpmio/rpmpgp.c | ||
| 41 | index 509e777e6d..371ad4d9b6 100644 | ||
| 42 | --- a/rpmio/rpmpgp.c | ||
| 43 | +++ b/rpmio/rpmpgp.c | ||
| 44 | @@ -1061,33 +1061,116 @@ static pgpDigParams pgpDigParamsNew(uint8_t tag) | ||
| 45 | return digp; | ||
| 46 | } | ||
| 47 | |||
| 48 | +static int hashKey(DIGEST_CTX hash, const struct pgpPkt *pkt, int exptag) | ||
| 49 | +{ | ||
| 50 | + int rc = -1; | ||
| 51 | + if (pkt->tag == exptag) { | ||
| 52 | + uint8_t head[] = { | ||
| 53 | + 0x99, | ||
| 54 | + (pkt->blen >> 8), | ||
| 55 | + (pkt->blen ), | ||
| 56 | + }; | ||
| 57 | + | ||
| 58 | + rpmDigestUpdate(hash, head, 3); | ||
| 59 | + rpmDigestUpdate(hash, pkt->body, pkt->blen); | ||
| 60 | + rc = 0; | ||
| 61 | + } | ||
| 62 | + return rc; | ||
| 63 | +} | ||
| 64 | + | ||
| 65 | +static int pgpVerifySelf(pgpDigParams key, pgpDigParams selfsig, | ||
| 66 | + const struct pgpPkt *all, int i) | ||
| 67 | +{ | ||
| 68 | + int rc = -1; | ||
| 69 | + DIGEST_CTX hash = NULL; | ||
| 70 | + | ||
| 71 | + switch (selfsig->sigtype) { | ||
| 72 | + case PGPSIGTYPE_SUBKEY_BINDING: | ||
| 73 | + hash = rpmDigestInit(selfsig->hash_algo, 0); | ||
| 74 | + if (hash) { | ||
| 75 | + rc = hashKey(hash, &all[0], PGPTAG_PUBLIC_KEY); | ||
| 76 | + if (!rc) | ||
| 77 | + rc = hashKey(hash, &all[i-1], PGPTAG_PUBLIC_SUBKEY); | ||
| 78 | + } | ||
| 79 | + break; | ||
| 80 | + default: | ||
| 81 | + /* ignore types we can't handle */ | ||
| 82 | + rc = 0; | ||
| 83 | + break; | ||
| 84 | + } | ||
| 85 | + | ||
| 86 | + if (hash && rc == 0) | ||
| 87 | + rc = pgpVerifySignature(key, selfsig, hash); | ||
| 88 | + | ||
| 89 | + rpmDigestFinal(hash, NULL, NULL, 0); | ||
| 90 | + | ||
| 91 | + return rc; | ||
| 92 | +} | ||
| 93 | + | ||
| 94 | int pgpPrtParams(const uint8_t * pkts, size_t pktlen, unsigned int pkttype, | ||
| 95 | pgpDigParams * ret) | ||
| 96 | { | ||
| 97 | const uint8_t *p = pkts; | ||
| 98 | const uint8_t *pend = pkts + pktlen; | ||
| 99 | pgpDigParams digp = NULL; | ||
| 100 | - struct pgpPkt pkt; | ||
| 101 | + pgpDigParams selfsig = NULL; | ||
| 102 | + int i = 0; | ||
| 103 | + int alloced = 16; /* plenty for normal cases */ | ||
| 104 | + struct pgpPkt *all = xmalloc(alloced * sizeof(*all)); | ||
| 105 | int rc = -1; /* assume failure */ | ||
| 106 | + int expect = 0; | ||
| 107 | + int prevtag = 0; | ||
| 108 | |||
| 109 | while (p < pend) { | ||
| 110 | - if (decodePkt(p, (pend - p), &pkt)) | ||
| 111 | + struct pgpPkt *pkt = &all[i]; | ||
| 112 | + if (decodePkt(p, (pend - p), pkt)) | ||
| 113 | break; | ||
| 114 | |||
| 115 | if (digp == NULL) { | ||
| 116 | - if (pkttype && pkt.tag != pkttype) { | ||
| 117 | + if (pkttype && pkt->tag != pkttype) { | ||
| 118 | break; | ||
| 119 | } else { | ||
| 120 | - digp = pgpDigParamsNew(pkt.tag); | ||
| 121 | + digp = pgpDigParamsNew(pkt->tag); | ||
| 122 | } | ||
| 123 | } | ||
| 124 | |||
| 125 | - if (pgpPrtPkt(&pkt, digp)) | ||
| 126 | + if (expect) { | ||
| 127 | + if (pkt->tag != expect) | ||
| 128 | + break; | ||
| 129 | + selfsig = pgpDigParamsNew(pkt->tag); | ||
| 130 | + } | ||
| 131 | + if (pgpPrtPkt(pkt, selfsig ? selfsig : digp)) | ||
| 132 | break; | ||
| 133 | |||
| 134 | - p += (pkt.body - pkt.head) + pkt.blen; | ||
| 135 | - if (pkttype == PGPTAG_SIGNATURE) | ||
| 136 | - break; | ||
| 137 | + if (selfsig) { | ||
| 138 | + /* subkeys must be followed by binding signature */ | ||
| 139 | + if (prevtag == PGPTAG_PUBLIC_SUBKEY) { | ||
| 140 | + if (selfsig->sigtype != PGPSIGTYPE_SUBKEY_BINDING) | ||
| 141 | + break; | ||
| 142 | + } | ||
| 143 | + | ||
| 144 | + int xx = pgpVerifySelf(digp, selfsig, all, i); | ||
| 145 | + | ||
| 146 | + selfsig = pgpDigParamsFree(selfsig); | ||
| 147 | + if (xx) | ||
| 148 | + break; | ||
| 149 | + expect = 0; | ||
| 150 | + } | ||
| 151 | + | ||
| 152 | + if (pkt->tag == PGPTAG_PUBLIC_SUBKEY) | ||
| 153 | + expect = PGPTAG_SIGNATURE; | ||
| 154 | + prevtag = pkt->tag; | ||
| 155 | + | ||
| 156 | + i++; | ||
| 157 | + p += (pkt->body - pkt->head) + pkt->blen; | ||
| 158 | + if (pkttype == PGPTAG_SIGNATURE) | ||
| 159 | + break; | ||
| 160 | + | ||
| 161 | + if (alloced <= i) { | ||
| 162 | + alloced *= 2; | ||
| 163 | + all = xrealloc(all, alloced * sizeof(*all)); | ||
| 164 | + } | ||
| 165 | + | ||
| 166 | } | ||
| 167 | |||
| 168 | rc = (digp && (p == pend)) ? 0 : -1; | ||
| 169 | diff --git a/tests/Makefile.am b/tests/Makefile.am | ||
| 170 | index a41ce10de8..7bb23247f1 100644 | ||
| 171 | --- a/tests/Makefile.am | ||
| 172 | +++ b/tests/Makefile.am | ||
| 173 | @@ -107,6 +107,9 @@ EXTRA_DIST += data/SPECS/hello-config-buildid.spec | ||
| 174 | EXTRA_DIST += data/SPECS/hello-cd.spec | ||
| 175 | EXTRA_DIST += data/keys/rpm.org-rsa-2048-test.pub | ||
| 176 | EXTRA_DIST += data/keys/rpm.org-rsa-2048-test.secret | ||
| 177 | +EXTRA_DIST += data/keys/CVE-2021-3521-badbind.asc | ||
| 178 | +EXTRA_DIST += data/keys/CVE-2022-3521-nosubsig.asc | ||
| 179 | +EXTRA_DIST += data/keys/CVE-2022-3521-nosubsig-last.asc | ||
| 180 | EXTRA_DIST += data/macros.testfile | ||
| 181 | EXTRA_DIST += data/macros.debug | ||
| 182 | EXTRA_DIST += data/SOURCES/foo.c | ||
| 183 | diff --git a/tests/data/keys/CVE-2021-3521-badbind.asc b/tests/data/keys/CVE-2021-3521-badbind.asc | ||
| 184 | new file mode 100644 | ||
| 185 | index 0000000000..aea00f9d7a | ||
| 186 | --- /dev/null | ||
| 187 | +++ b/tests/data/keys/CVE-2021-3521-badbind.asc | ||
| 188 | @@ -0,0 +1,25 @@ | ||
| 189 | +-----BEGIN PGP PUBLIC KEY BLOCK----- | ||
| 190 | +Version: rpm-4.17.90 (NSS-3) | ||
| 191 | + | ||
| 192 | +mQENBFjmORgBCAC7TMEk6wnjSs8Dr4yqSScWdU2pjcqrkTxuzdWvowcIUPZI0w/g | ||
| 193 | +HkRqGd4apjvY2V15kjL10gk3QhFP3pZ/9p7zh8o8NHX7aGdSGDK7NOq1eFaErPRY | ||
| 194 | +91LW9RiZ0lbOjXEzIL0KHxUiTQEmdXJT43DJMFPyW9fkCWg0OltiX618FUdWWfI8 | ||
| 195 | +eySdLur1utnqBvdEbCUvWK2RX3vQZQdvEBODnNk2pxqTyV0w6VPQ96W++lF/5Aas | ||
| 196 | +7rUv3HIyIXxIggc8FRrnH+y9XvvHDonhTIlGnYZN4ubm9i4y3gOkrZlGTrEw7elQ | ||
| 197 | +1QeMyG2QQEbze8YjpTm4iLABCBrRfPRaQpwrABEBAAG0IXJwbS5vcmcgUlNBIHRl | ||
| 198 | +c3RrZXkgPHJzYUBycG0ub3JnPokBNwQTAQgAIQUCWOY5GAIbAwULCQgHAgYVCAkK | ||
| 199 | +CwIEFgIDAQIeAQIXgAAKCRBDRFkeGWTF/MxxCACnjqFL+MmPh9W9JQKT2DcLbBzf | ||
| 200 | +Cqo6wcEBoCOcwgRSk8dSikhARoteoa55JRJhuMyeKhhEAogE9HRmCPFdjezFTwgB | ||
| 201 | +BDVBpO2dZ023mLXDVCYX3S8pShOgCP6Tn4wqCnYeAdLcGg106N4xcmgtcssJE+Pr | ||
| 202 | +XzTZksbZsrTVEmL/Ym+R5w5jBfFnGk7Yw7ndwfQsfNXQb5AZynClFxnX546lcyZX | ||
| 203 | +fEx3/e6ezw57WNOUK6WT+8b+EGovPkbetK/rGxNXuWaP6X4A/QUm8O98nCuHYFQq | ||
| 204 | ++mvNdsCBqGf7mhaRGtpHk/JgCn5rFvArMDqLVrR9hX0LdCSsH7EGE+bR3r7wuQEN | ||
| 205 | +BFjmORgBCACk+vDZrIXQuFXEYToZVwb2attzbbJJCqD71vmZTLsW0QxuPKRgbcYY | ||
| 206 | +zp4K4lVBnHhFrF8MOUOxJ7kQWIJZMZFt+BDcptCYurbD2H4W2xvnWViiC+LzCMzz | ||
| 207 | +iMJT6165uefL4JHTDPxC2fFiM9yrc72LmylJNkM/vepT128J5Qv0gRUaQbHiQuS6 | ||
| 208 | +Dm/+WRnUfx3i89SV4mnBxb/Ta93GVqoOciWwzWSnwEnWYAvOb95JL4U7c5J5f/+c | ||
| 209 | +KnQDHsW7sIiIdscsWzvgf6qs2Ra1Zrt7Fdk4+ZS2f/adagLhDO1C24sXf5XfMk5m | ||
| 210 | +L0OGwZSr9m5s17VXxfspgU5ugc8kBJfzABEBAAE= | ||
| 211 | +=WCfs | ||
| 212 | +-----END PGP PUBLIC KEY BLOCK----- | ||
| 213 | + | ||
| 214 | diff --git a/tests/data/keys/CVE-2021-3521-nosubsig-last.asc b/tests/data/keys/CVE-2021-3521-nosubsig-last.asc | ||
| 215 | new file mode 100644 | ||
| 216 | index 0000000000..aea00f9d7a | ||
| 217 | --- /dev/null | ||
| 218 | +++ b/tests/data/keys/CVE-2021-3521-nosubsig-last.asc | ||
| 219 | @@ -0,0 +1,25 @@ | ||
| 220 | +-----BEGIN PGP PUBLIC KEY BLOCK----- | ||
| 221 | +Version: rpm-4.17.90 (NSS-3) | ||
| 222 | + | ||
| 223 | +mQENBFjmORgBCAC7TMEk6wnjSs8Dr4yqSScWdU2pjcqrkTxuzdWvowcIUPZI0w/g | ||
| 224 | +HkRqGd4apjvY2V15kjL10gk3QhFP3pZ/9p7zh8o8NHX7aGdSGDK7NOq1eFaErPRY | ||
| 225 | +91LW9RiZ0lbOjXEzIL0KHxUiTQEmdXJT43DJMFPyW9fkCWg0OltiX618FUdWWfI8 | ||
| 226 | +eySdLur1utnqBvdEbCUvWK2RX3vQZQdvEBODnNk2pxqTyV0w6VPQ96W++lF/5Aas | ||
| 227 | +7rUv3HIyIXxIggc8FRrnH+y9XvvHDonhTIlGnYZN4ubm9i4y3gOkrZlGTrEw7elQ | ||
| 228 | +1QeMyG2QQEbze8YjpTm4iLABCBrRfPRaQpwrABEBAAG0IXJwbS5vcmcgUlNBIHRl | ||
| 229 | +c3RrZXkgPHJzYUBycG0ub3JnPokBNwQTAQgAIQUCWOY5GAIbAwULCQgHAgYVCAkK | ||
| 230 | +CwIEFgIDAQIeAQIXgAAKCRBDRFkeGWTF/MxxCACnjqFL+MmPh9W9JQKT2DcLbBzf | ||
| 231 | +Cqo6wcEBoCOcwgRSk8dSikhARoteoa55JRJhuMyeKhhEAogE9HRmCPFdjezFTwgB | ||
| 232 | +BDVBpO2dZ023mLXDVCYX3S8pShOgCP6Tn4wqCnYeAdLcGg106N4xcmgtcssJE+Pr | ||
| 233 | +XzTZksbZsrTVEmL/Ym+R5w5jBfFnGk7Yw7ndwfQsfNXQb5AZynClFxnX546lcyZX | ||
| 234 | +fEx3/e6ezw57WNOUK6WT+8b+EGovPkbetK/rGxNXuWaP6X4A/QUm8O98nCuHYFQq | ||
| 235 | ++mvNdsCBqGf7mhaRGtpHk/JgCn5rFvArMDqLVrR9hX0LdCSsH7EGE+bR3r7wuQEN | ||
| 236 | +BFjmORgBCACk+vDZrIXQuFXEYToZVwb2attzbbJJCqD71vmZTLsW0QxuPKRgbcYY | ||
| 237 | +zp4K4lVBnHhFrF8MOUOxJ7kQWIJZMZFt+BDcptCYurbD2H4W2xvnWViiC+LzCMzz | ||
| 238 | +iMJT6165uefL4JHTDPxC2fFiM9yrc72LmylJNkM/vepT128J5Qv0gRUaQbHiQuS6 | ||
| 239 | +Dm/+WRnUfx3i89SV4mnBxb/Ta93GVqoOciWwzWSnwEnWYAvOb95JL4U7c5J5f/+c | ||
| 240 | +KnQDHsW7sIiIdscsWzvgf6qs2Ra1Zrt7Fdk4+ZS2f/adagLhDO1C24sXf5XfMk5m | ||
| 241 | +L0OGwZSr9m5s17VXxfspgU5ugc8kBJfzABEBAAE= | ||
| 242 | +=WCfs | ||
| 243 | +-----END PGP PUBLIC KEY BLOCK----- | ||
| 244 | + | ||
| 245 | diff --git a/tests/data/keys/CVE-2021-3521-nosubsig.asc b/tests/data/keys/CVE-2021-3521-nosubsig.asc | ||
| 246 | new file mode 100644 | ||
| 247 | index 0000000000..3a2e7417f8 | ||
| 248 | --- /dev/null | ||
| 249 | +++ b/tests/data/keys/CVE-2021-3521-nosubsig.asc | ||
| 250 | @@ -0,0 +1,37 @@ | ||
| 251 | +-----BEGIN PGP PUBLIC KEY BLOCK----- | ||
| 252 | +Version: rpm-4.17.90 (NSS-3) | ||
| 253 | + | ||
| 254 | +mQENBFjmORgBCAC7TMEk6wnjSs8Dr4yqSScWdU2pjcqrkTxuzdWvowcIUPZI0w/g | ||
| 255 | +HkRqGd4apjvY2V15kjL10gk3QhFP3pZ/9p7zh8o8NHX7aGdSGDK7NOq1eFaErPRY | ||
| 256 | +91LW9RiZ0lbOjXEzIL0KHxUiTQEmdXJT43DJMFPyW9fkCWg0OltiX618FUdWWfI8 | ||
| 257 | +eySdLur1utnqBvdEbCUvWK2RX3vQZQdvEBODnNk2pxqTyV0w6VPQ96W++lF/5Aas | ||
| 258 | +7rUv3HIyIXxIggc8FRrnH+y9XvvHDonhTIlGnYZN4ubm9i4y3gOkrZlGTrEw7elQ | ||
| 259 | +1QeMyG2QQEbze8YjpTm4iLABCBrRfPRaQpwrABEBAAG0IXJwbS5vcmcgUlNBIHRl | ||
| 260 | +c3RrZXkgPHJzYUBycG0ub3JnPokBNwQTAQgAIQUCWOY5GAIbAwULCQgHAgYVCAkK | ||
| 261 | +CwIEFgIDAQIeAQIXgAAKCRBDRFkeGWTF/MxxCACnjqFL+MmPh9W9JQKT2DcLbBzf | ||
| 262 | +Cqo6wcEBoCOcwgRSk8dSikhARoteoa55JRJhuMyeKhhEAogE9HRmCPFdjezFTwgB | ||
| 263 | +BDVBpO2dZ023mLXDVCYX3S8pShOgCP6Tn4wqCnYeAdLcGg106N4xcmgtcssJE+Pr | ||
| 264 | +XzTZksbZsrTVEmL/Ym+R5w5jBfFnGk7Yw7ndwfQsfNXQb5AZynClFxnX546lcyZX | ||
| 265 | +fEx3/e6ezw57WNOUK6WT+8b+EGovPkbetK/rGxNXuWaP6X4A/QUm8O98nCuHYFQq | ||
| 266 | ++mvNdsCBqGf7mhaRGtpHk/JgCn5rFvArMDqLVrR9hX0LdCSsH7EGE+bR3r7wuQEN | ||
| 267 | +BFjmORgBCACk+vDZrIXQuFXEYToZVwb2attzbbJJCqD71vmZTLsW0QxuPKRgbcYY | ||
| 268 | +zp4K4lVBnHhFrF8MOUOxJ7kQWIJZMZFt+BDcptCYurbD2H4W2xvnWViiC+LzCMzz | ||
| 269 | +iMJT6165uefL4JHTDPxC2fFiM9yrc72LmylJNkM/vepT128J5Qv0gRUaQbHiQuS6 | ||
| 270 | +Dm/+WRnUfx3i89SV4mnBxb/Ta93GVqoOciWwzWSnwEnWYAvOb95JL4U7c5J5f/+c | ||
| 271 | +KnQDHsW7sIiIdscsWzvgf6qs2Ra1Zrt7Fdk4+ZS2f/adagLhDO1C24sXf5XfMk5m | ||
| 272 | +L0OGwZSr9m5s17VXxfspgU5ugc8kBJfzABEBAAG5AQ0EWOY5GAEIAKT68NmshdC4 | ||
| 273 | +VcRhOhlXBvZq23NtskkKoPvW+ZlMuxbRDG48pGBtxhjOngriVUGceEWsXww5Q7En | ||
| 274 | +uRBYglkxkW34ENym0Ji6tsPYfhbbG+dZWKIL4vMIzPOIwlPrXrm558vgkdMM/ELZ | ||
| 275 | +8WIz3KtzvYubKUk2Qz+96lPXbwnlC/SBFRpBseJC5LoOb/5ZGdR/HeLz1JXiacHF | ||
| 276 | +v9Nr3cZWqg5yJbDNZKfASdZgC85v3kkvhTtzknl//5wqdAMexbuwiIh2xyxbO+B/ | ||
| 277 | +qqzZFrVmu3sV2Tj5lLZ/9p1qAuEM7ULbixd/ld8yTmYvQ4bBlKv2bmzXtVfF+ymB | ||
| 278 | +Tm6BzyQEl/MAEQEAAYkBHwQYAQgACQUCWOY5GAIbDAAKCRBDRFkeGWTF/PANB/9j | ||
| 279 | +mifmj6z/EPe0PJFhrpISt9PjiUQCt0IPtiL5zKAkWjHePIzyi+0kCTBF6DDLFxos | ||
| 280 | +3vN4bWnVKT1kBhZAQlPqpJTg+m74JUYeDGCdNx9SK7oRllATqyu+5rncgxjWVPnQ | ||
| 281 | +zu/HRPlWJwcVFYEVXYL8xzfantwQTqefjmcRmBRdA2XJITK+hGWwAmrqAWx+q5xX | ||
| 282 | +Pa8wkNMxVzNS2rUKO9SoVuJ/wlUvfoShkJ/VJ5HDp3qzUqncADfdGN35TDzscngQ | ||
| 283 | +gHvnMwVBfYfSCABV1hNByoZcc/kxkrWMmsd/EnIyLd1Q1baKqc3cEDuC6E6/o4yJ | ||
| 284 | +E4XX4jtDmdZPreZALsiB | ||
| 285 | +=rRop | ||
| 286 | +-----END PGP PUBLIC KEY BLOCK----- | ||
| 287 | + | ||
| 288 | diff --git a/tests/rpmsigdig.at b/tests/rpmsigdig.at | ||
| 289 | index 8e7c759b8f..e2d30a7f1b 100644 | ||
| 290 | --- a/tests/rpmsigdig.at | ||
| 291 | +++ b/tests/rpmsigdig.at | ||
| 292 | @@ -2,6 +2,34 @@ | ||
| 293 | |||
| 294 | AT_BANNER([RPM signatures and digests]) | ||
| 295 | |||
| 296 | +AT_SETUP([rpmkeys --import invalid keys]) | ||
| 297 | +AT_KEYWORDS([rpmkeys import]) | ||
| 298 | +RPMDB_INIT | ||
| 299 | + | ||
| 300 | +AT_CHECK([ | ||
| 301 | +runroot rpmkeys --import /data/keys/CVE-2021-3521-badbind.asc | ||
| 302 | +], | ||
| 303 | +[1], | ||
| 304 | +[], | ||
| 305 | +[error: /data/keys/CVE-2021-3521-badbind.asc: key 1 import failed.] | ||
| 306 | +) | ||
| 307 | +AT_CHECK([ | ||
| 308 | +runroot rpmkeys --import /data/keys/CVE-2021-3521-nosubsig.asc | ||
| 309 | +], | ||
| 310 | +[1], | ||
| 311 | +[], | ||
| 312 | +[error: /data/keys/CVE-2021-3521-nosubsig.asc: key 1 import failed.] | ||
| 313 | +) | ||
| 314 | + | ||
| 315 | +AT_CHECK([ | ||
| 316 | +runroot rpmkeys --import /data/keys/CVE-2021-3521-nosubsig-last.asc | ||
| 317 | +], | ||
| 318 | +[1], | ||
| 319 | +[], | ||
| 320 | +[error: /data/keys/CVE-2021-3521-nosubsig-last.asc: key 1 import failed.] | ||
| 321 | +) | ||
| 322 | +AT_CLEANUP | ||
| 323 | + | ||
| 324 | # ------------------------------ | ||
| 325 | # Test pre-built package verification | ||
| 326 | AT_SETUP([rpmkeys -Kv <unsigned> 1]) | ||
| 327 | -- | ||
| 328 | 2.17.1 | ||
| 329 | |||
diff --git a/meta/recipes-devtools/rpm/rpm_4.17.0.bb b/meta/recipes-devtools/rpm/rpm_4.17.1.bb index c392ac0db4..9b6446f265 100644 --- a/meta/recipes-devtools/rpm/rpm_4.17.0.bb +++ b/meta/recipes-devtools/rpm/rpm_4.17.1.bb | |||
| @@ -39,13 +39,11 @@ SRC_URI = "git://github.com/rpm-software-management/rpm;branch=rpm-4.17.x;protoc | |||
| 39 | file://0001-tools-Add-error.h-for-non-glibc-case.patch \ | 39 | file://0001-tools-Add-error.h-for-non-glibc-case.patch \ |
| 40 | file://0001-docs-do-not-build-manpages-requires-pandoc.patch \ | 40 | file://0001-docs-do-not-build-manpages-requires-pandoc.patch \ |
| 41 | file://0001-build-pack.c-do-not-insert-payloadflags-into-.rpm-me.patch \ | 41 | file://0001-build-pack.c-do-not-insert-payloadflags-into-.rpm-me.patch \ |
| 42 | file://0001-CVE-2021-3521.patch \ | 42 | file://0001-configure.ac-add-linux-gnux32-variant-to-triplet-han.patch \ |
| 43 | file://0002-CVE-2021-3521.patch \ | ||
| 44 | file://0003-CVE-2021-3521.patch \ | ||
| 45 | " | 43 | " |
| 46 | 44 | ||
| 47 | PE = "1" | 45 | PE = "1" |
| 48 | SRCREV = "3e74e8ba2dd5e76a5353d238dc7fc38651ce27b3" | 46 | SRCREV = "5bef402da334595ed9302b8bca1acdf5e88bfe11" |
| 49 | 47 | ||
| 50 | S = "${WORKDIR}/git" | 48 | S = "${WORKDIR}/git" |
| 51 | 49 | ||
