summaryrefslogtreecommitdiffstats
path: root/documentation/contributor-guide/submit-changes.rst
diff options
context:
space:
mode:
Diffstat (limited to 'documentation/contributor-guide/submit-changes.rst')
-rw-r--r--documentation/contributor-guide/submit-changes.rst32
1 files changed, 32 insertions, 0 deletions
diff --git a/documentation/contributor-guide/submit-changes.rst b/documentation/contributor-guide/submit-changes.rst
index da0668ebe9..68903ad7a8 100644
--- a/documentation/contributor-guide/submit-changes.rst
+++ b/documentation/contributor-guide/submit-changes.rst
@@ -735,6 +735,38 @@ argument to ``git format-patch`` with a version number::
735 735
736 git format-patch -v2 <ref-branch> 736 git format-patch -v2 <ref-branch>
737 737
738
739After generating updated patches (v2, v3, and so on) via ``git
740format-patch``, ideally developers will add a patch version changelog
741to each patch that describes what has changed between each revision of
742the patch. Add patch version changelogs after the ``---`` marker in the
743patch, indicating that this information is part of this patch, but is not
744suitable for inclusion in the commit message (i.e. the git history) itself.
745Providing a patch version changelog makes it easier for maintainers and
746reviewers to succinctly understand what changed in all versions of the
747patch, without having to consult alternate sources of information, such as
748searching through messages on a mailing list. For example::
749
750 <patch title>
751
752 <commit message>
753
754 <Signed-off-by/other trailers>
755 ---
756 changes in v4:
757 - provide a clearer commit message
758 - fix spelling mistakes
759
760 changes in v3:
761 - replace func() to use other_func() instead
762
763 changes in v2:
764 - this patch was added in v2
765 ---
766 <diffstat output>
767
768 <unified diff>
769
738Lastly please ensure that you also test your revised changes. In particular 770Lastly please ensure that you also test your revised changes. In particular
739please don't just edit the patch file written out by ``git format-patch`` and 771please don't just edit the patch file written out by ``git format-patch`` and
740resend it. 772resend it.