summaryrefslogtreecommitdiffstats
path: root/bitbake/lib/bb/ui
Commit message (Collapse)AuthorAgeFilesLines
...
* ui/uihelper: Keep track of task numbersRichard Purdie2012-03-151-0/+5
| | | | | | | | | | Add code so the uihelper keeps track of how may tasks we've run and how many tasks there are in total so UIs don't have to track this information themselves. (Bitbake rev: 17e68cfc6018b93d19738a6a874dfdea23fbab11) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Change Box's padding valueDongxiao Xu2012-03-157-15/+15
| | | | | | | | | | For Box type of widget, change the padding value to be HIG consistent, that is an increments of 6 pixels. (Bitbake rev: 0347e99ca5c232832f2b490584d76872c6d77311) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: improve recipe/package selection performanceDongxiao Xu2012-03-153-7/+5
| | | | | | | | | | | | | | | | Originally we will send selection chagned notification in each include_item and exclude_item, which is time cost since these are recursive functions and we may select hundreds of recipes/packages. The improvement is to move the notification from include_item and exclude_item to the place where the two functions are called. This could greatly improve the selection/deselection speed for recipe and package lists. (Bitbake rev: 5ad7c54f4b8739b9ae097c68978093a53f950ed7) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Add stop button for parsing progressDongxiao Xu2012-03-153-2/+37
| | | | | | | | | Add a Stop button to allow user to quit the parsing process. (Bitbake rev: a1936ff544f21cde0765f24dc9b0af126ca98752) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Emit command-failed signal even if error msg is NoneDongxiao Xu2012-03-152-9/+9
| | | | | | | (Bitbake rev: f4b5a9f243fcfb48cf01fa6f8bce35897debbd20) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Show recipe/package editing button after base image is selectedDongxiao Xu2012-03-152-3/+20
| | | | | | | | | Only show recipe and package editing button after base image is selected. (Bitbake rev: 5290d99f4d0f36076c59ec0b59e3f69b04d69ebf) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Remove the recipe/package populated signalDongxiao Xu2012-03-152-24/+8
| | | | | | | | | | | Handle the recipe and package list update in handler_command_succeeded_cb(), which could avoid potential race condition when doing recipe/package list updating and page switching. (Bitbake rev: 0c766a8c69782b2dd35a363dc9573b78f9d41995) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Remove the indication in machine/base image comboboxDongxiao Xu2012-03-152-14/+8
| | | | | | | | | | | Remove the "--select a machine--" prompt in machine selection. Also change "--select a base image--" to "Start from scratch" for base image selection. (Bitbake rev: ac36d218ed6793d6fbf3edfadaf193629ea1e46d) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Remove the reset button in recipe/package selection pageDongxiao Xu2012-03-153-26/+0
| | | | | | | (Bitbake rev: f576355686804631fd797e2a5d383a70f6fc42cd) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Fix the image installation dependencyDongxiao Xu2012-03-151-4/+2
| | | | | | | | | | Get the image installation content from rdepends and rrecommends variables. (Bitbake rev: a16b2245d7f5ef8509df0c543f9432c98367c79c) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Disable the handling of "NoProvider" eventDongxiao Xu2012-03-151-17/+20
| | | | | | | | | | | | | Currently for non-x86 architecture, there are un-resolved dependency issue when generate universe dependency tree. Therefore disable the handling of "NoProvider" event in Hob to enable the build for non-x86 architectures. After we resolved the dependency for universe, we still need to handle this event in Hob. (Bitbake rev: e3c5eed2244d7885418c59a62c9584f6397ee623) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: add "Close" button to "BinbDialog"Dongxiao Xu2012-03-151-2/+2
| | | | | | | | | | | | | For certain distributions, like FC16, it doesn't have close button in sub-windows or dialogs. Therefore we need to add an "Close" button to "BinbDialog" to close the dialog. Besides, let BinbDialog inherits the CrumbsDialog instead of gtk.Dialog (Bitbake rev: 5d33c355001bec91f4e4c3860db8d7ac2b449782) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/hig: special case stock info icons in CrumbsMesssageDialogJoshua Lock2012-03-121-1/+5
| | | | | | | | | | | The Hob visual design includes an info icon which should be used consistently throught the GUI. This change detects use of the stock info icon in CrumbsMessageDialog and uses the Hob info icon instead. (Bitbake rev: 37ed1589a19ffc82e8638b5375c99158988b38fc) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/hig: use HobInfoButton in place of gtk.Image with tooltipJoshua Lock2012-03-121-31/+15
| | | | | | | | | | Replace all instances of the stock info icon with an attached tooltip with the new HobInfoButton with associated PersistentTooltip. (Bitbake rev: cead9a2e32f0196536c51d3a0713c1f28a35bf3d) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/imageconfigurationpage: make use of the HobInfoButtonJoshua Lock2012-03-121-8/+4
| | | | | | | | | | | | | Use the new HobInfoButton widget in place of the existing gtk.Image with tooltip. Modify the markup of the tooltip so that the link to the reference manual is a clickable hyperlink. (Bitbake rev: 10b4a6770640db49f2f55b8ad7ce55aebb250598) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/crumbs/hobwidget: implement HobInfoButton per Hob interaction designJoshua Lock2012-03-121-0/+49
| | | | | | | | | | | | This button-like widget will display a persistent tooltip with the supplied Pango Markup when it is clicked by the user. This widget features prominently in the interaction design to offer help in a more prominent manner. (Bitbake rev: 43f33dcd6b7d1a08651cdf0715c2c2a9d488b103) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ui/icons: crop the info iconsJoshua Lock2012-03-122-0/+0
| | | | | | | | | | The info icons include large, transparent borders. Crop this out so that we can use the icon without using too much space in the GUI. (Bitbake rev: de5fbbd343081147e6b7a118daee7f678d49d0fa) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* crumbs/persistenttooltip: a new Gtk+ widget for use in HobJoshua Lock2012-03-121-0/+118
| | | | | | | | | | | | | | | | | The Hob interaction design calls for a top level widget which shows a persistent tooltip. This tooltip will not disappear until the user explicitly closes it. This allows us to provide clickable hyperlinks, longer instructions and deeper information in the tooltips. Note: by design the tooltip should dismiss when the user clicks off it, this implementation does include that functionality. It's a to do item. (Bitbake rev: b310fd429150d3a96ecde477934fffad4b4031da) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake/uihelper: restore line to record failed normal tasksPaul Eggleton2012-03-011-1/+6
| | | | | | | | | | | Save failed real (non-setscene) tasks to uihelper's failed task list. as before commit e8a3499c95a6d4f2b8fed002fb9504733c5be3c6. Currently this list is only used by the ncurses UI. (Bitbake rev: cc74cad0742ea0d4e09e843883cdc55bad39b22e) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: Fix pressing "stop" buildDongxiao Xu2012-03-011-5/+13
| | | | | | | | | | This commit fixes the behavior of clicking stop build button, it will stay in the build detail screen and show build is failed. (Bitbake rev: 80291865fa15012a3734e8724eb73c62b4ddc62f) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob(crumbs/builder.py): adjust the main window's position and ignore the ↵Shane Wang2012-03-011-8/+0
| | | | | | | | | | | | case lower than 1024x768. * don't set the position of the main window to the center always * don't show the message to users if their screen dimensions are lower than 1024x768 (Bitbake rev: 1afa500cb1cb5c10fc0a3ea0f65c7ecc8887efa8) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: fix a bug that the image size is shown incorrectly in the image details ↵Shane Wang2012-03-012-9/+25
| | | | | | | | | | | | page. Originally, the image size shows the last item in the image tree view in the image details page. That is not correct. We need to show the size of the image which the user chooses. (Bitbake rev: 01c18a24252b35959a4cc01088678f93cb2f95e5) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob(crumbs/hoblistmodel.py): Add mapping for rprovides and pkgDongxiao Xu2012-03-011-3/+12
| | | | | | | | | | | When checking the package's RDEPENDS information, we will see some case like A RDEPENDS virtual-b, and B RPROVIDES virtual-b, we need to reflect this relationship in packaging selection. (Bitbake rev: 44562593556e67d7976a124d5a420938aff95e0c) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob(crumbs/hoblistmodel.py): Fix recipe's populate() functionDongxiao Xu2012-03-011-37/+5
| | | | | | | | | | According to the cooker's change, this commit fixes the way to getting recipe's build dependency. (Bitbake rev: da64e59f2e738d6103605139ba2d3e2cdaa35b11) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* command.py: remove the resolve parameter in generateTargetsTreeDongxiao Xu2012-03-011-1/+1
| | | | | | | | | | Remove the "resolve" parameter since the original resolve=False option is no longer be used. (Bitbake rev: dadce609149cfb09ecdc53bfe1f416a3f57a5033) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob(crumbs/builder.py): remove the code commented out in the builder.pyShane Wang2012-03-011-1/+0
| | | | | | | (Bitbake rev: 7af747778121aa399f69aff58425ede523b2495c) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* crumbs/hig: tweak UI and layout of LayerSelectionDialogShane Wang2012-03-011-14/+5
| | | | | | | | | | | | | Several minor tweaks for appearance: * Try to rework the labels so that the English flows better * Fix spacing * Remove the separator - it's not needed (Bitbake rev: 53c5807c38e97d2e44a6f5c48449178b8b6e6261) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* hig: try to avoid setting explicit dialogue sizesShane Wang2012-03-011-5/+2
| | | | | | | | | | | Gtk+ does a good job of creating dialogues which fit all of the packed widgets and respect the spacing. Let it do its job. (Bitbake rev: 2469784b38f21716c09df89323c78cd20d3a4c14) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* crumbs: fix button order in several dialoguesShane Wang2012-03-012-26/+25
| | | | | | | | | | | | | | | GNOME HIG and Gtk+ convention is for the buttons to be ordered <secondary action> <primary action> so that the primary action can be selected easily by navigating to the bottom right of the dialogue. We should try and match the convention and the HIG standard so that we aren't contrasting the rest of the users applications. (Bitbake rev: e90828680e3bc655db54ed2797cad4587e8796d0) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* crumbs: move towards more standard dialogue spacingShane Wang2012-03-011-37/+29
| | | | | | | | | | | | Inherit from the base CrumbsDialog class which implements standard border and spacing. Switch all explicitly set dialogue spacings to 6 to converge towards GNOME HIG. (Bitbake rev: bf938987a007c94fc4bbacb2b4741b7c18cb62ec) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* crumbs/builder: use the name Hob consistentlyShane Wang2012-03-011-2/+2
| | | | | | | | | | | | | We have mentions of HOB and Hob, the approved name is Hob. "the name's Hob, BitBake Hob" - Surly BitBake GUI (Bitbake rev: 06adabbb36472625c1e47991e418346ef7438577) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* crumbs: Factor common dialogue configuration outShane Wang2012-03-012-18/+31
| | | | | | | | | | | | Factor out the base dialogue configuration into CrumbsDialog and create a new CrumbsMessageDialog which acts as the CrumbsDialog did to handle dialogues with buttons. Adopt CrumbsMessageDialog wherever CrumbsDialog was used. (Bitbake rev: d8c62f54d9f2421cfe7f1083b9d0acfe0373d38a) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: enable indicators on the "Included" tab in the recipe selection page ↵Shane Wang2012-03-012-0/+2
| | | | | | | | | and the package selection page (Bitbake rev: 504d480b208cacad7a5595312890f49fe19b80be) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: make the image configuration page not to flash the progress barShane Wang2012-03-011-16/+14
| | | | | | | | | Sometimes the image configuration page flashes the progress bar, that is because we show_all() and then hide() the progress bar. For this case, the patch doesn't add the progress bar onto the gtable. Then, it will not be flashed any more. (Bitbake rev: ef472710589580b9bfc64d2c02fa42f3ecbdfeb1) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: fix a bug in builder.configuration.curr_machShane Wang2012-03-011-0/+1
| | | | | | | | | | When the user changes the machine to be "--select a machine--", the builder.configuration.curr_mach should be set to empty. Otherwise, if the user adds more layers after the above, the action will trigger recipe parsing, which is not correct. (Bitbake rev: d5c7c9471b8e101ebcb91d707415b9c820b1419f) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: image configuration page doesn't need dialogs any moreShane Wang2012-03-011-3/+0
| | | | | | | | | The dialog references are all in builder.py. We remove the useless "import" in image configuration page. (Bitbake rev: 804f35e6864aeae2bb02550d9eb34120bbb60fa0) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: include hddimg and iso into image types.Shane Wang2012-03-014-11/+38
| | | | | | | | | | | | For image types, so far we don't include hddimg and iso. Then those files can not be deployed because they are filtered out in the image selection dialog. This patch is to include hddimg and iso (which are "live" in image types). Again, we have a TODO in the code for the future, that is to retrieve image types from the bitbake server instead of to use the walkaround. (Bitbake rev: d565507940be73fb5ea3ae7048d8d143c44c2a95) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: cleanup those class methods in HobWidgetShane Wang2012-03-013-493/+460
| | | | | | | | | | | | Some dialogs like advanced settings dialog, and layer selection dialog are using the class methods in HobWidget to create widgets for themselves, which is not a good design for OO. Clean up the code, and split the functions into the separate classes which use them actually. Finally, remove the class HobWidget. (Bitbake rev: f9cccea4d1c52ae2173fd94d5b07ceba7e5c0851) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: fixed the issue in the brought-in-by dialog.Shane Wang2012-03-014-36/+24
| | | | | | | | | | | When typing any thing in the search entry, the brough-in-by dialog will be shown. That is because we call back "selection-changed" signal to pop up the dialog, which is not correct. This patch is to fix the problem by using "row-activated" signal. (Bitbake rev: ea56ae787153460166697bbcae92f51a77ca1571) Signed-off-by: Liming An <limingx.l.an@intel.com> Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: avoid the image selection dialog to walk through all directories and ↵Shane Wang2012-03-011-4/+8
| | | | | | | | | | | its sub-directories, when users click "My images". The current implementation of the image selection dialog walks through all directories and its sub-directories, when users click "My images" to choose a directory. If the directory is /, the system becomes slow. This patch is to avoid walking through all directories but the child directories only, given a directory. (Bitbake rev: 536fa633b442ff37d43f45cf346ba281d69de496) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: make HobViewTable more general in hob and make the image selection ↵Shane Wang2012-03-015-152/+176
| | | | | | | | | | | | | | | dialog and the image details page reuse it. This patch is to make the class HobViewTable more general as a tree view in Hob. Now the recipe selection page and the package selection page are using it. And we have tree views in the image selection dialog and the image details page, which used the class methods in HobWidget to create the tree views. That is not good in OO. So, make them reuse HobViewTable to create its instances. (Bitbake rev: 3c900211e8bc0311542873480d79b347d7449f59) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake: fix setscene task start/failure handlingPaul Eggleton2012-02-282-2/+10
| | | | | | | | | | | | | * When a setscene task starts, print out that it's starting in the UI (ensuring we get the correct task name) * When a setscene task fails, ensure we remove it from the list of running tasks so that if you break out any time afterwards it is not still listed. (Bitbake rev: e8a3499c95a6d4f2b8fed002fb9504733c5be3c6) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* crumbs: add back progress implementation for depexpJoshua Lock2012-02-251-0/+20
| | | | | | | | | | The commit which introduced the new hob UI also deleted this class which is used by depexp. (Bitbake rev: d54dbe54cde8e0086bf1fb4926468e212660db53) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Hob: A new implemetation (v2)Dongxiao Xu2012-02-2443-2802/+5065
| | | | | | | | | | | | | | | | | | | | | This commit implements a new design for hob Some of the new features: - Friendly new designed GUI. Quick response to user actions. - Two step builds support package generation and image generation. - Support running GUI seprarately from bitbake server. - Recipe/package selection and deselection. - Accurate customization for image contents and size. - Progress bars showing the parsing and build status. - Load/save user configurations from/into templates. (Bitbake rev: 4dacd29f9c957d20f4583330b51e5420f9c3338d) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Liming An <limingx.l.an@intel.com> Signed-off-by: Fengxia Hua <fengxia.hua@intel.com> Designed-by: Belen Barros Pena <belen.barros.pena@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake: change for adding progress bar in Hob2.Shane Wang2012-02-231-1/+4
| | | | | | | | | | | | | The changes include: - Clean some events in event.py - Fire essential events for Hob2 to handle with more information. - knotty changes (Bitbake rev: 9ede881620c501574f014e600cea6947ea908ac2) Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake: Add client socket info for BitBakeServerConnectionDongxiao Xu2012-02-231-3/+4
| | | | | | | | | | In server/client split model, the client will bind to a specific address and port. We need to pass the values to BitBakeServerConnection(). (Bitbake rev: c8e19c5c389efc06696084c6f9439ba75472c5b7) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake/ui/knotty: fix incorrect exit codePaul Eggleton2012-02-221-1/+3
| | | | | | | | | | | | | The recent Ctrl+C patch was not fully tested; the variable it was relying upon is set to non-zero under other circumstances and thus bitbake was reporting that it was interrupted and returning a non-zero exit code when it was not. Track this status in a separate variable in order to fix the issue. (Bitbake rev: 95a599067650902727ecb4a39d6dd003c5cfedf3) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake/knotty: ensure CommandFailed increases error countPaul Eggleton2012-02-221-0/+1
| | | | | | | | | | | | CommandFailed already sets the return code, so we print out the error summary message, however we don't increase the error count so it is usually zero in this case. As we are actually showing an ERROR message, increment the error count so that the summary makes sense. (Bitbake rev: aeb71c3ca65dc42015c29c0e4cac050bfbcb51a5) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake/knotty: ensure we return non-zero exit code on Ctrl+CPaul Eggleton2012-02-221-0/+5
| | | | | | | | | | | | | | If the user uses Ctrl+C to exit out of the build, then ensure we return a non-zero exit code since the entire build was not completed successfully. If nothing else, this is useful to avoid continuing in the bitbake wrapper script in OE-Core if the initial pseudo build is interrupted. (Bitbake rev: c11eab7fa230f1fd5cc33589f3555b94e95f202d) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* knotty: shut down more cleanlyChristopher Larson2012-02-221-8/+7
| | | | | | | | | | | | | | | This ensures that when we are shutting down, we drain the queue of events from the server. This ensures that the server never gets hung up on the join of the feeder thread associated with the event queue, thereby avoiding a bitbake hang issue. Also, since the third keyboard interrupt now behaves the same as the second, removed that message. (Bitbake rev: ce9e0946b8a412616074809c76fba54f8bff36c4) Signed-off-by: Christopher Larson <chris_larson@mentor.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>