From f688f6b566f455eb55d6e5491c80b88c493e158b Mon Sep 17 00:00:00 2001 From: Alexandru DAMIAN Date: Tue, 1 Apr 2014 12:24:49 +0100 Subject: bitbake: bitbake: cooker: mark setFeatures command as read-only This patch makes sure that the setFeatures command is marked as read-only and that it can only run if the cooker is in the initial state. Additionally, remove logging from the XMLRPC module in favor of sending the exception to the client for easy processing. [YOCTO #6089] (Bitbake rev: f0a1a3e24757f7658d272035620465f92a3e4c3c) Signed-off-by: Alexandru DAMIAN Signed-off-by: Richard Purdie --- bitbake/lib/bb/server/xmlrpc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'bitbake/lib/bb/server/xmlrpc.py') diff --git a/bitbake/lib/bb/server/xmlrpc.py b/bitbake/lib/bb/server/xmlrpc.py index bf867b584b..5dcaa6c7b0 100644 --- a/bitbake/lib/bb/server/xmlrpc.py +++ b/bitbake/lib/bb/server/xmlrpc.py @@ -292,7 +292,7 @@ class BitBakeXMLRPCServerConnection(BitBakeBaseServerConnection): _, error = self.connection.runCommand(["setFeatures", self.featureset]) if error: - logger.error("Unable to set the cooker to the correct featureset: %s" % error) + # no need to log it here, the error shall be sent to the client raise BaseException(error) return self -- cgit v1.2.3-54-g00ecf