From 282cc1ea929f2dc43c095c0029c3b3974bb40566 Mon Sep 17 00:00:00 2001 From: Richard Purdie Date: Tue, 19 Nov 2024 10:30:14 +0000 Subject: bitbake: cooker: Drop support for BB_DANGLINGAPPENDS_WARNONLY DANGLINGAPPENDS_WARNONLY is a very poorly designed interface and is commonly abused. The challenge is that once it is set, by any layer, it applies everywhere. Some layers rely on this to get notification they need to update bbappend files and having the behaviour change from inclusion of an antisocial layer is not good. In addition, showing warnings as an accepted thing on the console devalues them and trains the user to ignore them. I want to steer us away from this mindset. We could extend the functionality and make it apply only to certain layers, or only to certain appends but then we've basically re-invented BBMASK. Given all the above, we should drop support for BB_DANGLINGAPPENDS_WARNONLY and direct anyone with issues to BBMASK instead. https://lists.openembedded.org/g/openembedded-architecture/message/2029 [YOCTO #14870] (Bitbake rev: fca9c9e3cb6f8e9f99bf51dc5e8a8d83f4c84c69) Signed-off-by: Richard Purdie --- bitbake/lib/bb/cooker.py | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) (limited to 'bitbake/lib') diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py index d58c0f575c..a8e0a81dc9 100644 --- a/bitbake/lib/bb/cooker.py +++ b/bitbake/lib/bb/cooker.py @@ -957,13 +957,7 @@ class BBCooker: '\n '.join(appends_without_recipes[mc]))) if msgs: - msg = "\n".join(msgs) - warn_only = self.databuilder.mcdata[mc].getVar("BB_DANGLINGAPPENDS_WARNONLY", \ - False) or "no" - if warn_only.lower() in ("1", "yes", "true"): - bb.warn(msg) - else: - bb.fatal(msg) + bb.fatal("\n".join(msgs)) def handlePrefProviders(self): -- cgit v1.2.3-54-g00ecf