From fafce983635a88fd9bb5a1afdbc06d8b90b393b5 Mon Sep 17 00:00:00 2001 From: Richard Purdie Date: Tue, 20 Dec 2022 11:44:05 +0000 Subject: bitbake: siggen: Minor code improvement Tweak the code to remove duplication and only set if the attribute isn't already there to avoid overwriting. (Bitbake rev: 513e6c4e9233e0d0bc31e1169077fdbf9aaf4ec3) Signed-off-by: Richard Purdie --- bitbake/lib/bb/siggen.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'bitbake/lib') diff --git a/bitbake/lib/bb/siggen.py b/bitbake/lib/bb/siggen.py index f551c74890..0e79404f76 100644 --- a/bitbake/lib/bb/siggen.py +++ b/bitbake/lib/bb/siggen.py @@ -273,11 +273,11 @@ class SignatureGeneratorBasic(SignatureGenerator): super().setup_datacache_from_datastore(mcfn, d) mc = bb.runqueue.mc_from_tid(mcfn) - setattr(self.datacaches[mc], "siggen_varvals", {}) + for attr in ["siggen_varvals", "siggen_taskdeps", "siggen_gendeps"]: + if not hasattr(self.datacaches[mc], attr): + setattr(self.datacaches[mc], attr, {}) self.datacaches[mc].siggen_varvals[mcfn] = d.getVar("__siggen_varvals") - setattr(self.datacaches[mc], "siggen_taskdeps", {}) self.datacaches[mc].siggen_taskdeps[mcfn] = d.getVar("__siggen_taskdeps") - setattr(self.datacaches[mc], "siggen_gendeps", {}) self.datacaches[mc].siggen_gendeps[mcfn] = d.getVar("__siggen_gendeps") def rundep_check(self, fn, recipename, task, dep, depname, dataCaches): -- cgit v1.2.3-54-g00ecf