From 597b87a46855a792d0d78209db1a85b96a50ac8e Mon Sep 17 00:00:00 2001 From: Alexander Kanavin Date: Wed, 17 Jul 2024 20:22:13 +0200 Subject: lib/oe/recipeutils: return a dict in get_recipe_upgrade_status() instead of a tuple Putting various things in a tuple is an anti-pattern of sorts, as the consumers have to unpack it into local variables for readability, or access items directly with indexes, which makes code pretty much unreadable. (From OE-Core rev: e86aa26d209eb9809198f6dd40cd058366318e3d) Signed-off-by: Alexander Kanavin Signed-off-by: Richard Purdie --- scripts/lib/devtool/upgrade.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'scripts/lib/devtool/upgrade.py') diff --git a/scripts/lib/devtool/upgrade.py b/scripts/lib/devtool/upgrade.py index 8e13833b51..10b4f8b5ee 100644 --- a/scripts/lib/devtool/upgrade.py +++ b/scripts/lib/devtool/upgrade.py @@ -659,13 +659,13 @@ def check_upgrade_status(args, config, basepath, workspace): results = oe.recipeutils.get_recipe_upgrade_status(args.recipe) for result in results: # pn, update_status, current, latest, maintainer, latest_commit, no_update_reason - if args.all or result[1] != 'MATCH': - print("{:25} {:15} {:15} {} {} {}".format( result[0], - result[2], - result[1] if result[1] != 'UPDATE' else (result[3] if not result[3].endswith("new-commits-available") else "new commits"), - result[4], - result[5] if result[5] != 'N/A' else "", - "cannot be updated due to: %s" %(result[6]) if result[6] else "")) + if args.all or result['status'] != 'MATCH': + print("{:25} {:15} {:15} {} {} {}".format( result['pn'], + result['cur_ver'], + result['status'] if result['status'] != 'UPDATE' else (result['next_ver'] if not result['next_ver'].endswith("new-commits-available") else "new commits"), + result['maintainer'], + result['revision'] if result['revision'] != 'N/A' else "", + "cannot be updated due to: %s" %(result['no_upgrade_reason']) if result['no_upgrade_reason'] else "")) def register_commands(subparsers, context): """Register devtool subcommands from this plugin""" -- cgit v1.2.3-54-g00ecf