summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGavin Mak <gavinmak@google.com>2023-03-24 01:17:31 +0000
committerLUCI <gerrit-scoped@luci-project-accounts.iam.gserviceaccount.com>2023-03-24 01:38:20 +0000
commit21cc3a9d53d3ab1f3de5b900ad7bb4969326994d (patch)
treec507e9bc618cbd5e0477a1723dd7f085126bc657
parentea2e330e43c182dc16b0111ebc69ee5a71ee4ce1 (diff)
downloadgit-repo-21cc3a9d53d3ab1f3de5b900ad7bb4969326994d.tar.gz
run_tests: Always check black and check it last
https://gerrit-review.googlesource.com/c/git-repo/+/363474/24..25 meant to improve run_tests UX by letting users rerun it quickly, but it also removed CQ enforcement of formatting since CQ passes args to run_tests. Run pytest first so devs don't have format first and always check black formatting so it's enforced in CQ. Bug: b/267675342 Change-Id: I09544f110a6eb71b0c6c640787e10b04991a804e Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/365727 Tested-by: Gavin Mak <gavinmak@google.com> Reviewed-by: Mike Frysinger <vapier@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com>
-rwxr-xr-xrun_tests2
1 files changed, 1 insertions, 1 deletions
diff --git a/run_tests b/run_tests
index e76f9d8c..69ba2769 100755
--- a/run_tests
+++ b/run_tests
@@ -31,8 +31,8 @@ def run_black():
31 31
32def main(argv): 32def main(argv):
33 """The main entry.""" 33 """The main entry."""
34 black_ret = 0 if argv else run_black()
35 pytest_ret = pytest.main(argv) 34 pytest_ret = pytest.main(argv)
35 black_ret = run_black()
36 return 0 if not black_ret and not pytest_ret else 1 36 return 0 if not black_ret and not pytest_ret else 1
37 37
38 38