diff options
author | Sebastian Schuberth <sschuberth@gmail.com> | 2020-01-20 11:42:48 +0100 |
---|---|---|
committer | Mike Frysinger <vapier@google.com> | 2020-01-24 16:10:51 +0000 |
commit | 8f997b38cbc762cbf6482bce3c96291e0b67bc1e (patch) | |
tree | 5492f857a691bef8be469211cc560d626aee4a51 | |
parent | 0eb2d3c8a0c59955e6b760f84904badc95b7fde8 (diff) | |
download | git-repo-8f997b38cbc762cbf6482bce3c96291e0b67bc1e.tar.gz |
repo: Do not even try to set up GPG with opt.no_repo_verify
In order to be able to use "--no-repo-verify" to work around an issue with
gpg-agent and long socket paths (see e.g. [1]), this change avoids GPG
being set up at all if that option is passed.
[1] https://github.com/elastic/elasticsearch/issues/17053
Change-Id: I1e5cbd8be2dc0084f12afe0ca33c789fdbc6fef9
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/251108
Reviewed-by: David Pursehouse <dpursehouse@collab.net>
Reviewed-by: Mike Frysinger <vapier@google.com>
Tested-by: Mike Frysinger <vapier@google.com>
-rwxr-xr-x | repo | 11 |
1 files changed, 7 insertions, 4 deletions
@@ -366,15 +366,18 @@ def _Init(args, gitc_init=False): | |||
366 | 366 | ||
367 | _CheckGitVersion() | 367 | _CheckGitVersion() |
368 | try: | 368 | try: |
369 | if NeedSetupGnuPG(): | 369 | if opt.no_repo_verify: |
370 | can_verify = SetupGnuPG(opt.quiet) | 370 | do_verify = False |
371 | else: | 371 | else: |
372 | can_verify = True | 372 | if NeedSetupGnuPG(): |
373 | do_verify = SetupGnuPG(opt.quiet) | ||
374 | else: | ||
375 | do_verify = True | ||
373 | 376 | ||
374 | dst = os.path.abspath(os.path.join(repodir, S_repo)) | 377 | dst = os.path.abspath(os.path.join(repodir, S_repo)) |
375 | _Clone(url, dst, opt.quiet, not opt.no_clone_bundle) | 378 | _Clone(url, dst, opt.quiet, not opt.no_clone_bundle) |
376 | 379 | ||
377 | if can_verify and not opt.no_repo_verify: | 380 | if do_verify: |
378 | rev = _Verify(dst, branch, opt.quiet) | 381 | rev = _Verify(dst, branch, opt.quiet) |
379 | else: | 382 | else: |
380 | rev = 'refs/remotes/origin/%s^0' % branch | 383 | rev = 'refs/remotes/origin/%s^0' % branch |