diff options
author | David Pursehouse <dpursehouse@collab.net> | 2016-10-29 07:28:35 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2016-10-29 07:28:35 +0000 |
commit | b881d227f3c5ab99c04866723cbc06fed4225e78 (patch) | |
tree | 04e410c06fea0b0969ea704ab3e251c87067bef1 | |
parent | 8e2d1d521ee68c6eb561d64301aad8cc69fa32d1 (diff) | |
parent | 27226e742d7e1a3d371531c19a3fdd91a4f9ab4a (diff) | |
download | git-repo-b881d227f3c5ab99c04866723cbc06fed4225e78.tar.gz |
Merge "Add a check and more output to protect against invalid REPO_URLs"
-rwxr-xr-x | repo | 9 |
1 files changed, 8 insertions, 1 deletions
@@ -347,6 +347,10 @@ def _Init(args, gitc_init=False): | |||
347 | dst = os.path.abspath(os.path.join(repodir, S_repo)) | 347 | dst = os.path.abspath(os.path.join(repodir, S_repo)) |
348 | _Clone(url, dst, opt.quiet, not opt.no_clone_bundle) | 348 | _Clone(url, dst, opt.quiet, not opt.no_clone_bundle) |
349 | 349 | ||
350 | if not os.path.isfile('%s/repo' % dst): | ||
351 | _print("warning: '%s' does not look like a git-repo repository, is " | ||
352 | "REPO_URL set correctly?" % url, file=sys.stderr) | ||
353 | |||
350 | if can_verify and not opt.no_repo_verify: | 354 | if can_verify and not opt.no_repo_verify: |
351 | rev = _Verify(dst, branch, opt.quiet) | 355 | rev = _Verify(dst, branch, opt.quiet) |
352 | else: | 356 | else: |
@@ -853,7 +857,10 @@ def main(orig_args): | |||
853 | try: | 857 | try: |
854 | _Init(args, gitc_init=(cmd == 'gitc-init')) | 858 | _Init(args, gitc_init=(cmd == 'gitc-init')) |
855 | except CloneFailure: | 859 | except CloneFailure: |
856 | shutil.rmtree(os.path.join(repodir, S_repo), ignore_errors=True) | 860 | path = os.path.join(repodir, S_repo) |
861 | _print("fatal: cloning the git-repo repository failed, will remove " | ||
862 | "'%s' " % path, file=sys.stderr) | ||
863 | shutil.rmtree(path, ignore_errors=True) | ||
857 | sys.exit(1) | 864 | sys.exit(1) |
858 | repo_main, rel_repo_dir = _FindRepo() | 865 | repo_main, rel_repo_dir = _FindRepo() |
859 | else: | 866 | else: |