summaryrefslogtreecommitdiffstats
path: root/git_superproject.py
diff options
context:
space:
mode:
authorRaman Tenneti <rtenneti@google.com>2021-05-12 12:00:31 -0700
committerRaman Tenneti <rtenneti@google.com>2021-05-18 15:35:54 +0000
commit993af5e136030ba9822f9a19e338e35ecc9581c7 (patch)
tree372bd79de5c397ea9feb1accf5bb4830293bdee7 /git_superproject.py
parent339f2df1ddd741070e340ec01d6882dd1eee617c (diff)
downloadgit-repo-993af5e136030ba9822f9a19e338e35ecc9581c7.tar.gz
superproject: Use bugurl from contactinfo in the missing commits error message.v2.15.1
+ In XmlManifest._Unload set 'bugurl' to Wrapper().BUG_URL. + contactinfo returns a namedtuple. + bug_url can be accessed as self._manifest.contactinfo.bugurl. Tested the code with the following commands. $ ./run_tests -v Added contactinfo tag to default.xml and verified that bugurl is used. Bug: [google internal] b/186220520. Change-Id: Iaafd6465e072b2e47a0a0b548bf6cb608a0b0a04 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/306342 Tested-by: Raman Tenneti <rtenneti@google.com> Reviewed-by: Mike Frysinger <vapier@google.com>
Diffstat (limited to 'git_superproject.py')
-rw-r--r--git_superproject.py3
1 files changed, 1 insertions, 2 deletions
diff --git a/git_superproject.py b/git_superproject.py
index 04e2078d..3168d9f8 100644
--- a/git_superproject.py
+++ b/git_superproject.py
@@ -28,7 +28,6 @@ import sys
28 28
29from git_command import GitCommand 29from git_command import GitCommand
30from git_refs import R_HEADS 30from git_refs import R_HEADS
31from wrapper import Wrapper
32 31
33_SUPERPROJECT_GIT_NAME = 'superproject.git' 32_SUPERPROJECT_GIT_NAME = 'superproject.git'
34_SUPERPROJECT_MANIFEST_NAME = 'superproject_override.xml' 33_SUPERPROJECT_MANIFEST_NAME = 'superproject_override.xml'
@@ -283,7 +282,7 @@ class Superproject(object):
283 projects_missing_commit_ids.append(path) 282 projects_missing_commit_ids.append(path)
284 if projects_missing_commit_ids: 283 if projects_missing_commit_ids:
285 print('error: please file a bug using %s to report missing commit_ids for: %s' % 284 print('error: please file a bug using %s to report missing commit_ids for: %s' %
286 (Wrapper().BUG_URL, projects_missing_commit_ids), file=sys.stderr) 285 (self._manifest.contactinfo.bugurl, projects_missing_commit_ids), file=sys.stderr)
287 return None 286 return None
288 287
289 manifest_path = self._WriteManfiestFile() 288 manifest_path = self._WriteManfiestFile()