summaryrefslogtreecommitdiffstats
path: root/manifest_xml.py
diff options
context:
space:
mode:
authorXD Trol <milestonejxd@gmail.com>2022-01-17 23:29:04 +0800
committerXD Trol <milestonejxd@gmail.com>2022-01-26 01:47:20 +0000
commit630876f9e4910a4c91705c6cc98414123547419a (patch)
treeaa7c9374ce0aba3107c563ab7c3407c10b54e735 /manifest_xml.py
parent4aa8584ec6a57b24c7e41e6fccd0b554a264423d (diff)
downloadgit-repo-630876f9e4910a4c91705c6cc98414123547419a.tar.gz
init: add an option --enable-git-lfs-filter
It was reported that git-lfs did not work with git-repo. Specifically, `git read-tree -u` run by `repo sync` would fail git-lfs's smudge filter. See https://github.com/github/git-lfs/issues/1422. In fact, by the time `git read-tree -u` is run, the repository is not bare. It is just that, the working directory is not the same as the .git directory. git-lfs's filter should work. No one seems to have delved into that issue. Today, with newer versions of git-repo and git-lfs, that issue will not reproduce. Tested with - git 2.33, git-lfs 2.13 on macOS - git 2.17, git-lfs 2.3 on ubuntu So, it seems fine to add an option --enable-git-lfs-filter, default to false, and stat that it may not work with older versions of git and git-lfs in the help doc. Bug: https://crbug.com/gerrit/14516 Change-Id: I8d21854eeeea541e072f63d6b10ad1253b1a9826 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/328359 Tested-by: XD Trol <milestonejxd@gmail.com> Reviewed-by: Mike Frysinger <vapier@google.com>
Diffstat (limited to 'manifest_xml.py')
-rw-r--r--manifest_xml.py4
1 files changed, 4 insertions, 0 deletions
diff --git a/manifest_xml.py b/manifest_xml.py
index 68ead53c..daf85d30 100644
--- a/manifest_xml.py
+++ b/manifest_xml.py
@@ -666,6 +666,10 @@ https://gerrit.googlesource.com/git-repo/+/HEAD/docs/manifest-format.md
666 def HasSubmodules(self): 666 def HasSubmodules(self):
667 return self.manifestProject.config.GetBoolean('repo.submodules') 667 return self.manifestProject.config.GetBoolean('repo.submodules')
668 668
669 @property
670 def EnableGitLfs(self):
671 return self.manifestProject.config.GetBoolean('repo.git-lfs')
672
669 def GetDefaultGroupsStr(self): 673 def GetDefaultGroupsStr(self):
670 """Returns the default group string for the platform.""" 674 """Returns the default group string for the platform."""
671 return 'default,platform-' + platform.system().lower() 675 return 'default,platform-' + platform.system().lower()