summaryrefslogtreecommitdiffstats
path: root/project.py
diff options
context:
space:
mode:
authorMike Frysinger <vapier@google.com>2019-11-15 01:19:03 -0500
committerMike Frysinger <vapier@google.com>2019-11-16 23:55:30 +0000
commit70c54dc2550084ed022a2f134065a011f37f30aa (patch)
tree6086cb67a1b1f928892b4d47d1b77a069b5ae31f /project.py
parent6da17751ca4e3b90834ca763f448ddc39b32651b (diff)
downloadgit-repo-70c54dc2550084ed022a2f134065a011f37f30aa.tar.gz
upload/editor: fix bytes/string confusion
The upload module tries to turn the strings into bytes before passing to EditString, but it combines bytes & strings causing an error. The return value might be bytes or string, but the caller only expects a string. Lets simplify this by sticking to strings everywhere and have EditString take care of converting to/from bytes when reading/writing the underlying files. This also avoids possible locale confusion when reading the file by forcing UTF-8 everywhere. Bug: https://crbug.com/gerrit/11929 Change-Id: I07b146170c5e8b5b0500a2c79e4213cd12140a96 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/245621 Reviewed-by: David Pursehouse <dpursehouse@collab.net> Tested-by: Mike Frysinger <vapier@google.com>
Diffstat (limited to 'project.py')
0 files changed, 0 insertions, 0 deletions