summaryrefslogtreecommitdiffstats
path: root/project.py
diff options
context:
space:
mode:
authorRaman Tenneti <rtenneti@google.com>2021-04-22 09:18:14 -0700
committerRaman Tenneti <rtenneti@google.com>2021-04-22 18:00:32 +0000
commitcd89ec147ad59f19ebe16a4a30b13606102213c0 (patch)
tree510b73aeb2e50ef938daeb1188a9174cac87ace5 /project.py
parentd41eed0b36013b84586e5da8bf2d00ae0730cf94 (diff)
downloadgit-repo-cd89ec147ad59f19ebe16a4a30b13606102213c0.tar.gz
sync: Fix exception in an exsiting clone (without partial-clone).v2.14.2
Default the partial_clone_exclude argument to an empty set. Fixes the following report by Emil Medve. With this change (up to v2.14.1), on an existing "normal" clone (without partial-clone options) I'm seeing this traceback during `repo selfupdate`: Traceback (most recent call last): File ".../.repo/repo/main.py", line 630, in <module> _Main(sys.argv[1:]) File ".../.repo/repo/main.py", line 604, in _Main result = run() File ".../.repo/repo/main.py", line 597, in <lambda> run = lambda: repo._Run(name, gopts, argv) or 0 File ".../.repo/repo/main.py", line 261, in _Run result = cmd.Execute(copts, cargs) File ".../.repo/repo/subcmds/selfupdate.py", line 54, in Execute if not rp.Sync_NetworkHalf(): File ".../.repo/repo/project.py", line 1091, in Sync_NetworkHalf if self.name in partial_clone_exclude: TypeError: argument of type 'NoneType' is not iterable $ ./run_tests -v Change-Id: I71e744e4ef2a37b13aa9ba42eba3935e78c4e40a Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/304082 Reviewed-by: Mike Frysinger <vapier@google.com> Tested-by: Raman Tenneti <rtenneti@google.com>
Diffstat (limited to 'project.py')
-rw-r--r--project.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/project.py b/project.py
index 1e31a20a..6679ee31 100644
--- a/project.py
+++ b/project.py
@@ -1051,7 +1051,7 @@ class Project(object):
1051 prune=False, 1051 prune=False,
1052 submodules=False, 1052 submodules=False,
1053 clone_filter=None, 1053 clone_filter=None,
1054 partial_clone_exclude=None): 1054 partial_clone_exclude=set()):
1055 """Perform only the network IO portion of the sync process. 1055 """Perform only the network IO portion of the sync process.
1056 Local working directory/branch state is not affected. 1056 Local working directory/branch state is not affected.
1057 """ 1057 """