diff options
author | Mike Frysinger <vapier@google.com> | 2020-02-22 00:07:35 -0500 |
---|---|---|
committer | Mike Frysinger <vapier@google.com> | 2020-03-14 04:02:42 +0000 |
commit | 4847e0574303f90438335a7c6c7c009145deb8ef (patch) | |
tree | 97190c4cad95c1b4ece90394ec5023d3a63ac7c1 /repo | |
parent | bb8ee7f54a4e0bf07d466304d800f13ec41ac21c (diff) | |
download | git-repo-4847e0574303f90438335a7c6c7c009145deb8ef.tar.gz |
repo/init/sync: rework default git download output
When we download git sources, we get a progress bar (good) and we get
a dump of all the refs we downloaded (bad) as it can easily be 100+ if
not 1000+ depending on the project (for each git repo!). Lets rework
the output behavior so that:
* quiet: Only errors.
* default: Progress bars (if on a tty).
* verbose: Full output (progress bars & downloaded refs).
Bug: https://crbug.com/gerrit/11293
Change-Id: I87a380075e79de6805f91095876dd1b37d32873a
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/256456
Tested-by: Mike Frysinger <vapier@google.com>
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Diffstat (limited to 'repo')
-rwxr-xr-x | repo | 10 |
1 files changed, 6 insertions, 4 deletions
@@ -758,15 +758,17 @@ def _InitHttp(): | |||
758 | 758 | ||
759 | def _Fetch(url, cwd, src, quiet, verbose): | 759 | def _Fetch(url, cwd, src, quiet, verbose): |
760 | cmd = ['fetch'] | 760 | cmd = ['fetch'] |
761 | if quiet: | 761 | if not verbose: |
762 | cmd.append('--quiet') | 762 | cmd.append('--quiet') |
763 | err = None | ||
764 | if not quiet and sys.stdout.isatty(): | ||
765 | cmd.append('--progress') | ||
766 | elif not verbose: | ||
763 | err = subprocess.PIPE | 767 | err = subprocess.PIPE |
764 | else: | ||
765 | err = None | ||
766 | cmd.append(src) | 768 | cmd.append(src) |
767 | cmd.append('+refs/heads/*:refs/remotes/origin/*') | 769 | cmd.append('+refs/heads/*:refs/remotes/origin/*') |
768 | cmd.append('+refs/tags/*:refs/tags/*') | 770 | cmd.append('+refs/tags/*:refs/tags/*') |
769 | run_git(*cmd, stderr=err, cwd=cwd) | 771 | run_git(*cmd, stderr=err, capture_output=False, cwd=cwd) |
770 | 772 | ||
771 | 773 | ||
772 | def _DownloadBundle(url, cwd, quiet, verbose): | 774 | def _DownloadBundle(url, cwd, quiet, verbose): |