diff options
author | Mike Frysinger <vapier@google.com> | 2025-03-25 12:50:36 -0400 |
---|---|---|
committer | LUCI <gerrit-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2025-03-25 11:19:49 -0700 |
commit | 8310436be083f8268bf8325bb2ffb65e9e178f6f (patch) | |
tree | 1aa0a97aee95407b7bdcca89df0fc57361900b36 /tests/test_git_superproject.py | |
parent | d5087392edcee3c0da4ba19efb6005efd9ccf706 (diff) | |
download | git-repo-8310436be083f8268bf8325bb2ffb65e9e178f6f.tar.gz |
run_tests: move test filtering to pytest markers
Move the test disable logic even closer to the exact test that's
disabled. This way people updating tests have a better chance of
seeing they'll get reduced coverage in the CQ.
Change-Id: I57c1a073a844019798b27e14d742fd32925d9ae8
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/462882
Tested-by: Mike Frysinger <vapier@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Mike Frysinger <vapier@google.com>
Diffstat (limited to 'tests/test_git_superproject.py')
-rw-r--r-- | tests/test_git_superproject.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/tests/test_git_superproject.py b/tests/test_git_superproject.py index 4e66521b..3ceb9320 100644 --- a/tests/test_git_superproject.py +++ b/tests/test_git_superproject.py | |||
@@ -21,6 +21,7 @@ import tempfile | |||
21 | import unittest | 21 | import unittest |
22 | from unittest import mock | 22 | from unittest import mock |
23 | 23 | ||
24 | import pytest | ||
24 | from test_manifest_xml import sort_attributes | 25 | from test_manifest_xml import sort_attributes |
25 | 26 | ||
26 | import git_superproject | 27 | import git_superproject |
@@ -145,6 +146,7 @@ class SuperprojectTestCase(unittest.TestCase): | |||
145 | ) | 146 | ) |
146 | self.assertIsNone(manifest.superproject) | 147 | self.assertIsNone(manifest.superproject) |
147 | 148 | ||
149 | @pytest.mark.skip_cq("TODO(b/266734831): Find out why this takes 8m+ in CQ") | ||
148 | def test_superproject_get_superproject_invalid_url(self): | 150 | def test_superproject_get_superproject_invalid_url(self): |
149 | """Test with an invalid url.""" | 151 | """Test with an invalid url.""" |
150 | manifest = self.getXmlManifest( | 152 | manifest = self.getXmlManifest( |
@@ -168,6 +170,7 @@ class SuperprojectTestCase(unittest.TestCase): | |||
168 | self.assertFalse(sync_result.success) | 170 | self.assertFalse(sync_result.success) |
169 | self.assertTrue(sync_result.fatal) | 171 | self.assertTrue(sync_result.fatal) |
170 | 172 | ||
173 | @pytest.mark.skip_cq("TODO(b/266734831): Find out why this takes 8m+ in CQ") | ||
171 | def test_superproject_get_superproject_invalid_branch(self): | 174 | def test_superproject_get_superproject_invalid_branch(self): |
172 | """Test with an invalid branch.""" | 175 | """Test with an invalid branch.""" |
173 | manifest = self.getXmlManifest( | 176 | manifest = self.getXmlManifest( |