summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--git_config.py10
-rw-r--r--subcmds/upload.py10
2 files changed, 14 insertions, 6 deletions
diff --git a/git_config.py b/git_config.py
index 9dba699a..b6288219 100644
--- a/git_config.py
+++ b/git_config.py
@@ -19,6 +19,8 @@ import re
19import subprocess 19import subprocess
20import sys 20import sys
21import time 21import time
22import urllib2
23
22from signal import SIGTERM 24from signal import SIGTERM
23from urllib2 import urlopen, HTTPError 25from urllib2 import urlopen, HTTPError
24from error import GitError, UploadError 26from error import GitError, UploadError
@@ -487,23 +489,25 @@ class Remote(object):
487 try: 489 try:
488 info = urlopen(u).read() 490 info = urlopen(u).read()
489 if info == 'NOT_AVAILABLE': 491 if info == 'NOT_AVAILABLE':
490 raise UploadError('Upload over ssh unavailable') 492 raise UploadError('%s: SSH disabled' % self.review)
491 if '<' in info: 493 if '<' in info:
492 # Assume the server gave us some sort of HTML 494 # Assume the server gave us some sort of HTML
493 # response back, like maybe a login page. 495 # response back, like maybe a login page.
494 # 496 #
495 raise UploadError('Cannot read %s:\n%s' % (u, info)) 497 raise UploadError('%s: Cannot parse response' % u)
496 498
497 self._review_protocol = 'ssh' 499 self._review_protocol = 'ssh'
498 self._review_host = info.split(" ")[0] 500 self._review_host = info.split(" ")[0]
499 self._review_port = info.split(" ")[1] 501 self._review_port = info.split(" ")[1]
502 except urllib2.URLError, e:
503 raise UploadError('%s: %s' % (self.review, e.reason[1]))
500 except HTTPError, e: 504 except HTTPError, e:
501 if e.code == 404: 505 if e.code == 404:
502 self._review_protocol = 'http-post' 506 self._review_protocol = 'http-post'
503 self._review_host = None 507 self._review_host = None
504 self._review_port = None 508 self._review_port = None
505 else: 509 else:
506 raise UploadError('Cannot guess Gerrit version') 510 raise UploadError('Upload over ssh unavailable')
507 511
508 REVIEW_CACHE[u] = ( 512 REVIEW_CACHE[u] = (
509 self._review_protocol, 513 self._review_protocol,
diff --git a/subcmds/upload.py b/subcmds/upload.py
index 8e3d2723..2ab6a484 100644
--- a/subcmds/upload.py
+++ b/subcmds/upload.py
@@ -273,15 +273,19 @@ Gerrit Code Review: http://code.google.com/p/gerrit/
273 have_errors = True 273 have_errors = True
274 274
275 print >>sys.stderr, '' 275 print >>sys.stderr, ''
276 print >>sys.stderr, '--------------------------------------------' 276 print >>sys.stderr, '----------------------------------------------------------------------'
277 277
278 if have_errors: 278 if have_errors:
279 for branch in todo: 279 for branch in todo:
280 if not branch.uploaded: 280 if not branch.uploaded:
281 print >>sys.stderr, '[FAILED] %-15s %-15s (%s)' % ( 281 if len(str(branch.error)) <= 30:
282 fmt = ' (%s)'
283 else:
284 fmt = '\n (%s)'
285 print >>sys.stderr, ('[FAILED] %-15s %-15s' + fmt) % (
282 branch.project.relpath + '/', \ 286 branch.project.relpath + '/', \
283 branch.name, \ 287 branch.name, \
284 branch.error) 288 str(branch.error))
285 print >>sys.stderr, '' 289 print >>sys.stderr, ''
286 290
287 for branch in todo: 291 for branch in todo: