summaryrefslogtreecommitdiffstats
path: root/subcmds/upload.py
diff options
context:
space:
mode:
Diffstat (limited to 'subcmds/upload.py')
-rw-r--r--subcmds/upload.py14
1 files changed, 9 insertions, 5 deletions
diff --git a/subcmds/upload.py b/subcmds/upload.py
index 674fc17d..1172dadc 100644
--- a/subcmds/upload.py
+++ b/subcmds/upload.py
@@ -454,9 +454,15 @@ Gerrit Code Review: http://code.google.com/p/gerrit/
454 if avail: 454 if avail:
455 pending.append((project, avail)) 455 pending.append((project, avail))
456 456
457 if pending and (not opt.bypass_hooks): 457 if not pending:
458 print("no branches ready for upload", file=sys.stderr)
459 return
460
461 if not opt.bypass_hooks:
458 hook = RepoHook('pre-upload', self.manifest.repo_hooks_project, 462 hook = RepoHook('pre-upload', self.manifest.repo_hooks_project,
459 self.manifest.topdir, abort_if_user_denies=True) 463 self.manifest.topdir,
464 self.manifest.manifestProject.GetRemote('origin').url,
465 abort_if_user_denies=True)
460 pending_proj_names = [project.name for (project, avail) in pending] 466 pending_proj_names = [project.name for (project, avail) in pending]
461 pending_worktrees = [project.worktree for (project, avail) in pending] 467 pending_worktrees = [project.worktree for (project, avail) in pending]
462 try: 468 try:
@@ -472,9 +478,7 @@ Gerrit Code Review: http://code.google.com/p/gerrit/
472 cc = _SplitEmails(opt.cc) 478 cc = _SplitEmails(opt.cc)
473 people = (reviewers, cc) 479 people = (reviewers, cc)
474 480
475 if not pending: 481 if len(pending) == 1 and len(pending[0][1]) == 1:
476 print("no branches ready for upload", file=sys.stderr)
477 elif len(pending) == 1 and len(pending[0][1]) == 1:
478 self._SingleBranch(opt, pending[0][1][0], people) 482 self._SingleBranch(opt, pending[0][1][0], people)
479 else: 483 else:
480 self._MultipleBranches(opt, pending, people) 484 self._MultipleBranches(opt, pending, people)