From 4f7bdea9d24c4eb52f83ada2b67b88ad67cb57a7 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Mon, 22 Oct 2012 12:50:15 +0900 Subject: Add pylint configuration and instructions pylint configuration file (.pylintrc) is added, and submission instructions are updated to include pylint usage steps. Deprecated pylint suppression (`disable-msg`) is updated in a few modules to make it work properly with the latest version (0.26). Change-Id: I4ec2ef318e23557a374ecdbf40fe12645766830c --- SUBMITTING_PATCHES | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) (limited to 'SUBMITTING_PATCHES') diff --git a/SUBMITTING_PATCHES b/SUBMITTING_PATCHES index cba67416..50e2cf77 100644 --- a/SUBMITTING_PATCHES +++ b/SUBMITTING_PATCHES @@ -2,6 +2,7 @@ Short Version: - Make small logical changes. - Provide a meaningful commit message. + - Check for coding errors with pylint - Make sure all code is under the Apache License, 2.0. - Publish your changes for review: @@ -33,7 +34,14 @@ If your description starts to get too long, that's a sign that you probably need to split up your commit to finer grained pieces. -(2) Check the license +(2) Check for coding errors with pylint + +Run pylint on changed modules using the provided configuration: + + pylint --rcfile=.pylintrc file.py + + +(3) Check the license repo is licensed under the Apache License, 2.0. @@ -49,7 +57,7 @@ your patch. It is virtually impossible to remove a patch once it has been applied and pushed out. -(3) Sending your patches. +(4) Sending your patches. Do not email your patches to anyone. -- cgit v1.2.3-54-g00ecf