From d58d0dd3bf40f2c5e754c8a0a622c7d4e58425b8 Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Mon, 14 Jun 2021 16:17:27 -0400 Subject: commands: pass settings via __init__ Instead of setting properties on the instantiated command, pass them via the constructor like normal objects. Change-Id: I8787499bd2be68565875ffe243c3cf2024b36ae7 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/309324 Reviewed-by: Raman Tenneti Tested-by: Mike Frysinger --- command.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) (limited to 'command.py') diff --git a/command.py b/command.py index 94f4d754..dc765db0 100644 --- a/command.py +++ b/command.py @@ -43,9 +43,6 @@ class Command(object): """Base class for any command line action in repo. """ - manifest = None - _optparse = None - # Singleton for all commands to track overall repo command execution and # provide event summary to callers. Only used by sync subcommand currently. # @@ -61,6 +58,15 @@ class Command(object): # it is the number of parallel jobs to default to. PARALLEL_JOBS = None + def __init__(self, repodir=None, client=None, manifest=None, gitc_manifest=None): + self.repodir = repodir + self.client = client + self.manifest = manifest + self.gitc_manifest = gitc_manifest + + # Cache for the OptionParser property. + self._optparse = None + def WantPager(self, _opt): return False -- cgit v1.2.3-54-g00ecf