From 3164d40e2247d42537aef8e80fa7e048e14bec9f Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Mon, 11 Nov 2019 05:40:22 -0500 Subject: use open context managers in more places Use open() as a context manager to simplify the close logic and make the code easier to read & understand. This is also more Pythonic. Change-Id: I579d03cca86f99b2c6c6a1f557f6e5704e2515a7 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/244734 Reviewed-by: David Pursehouse Tested-by: Mike Frysinger --- git_refs.py | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) (limited to 'git_refs.py') diff --git a/git_refs.py b/git_refs.py index 98ed1e2f..debd4cbf 100644 --- a/git_refs.py +++ b/git_refs.py @@ -141,18 +141,11 @@ class GitRefs(object): def _ReadLoose1(self, path, name): try: - fd = open(path) - except IOError: - return - - try: - try: + with open(path) as fd: mtime = os.path.getmtime(path) ref_id = fd.readline() - except (IOError, OSError): - return - finally: - fd.close() + except (IOError, OSError): + return try: ref_id = ref_id.decode() -- cgit v1.2.3-54-g00ecf