From 5c6eeac8f0350fd6b14cf226ffcff655f1dd9582 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Thu, 11 Oct 2012 16:44:48 +0900 Subject: More coding style cleanup Fixing more issues found with pylint. Some that were supposed to have been fixed in the previous sweep (Ie0db839e) but were missed: C0321: More than one statement on a single line W0622: Redefining built-in 'name' And some more: W0631: Using possibly undefined loop variable 'name' W0223: Method 'name' is abstract in class 'name' but is not overridden W0231: __init__ method from base class 'name' is not called Change-Id: Ie119183708609d6279e973057a385fde864230c3 --- manifest_xml.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'manifest_xml.py') diff --git a/manifest_xml.py b/manifest_xml.py index 12072441..04cabaad 100644 --- a/manifest_xml.py +++ b/manifest_xml.py @@ -321,7 +321,8 @@ class XmlManifest(object): raise ManifestParseError("no in %s" % (path,)) nodes = [] - for node in manifest.childNodes: + for node in manifest.childNodes: # pylint:disable-msg=W0631 + # We only get here if manifest is initialised if node.nodeName == 'include': name = self._reqatt(node, 'name') fp = os.path.join(include_root, name) -- cgit v1.2.3-54-g00ecf