From 5c6eeac8f0350fd6b14cf226ffcff655f1dd9582 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Thu, 11 Oct 2012 16:44:48 +0900 Subject: More coding style cleanup Fixing more issues found with pylint. Some that were supposed to have been fixed in the previous sweep (Ie0db839e) but were missed: C0321: More than one statement on a single line W0622: Redefining built-in 'name' And some more: W0631: Using possibly undefined loop variable 'name' W0223: Method 'name' is abstract in class 'name' but is not overridden W0231: __init__ method from base class 'name' is not called Change-Id: Ie119183708609d6279e973057a385fde864230c3 --- project.py | 24 ++++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) (limited to 'project.py') diff --git a/project.py b/project.py index 96ab907b..472b1d32 100644 --- a/project.py +++ b/project.py @@ -724,17 +724,25 @@ class Project(object): paths.sort() for p in paths: - try: i = di[p] - except KeyError: i = None + try: + i = di[p] + except KeyError: + i = None - try: f = df[p] - except KeyError: f = None + try: + f = df[p] + except KeyError: + f = None - if i: i_status = i.status.upper() - else: i_status = '-' + if i: + i_status = i.status.upper() + else: + i_status = '-' - if f: f_status = f.status.lower() - else: f_status = '-' + if f: + f_status = f.status.lower() + else: + f_status = '-' if i and i.src_path: line = ' %s%s\t%s => %s (%s%%)' % (i_status, f_status, -- cgit v1.2.3-54-g00ecf