From 8a68ff96057ec58e524a3e41a2d8dca7b5d016bc Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Mon, 24 Sep 2012 12:15:13 +0900 Subject: Coding style cleanup Fix the following issues reported by pylint: C0321: More than one statement on a single line W0622: Redefining built-in 'name' W0612: Unused variable 'name' W0613: Unused argument 'name' W0102: Dangerous default value 'value' as argument W0105: String statement has no effect Also fixed a few cases of inconsistent indentation. Change-Id: Ie0db839e7c57d576cff12d8c055fe87030d00744 --- subcmds/forall.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'subcmds/forall.py') diff --git a/subcmds/forall.py b/subcmds/forall.py index 9436f4e5..76a02688 100644 --- a/subcmds/forall.py +++ b/subcmds/forall.py @@ -208,7 +208,6 @@ terminal and are not redirected. return self.fd.fileno() empty = True - didout = False errbuf = '' p.stdin.close() @@ -220,7 +219,7 @@ terminal and are not redirected. fcntl.fcntl(s.fd, fcntl.F_SETFL, flags | os.O_NONBLOCK) while s_in: - in_ready, out_ready, err_ready = select.select(s_in, [], []) + in_ready, _out_ready, _err_ready = select.select(s_in, [], []) for s in in_ready: buf = s.fd.read(4096) if not buf: @@ -229,9 +228,7 @@ terminal and are not redirected. continue if not opt.verbose: - if s.fd == p.stdout: - didout = True - else: + if s.fd != p.stdout: errbuf += buf continue -- cgit v1.2.3-54-g00ecf