From d58d0dd3bf40f2c5e754c8a0a622c7d4e58425b8 Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Mon, 14 Jun 2021 16:17:27 -0400 Subject: commands: pass settings via __init__ Instead of setting properties on the instantiated command, pass them via the constructor like normal objects. Change-Id: I8787499bd2be68565875ffe243c3cf2024b36ae7 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/309324 Reviewed-by: Raman Tenneti Tested-by: Mike Frysinger --- subcmds/help.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'subcmds/help.py') diff --git a/subcmds/help.py b/subcmds/help.py index 821f6bf6..f302e75c 100644 --- a/subcmds/help.py +++ b/subcmds/help.py @@ -138,8 +138,7 @@ Displays detailed usage information about a command. def _PrintAllCommandHelp(self): for name in sorted(all_commands): - cmd = all_commands[name]() - cmd.manifest = self.manifest + cmd = all_commands[name](manifest=self.manifest) self._PrintCommandHelp(cmd, header_prefix='[%s] ' % (name,)) def _Options(self, p): @@ -163,12 +162,11 @@ Displays detailed usage information about a command. name = args[0] try: - cmd = all_commands[name]() + cmd = all_commands[name](manifest=self.manifest) except KeyError: print("repo: '%s' is not a repo command." % name, file=sys.stderr) sys.exit(1) - cmd.manifest = self.manifest self._PrintCommandHelp(cmd) else: -- cgit v1.2.3-54-g00ecf