From 8c1e9cbef161f2ff12dadbacf26affd23876fde9 Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Sun, 6 Sep 2020 14:53:18 -0400 Subject: manifest_xml: refactor manifest parsing from client management We conflate the manifest & parsing logic with the management of the repo client checkout in a single class. This makes testing just one part (the manifest parsing) hard as it requires a full checkout too. Start splitting the two apart into separate classes to make it easy to reason about & test. Change-Id: Iaf897c93db9c724baba6044bfe7a589c024523b2 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/288682 Reviewed-by: Michael Mortensen Tested-by: Mike Frysinger --- subcmds/init.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'subcmds/init.py') diff --git a/subcmds/init.py b/subcmds/init.py index 5ba0d074..f46babfe 100644 --- a/subcmds/init.py +++ b/subcmds/init.py @@ -365,7 +365,7 @@ to update the working directory files. return a def _ShouldConfigureUser(self, opt): - gc = self.manifest.globalConfig + gc = self.client.globalConfig mp = self.manifest.manifestProject # If we don't have local settings, get from global. @@ -414,7 +414,7 @@ to update the working directory files. return False def _ConfigureColor(self): - gc = self.manifest.globalConfig + gc = self.client.globalConfig if self._HasColorSet(gc): return -- cgit v1.2.3-54-g00ecf