From 145e35b805957487601514481df23b8fb723be38 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Wed, 12 Feb 2020 15:40:47 +0900 Subject: Fix usage of bare 'except' flake8 reports: E722 do not use bare 'except' Replace them with 'except Exception' per [1] which says: Bare except will catch exceptions you almost certainly don't want to catch, including KeyboardInterrupt (the user hitting Ctrl+C) and Python-raised errors like SystemExit If you don't have a specific exception you're expecting, at least except Exception, which is the base type for all "Regular" exceptions. [1] https://stackoverflow.com/a/54948581 Change-Id: Ic555ea9482645899f5b04040ddb6b24eadbf9062 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/254606 Reviewed-by: Mike Frysinger Tested-by: David Pursehouse --- subcmds/sync.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'subcmds/sync.py') diff --git a/subcmds/sync.py b/subcmds/sync.py index c433ce6f..cc058af6 100644 --- a/subcmds/sync.py +++ b/subcmds/sync.py @@ -603,7 +603,7 @@ later is required to fix a server side protocol bug. bare_git.gc('--auto', config=config) except GitError: err_event.set() - except: + except Exception: err_event.set() raise finally: -- cgit v1.2.3-54-g00ecf