From 66bdd468717a6f52056924837b766cf60889f2ed Mon Sep 17 00:00:00 2001 From: "Shawn O. Pearce" Date: Fri, 17 Apr 2009 18:47:22 -0700 Subject: Only compute commits in repo upload if we need to show a prompt If the user has disabled a prompt, skip the two commands we use to obtain the list of commits and the date of the branch. These will never be displayed and just waste the end-user's time. Signed-off-by: Shawn O. Pearce --- subcmds/upload.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'subcmds/upload.py') diff --git a/subcmds/upload.py b/subcmds/upload.py index 6a98a8bd..de3fe857 100644 --- a/subcmds/upload.py +++ b/subcmds/upload.py @@ -99,8 +99,6 @@ or in the .git/config within the project. For example: def _SingleBranch(self, branch, people): project = branch.project name = branch.name - date = branch.date - list = branch.commits remote = project.GetBranch(name).remote key = 'review.%s.autoupload' % remote.review @@ -110,6 +108,9 @@ or in the .git/config within the project. For example: _die("upload blocked by %s = false" % key) if answer is None: + date = branch.date + list = branch.commits + print 'Upload project %s/:' % project.relpath print ' branch %s (%2d commit%s, %s):' % ( name, -- cgit v1.2.3-54-g00ecf