From 80944b538d606a8ee143db85ca9e50305d3c73e4 Mon Sep 17 00:00:00 2001
From: Mike Frysinger <vapier@google.com>
Date: Wed, 22 Jul 2020 03:23:20 -0400
Subject: upload: exit non-zero when preupload hooks fail

Bug: https://crbug.com/gerrit/13159
Change-Id: Id140b619242c841223c6bc5d4aa0c37a7ce0219d
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/276294
Reviewed-by: Jonathan Nieder <jrn@google.com>
Tested-by: Mike Frysinger <vapier@google.com>
---
 subcmds/upload.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'subcmds/upload.py')

diff --git a/subcmds/upload.py b/subcmds/upload.py
index 3dd9fd25..a886af93 100644
--- a/subcmds/upload.py
+++ b/subcmds/upload.py
@@ -596,7 +596,7 @@ Gerrit Code Review:  https://www.gerritcodereview.com/
           print('\nWARNING: pre-upload hooks failed, but uploading anyways.',
                 file=sys.stderr)
         else:
-          return
+          return 1
 
     if opt.reviewers:
       reviewers = _SplitEmails(opt.reviewers)
-- 
cgit v1.2.3-54-g00ecf