From acf63b28928b33d1335dfed1af7e2d8fc6bb5fc4 Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Thu, 13 Jun 2019 02:24:21 -0400 Subject: drop pyversion & is_python3 checking We're committed to Python 3 at this point, so purge all the is_python3 related dynamic checks. Bug: https://crbug.com/gerrit/10418 Change-Id: I4c8b405d6de359b8b83223c9f4b9c8ffa18ea1a2 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/292383 Reviewed-by: Chris Mcdonald Tested-by: Mike Frysinger --- subcmds/gitc_delete.py | 4 ---- subcmds/init.py | 10 +--------- subcmds/sync.py | 25 +++++-------------------- subcmds/upload.py | 5 ----- 4 files changed, 6 insertions(+), 38 deletions(-) (limited to 'subcmds') diff --git a/subcmds/gitc_delete.py b/subcmds/gitc_delete.py index c6f02607..56e0eaba 100644 --- a/subcmds/gitc_delete.py +++ b/subcmds/gitc_delete.py @@ -17,10 +17,6 @@ import sys from command import Command, GitcClientCommand import platform_utils -from pyversion import is_python3 -if not is_python3(): - input = raw_input # noqa: F821 - class GitcDelete(Command, GitcClientCommand): common = True diff --git a/subcmds/init.py b/subcmds/init.py index e078fcbe..1bcf5463 100644 --- a/subcmds/init.py +++ b/subcmds/init.py @@ -17,15 +17,7 @@ import os import platform import re import sys - -from pyversion import is_python3 -if is_python3(): - import urllib.parse -else: - import imp - import urlparse - urllib = imp.new_module('urllib') - urllib.parse = urlparse +import urllib.parse from color import Coloring from command import InteractiveCommand, MirrorSafeCommand diff --git a/subcmds/sync.py b/subcmds/sync.py index 1e1f2fc1..3482946d 100644 --- a/subcmds/sync.py +++ b/subcmds/sync.py @@ -12,6 +12,7 @@ # See the License for the specific language governing permissions and # limitations under the License. +import http.cookiejar as cookielib import json import netrc from optparse import SUPPRESS_HELP @@ -22,26 +23,10 @@ import subprocess import sys import tempfile import time - -from pyversion import is_python3 -if is_python3(): - import http.cookiejar as cookielib - import urllib.error - import urllib.parse - import urllib.request - import xmlrpc.client -else: - import cookielib - import imp - import urllib2 - import urlparse - import xmlrpclib - urllib = imp.new_module('urllib') - urllib.error = urllib2 - urllib.parse = urlparse - urllib.request = urllib2 - xmlrpc = imp.new_module('xmlrpc') - xmlrpc.client = xmlrpclib +import urllib.error +import urllib.parse +import urllib.request +import xmlrpc.client try: import threading as _threading diff --git a/subcmds/upload.py b/subcmds/upload.py index c189e65f..50dccc52 100644 --- a/subcmds/upload.py +++ b/subcmds/upload.py @@ -23,11 +23,6 @@ from git_command import GitCommand from git_refs import R_HEADS from hooks import RepoHook -from pyversion import is_python3 -if not is_python3(): - input = raw_input # noqa: F821 -else: - unicode = str UNUSUAL_COMMIT_THRESHOLD = 5 -- cgit v1.2.3-54-g00ecf