From c58ec4dba102d88fec67e833eb8421202eb4c1ea Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Mon, 17 Feb 2020 14:36:08 -0500 Subject: avoid negative variables Trying to use booleans with names like "no_xxx" are hard to follow due to the double negatives. Invert all of them so we only have positive meanings to follow. Change-Id: Ifd37d0368f97034d94aa2cf38db52c723ac0c6ed Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/255493 Tested-by: Mike Frysinger Reviewed-by: David Pursehouse --- subcmds/init.py | 10 +++++----- subcmds/rebase.py | 4 ++-- subcmds/selfupdate.py | 4 ++-- subcmds/sync.py | 18 +++++++++--------- 4 files changed, 18 insertions(+), 18 deletions(-) (limited to 'subcmds') diff --git a/subcmds/init.py b/subcmds/init.py index dde97286..3c68c2c3 100644 --- a/subcmds/init.py +++ b/subcmds/init.py @@ -146,10 +146,10 @@ to update the working directory files. 'platform group [auto|all|none|linux|darwin|...]', metavar='PLATFORM') g.add_option('--no-clone-bundle', - dest='no_clone_bundle', action='store_true', + dest='clone_bundle', default=True, action='store_false', help='disable use of /clone.bundle on HTTP/HTTPS') g.add_option('--no-tags', - dest='no_tags', action='store_true', + dest='tags', default=True, action='store_false', help="don't fetch tags in the manifest") # Tool @@ -161,7 +161,7 @@ to update the working directory files. dest='repo_branch', help='repo branch or revision', metavar='REVISION') g.add_option('--no-repo-verify', - dest='no_repo_verify', action='store_true', + dest='repo_verify', default=True, action='store_false', help='do not verify repo source code') # Other @@ -281,9 +281,9 @@ to update the working directory files. m.config.SetString('repo.submodules', 'true') if not m.Sync_NetworkHalf(is_new=is_new, quiet=opt.quiet, - clone_bundle=not opt.no_clone_bundle, + clone_bundle=opt.clone_bundle, current_branch_only=opt.current_branch_only, - no_tags=opt.no_tags, submodules=opt.submodules, + tags=opt.tags, submodules=opt.submodules, clone_filter=opt.clone_filter): r = m.GetRemote(m.remote.name) print('fatal: cannot obtain manifest %s' % r.url, file=sys.stderr) diff --git a/subcmds/rebase.py b/subcmds/rebase.py index eb92a3c7..24d80bfd 100644 --- a/subcmds/rebase.py +++ b/subcmds/rebase.py @@ -53,7 +53,7 @@ branch but need to incorporate new upstream changes "underneath" them. dest='force_rebase', action='store_true', help='Pass --force-rebase to git rebase') p.add_option('--no-ff', - dest='no_ff', action='store_true', + dest='ff', default=True, action='store_false', help='Pass --no-ff to git rebase') p.add_option('-q', '--quiet', dest='quiet', action='store_true', @@ -93,7 +93,7 @@ branch but need to incorporate new upstream changes "underneath" them. common_args.append('--quiet') if opt.force_rebase: common_args.append('--force-rebase') - if opt.no_ff: + if not opt.ff: common_args.append('--no-ff') if opt.autosquash: common_args.append('--autosquash') diff --git a/subcmds/selfupdate.py b/subcmds/selfupdate.py index 4817a862..bf6256ab 100644 --- a/subcmds/selfupdate.py +++ b/subcmds/selfupdate.py @@ -40,7 +40,7 @@ need to be performed by an end-user. def _Options(self, p): g = p.add_option_group('repo Version options') g.add_option('--no-repo-verify', - dest='no_repo_verify', action='store_true', + dest='repo_verify', default=True, action='store_false', help='do not verify repo source code') g.add_option('--repo-upgraded', dest='repo_upgraded', action='store_true', @@ -60,5 +60,5 @@ need to be performed by an end-user. rp.bare_git.gc('--auto') _PostRepoFetch(rp, - no_repo_verify=opt.no_repo_verify, + repo_verify=opt.repo_verify, verbose=True) diff --git a/subcmds/sync.py b/subcmds/sync.py index 849e878c..1988cc72 100644 --- a/subcmds/sync.py +++ b/subcmds/sync.py @@ -247,7 +247,7 @@ later is required to fix a server side protocol bug. dest='manifest_name', help='temporary manifest to use for this sync', metavar='NAME.xml') p.add_option('--no-clone-bundle', - dest='no_clone_bundle', action='store_true', + dest='clone_bundle', default=True, action='store_false', help='disable use of /clone.bundle on HTTP/HTTPS') p.add_option('-u', '--manifest-server-username', action='store', dest='manifest_server_username', @@ -259,7 +259,7 @@ later is required to fix a server side protocol bug. dest='fetch_submodules', action='store_true', help='fetch submodules from server') p.add_option('--no-tags', - dest='no_tags', action='store_true', + dest='tags', default=True, action='store_false', help="don't fetch tags") p.add_option('--optimized-fetch', dest='optimized_fetch', action='store_true', @@ -276,7 +276,7 @@ later is required to fix a server side protocol bug. g = p.add_option_group('repo Version options') g.add_option('--no-repo-verify', - dest='no_repo_verify', action='store_true', + dest='repo_verify', default=True, action='store_false', help='do not verify repo source code') g.add_option('--repo-upgraded', dest='repo_upgraded', action='store_true', @@ -338,8 +338,8 @@ later is required to fix a server side protocol bug. verbose=opt.verbose, current_branch_only=opt.current_branch_only, force_sync=opt.force_sync, - clone_bundle=not opt.no_clone_bundle, - no_tags=opt.no_tags, archive=self.manifest.IsArchive, + clone_bundle=opt.clone_bundle, + tags=opt.tags, archive=self.manifest.IsArchive, optimized_fetch=opt.optimized_fetch, prune=opt.prune, clone_filter=clone_filter) @@ -841,7 +841,7 @@ later is required to fix a server side protocol bug. start = time.time() success = mp.Sync_NetworkHalf(quiet=opt.quiet, verbose=opt.verbose, current_branch_only=opt.current_branch_only, - no_tags=opt.no_tags, + tags=opt.tags, optimized_fetch=opt.optimized_fetch, submodules=self.manifest.HasSubmodules, clone_filter=self.manifest.CloneFilter) @@ -977,7 +977,7 @@ later is required to fix a server side protocol bug. fetched = self._Fetch(to_fetch, opt, err_event) - _PostRepoFetch(rp, opt.no_repo_verify) + _PostRepoFetch(rp, opt.repo_verify) if opt.network_only: # bail out now; the rest touches the working tree if err_event.isSet(): @@ -1067,11 +1067,11 @@ def _PostRepoUpgrade(manifest, quiet=False): project.PostRepoUpgrade() -def _PostRepoFetch(rp, no_repo_verify=False, verbose=False): +def _PostRepoFetch(rp, repo_verify=True, verbose=False): if rp.HasChanges: print('info: A new version of repo is available', file=sys.stderr) print(file=sys.stderr) - if no_repo_verify or _VerifyTag(rp): + if not repo_verify or _VerifyTag(rp): syncbuf = SyncBuffer(rp.config) rp.Sync_LocalHalf(syncbuf) if not syncbuf.Finish(): -- cgit v1.2.3-54-g00ecf