From ca540aed19bb89a4cd71de83ba123338e1e721f6 Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Wed, 10 Jul 2019 15:42:30 -0400 Subject: git_command: drop custom version helper Since ParseGitVersion can call `git --version` automatically, we don't need this duplicate version() helper anymore. The only other user is the `repo version` code, so convert that to version_tuple().full. Bug: https://crbug.com/gerrit/11144 Change-Id: I9d77822fc39f4ba28884d9183359169cabf5f17d Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/231055 Reviewed-by: David Pursehouse Tested-by: Mike Frysinger --- tests/test_git_command.py | 45 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) create mode 100644 tests/test_git_command.py (limited to 'tests/test_git_command.py') diff --git a/tests/test_git_command.py b/tests/test_git_command.py new file mode 100644 index 00000000..2ed84969 --- /dev/null +++ b/tests/test_git_command.py @@ -0,0 +1,45 @@ +# -*- coding:utf-8 -*- +# +# Copyright 2019 The Android Open Source Project +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +import unittest + +import git_command + + +class GitCallUnitTest(unittest.TestCase): + """Tests the _GitCall class (via git_command.git).""" + + def test_version_tuple(self): + """Check git.version_tuple() handling.""" + ver = git_command.git.version_tuple() + self.assertIsNotNone(ver) + + # We don't dive too deep into the values here to avoid having to update + # whenever git versions change. We do check relative to this min version + # as this is what `repo` itself requires via MIN_GIT_VERSION. + MIN_GIT_VERSION = (1, 7, 2) + self.assertTrue(isinstance(ver.major, int)) + self.assertTrue(isinstance(ver.minor, int)) + self.assertTrue(isinstance(ver.micro, int)) + + self.assertGreater(ver.major, MIN_GIT_VERSION[0] - 1) + self.assertGreaterEqual(ver.micro, 0) + self.assertGreaterEqual(ver.major, 0) + + self.assertGreaterEqual(ver, MIN_GIT_VERSION) + self.assertLess(ver, (9999, 9999, 9999)) + + self.assertNotEqual('', ver.full) -- cgit v1.2.3-54-g00ecf