diff options
author | Khem Raj <raj.khem@gmail.com> | 2019-12-24 10:05:17 -0800 |
---|---|---|
committer | Khem Raj <raj.khem@gmail.com> | 2019-12-25 08:55:26 -0800 |
commit | 1a8d90727d8071929b6a317fc0d1c4a2203a5cb4 (patch) | |
tree | 1b37c2aef0dab99bc44aaf8e0212c2d8202e84d3 | |
parent | 2a6783a180ad2b477dc94f74ae4b749c28b53e0c (diff) | |
download | meta-openembedded-1a8d90727d8071929b6a317fc0d1c4a2203a5cb4.tar.gz |
libubox: Update to latest
Fix out of bounds array access
Signed-off-by: Khem Raj <raj.khem@gmail.com>
-rw-r--r-- | meta-oe/recipes-devtools/libubox/libubox/0001-blobmsg-fix-array-out-of-bounds-GCC-10-warning.patch | 42 | ||||
-rw-r--r-- | meta-oe/recipes-devtools/libubox/libubox_git.bb | 3 |
2 files changed, 44 insertions, 1 deletions
diff --git a/meta-oe/recipes-devtools/libubox/libubox/0001-blobmsg-fix-array-out-of-bounds-GCC-10-warning.patch b/meta-oe/recipes-devtools/libubox/libubox/0001-blobmsg-fix-array-out-of-bounds-GCC-10-warning.patch new file mode 100644 index 0000000000..4f1dd76326 --- /dev/null +++ b/meta-oe/recipes-devtools/libubox/libubox/0001-blobmsg-fix-array-out-of-bounds-GCC-10-warning.patch | |||
@@ -0,0 +1,42 @@ | |||
1 | From a12325a0cbf3bf1d66a0b0f8d85e08083bae6066 Mon Sep 17 00:00:00 2001 | ||
2 | From: =?UTF-8?q?Petr=20=C5=A0tetiar?= <ynezz@true.cz> | ||
3 | Date: Wed, 25 Dec 2019 10:27:59 +0100 | ||
4 | Subject: [PATCH] blobmsg: fix array out of bounds GCC 10 warning | ||
5 | MIME-Version: 1.0 | ||
6 | Content-Type: text/plain; charset=UTF-8 | ||
7 | Content-Transfer-Encoding: 8bit | ||
8 | |||
9 | Fixes following warning reported by GCC 10.0.0 20191203: | ||
10 | |||
11 | blobmsg.c:234:2: error: 'strcpy' offset 6 from the object at 'attr' is out of the bounds of referenced subobject 'name' with type 'uint8_t[0]' {aka 'unsigned char[0]'} at offset 6 [-Werror=array-bounds] | ||
12 | 234 | strcpy((char *) hdr->name, (const char *)name); | ||
13 | | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
14 | |||
15 | In file included from blobmsg.c:16: | ||
16 | blobmsg.h:42:10: note: subobject 'name' declared here | ||
17 | 42 | uint8_t name[]; | ||
18 | | ^~~~ | ||
19 | |||
20 | Upstream-Status: Submitted [https://gitlab.com/ynezz/openwrt-libubox/commit/3775b3aa28de8c20d96b6f02786a327423b0748a] | ||
21 | Reported-by: Khem Raj <raj.khem@gmail.com> | ||
22 | Signed-off-by: Petr Štetiar <ynezz@true.cz> | ||
23 | --- | ||
24 | blobmsg.c | 2 +- | ||
25 | 1 file changed, 1 insertion(+), 1 deletion(-) | ||
26 | |||
27 | diff --git a/blobmsg.c b/blobmsg.c | ||
28 | index a860483..b6b7535 100644 | ||
29 | --- a/blobmsg.c | ||
30 | +++ b/blobmsg.c | ||
31 | @@ -195,7 +195,7 @@ blobmsg_new(struct blob_buf *buf, int type, const char *name, int payload_len, v | ||
32 | attr->id_len |= be32_to_cpu(BLOB_ATTR_EXTENDED); | ||
33 | hdr = blob_data(attr); | ||
34 | hdr->namelen = cpu_to_be16(namelen); | ||
35 | - strcpy((char *) hdr->name, (const char *)name); | ||
36 | + memcpy(hdr->name, name, namelen); | ||
37 | pad_end = *data = blobmsg_data(attr); | ||
38 | pad_start = (char *) &hdr->name[namelen]; | ||
39 | if (pad_start < pad_end) | ||
40 | -- | ||
41 | 2.24.1 | ||
42 | |||
diff --git a/meta-oe/recipes-devtools/libubox/libubox_git.bb b/meta-oe/recipes-devtools/libubox/libubox_git.bb index f9f4e08b71..7dbefa1152 100644 --- a/meta-oe/recipes-devtools/libubox/libubox_git.bb +++ b/meta-oe/recipes-devtools/libubox/libubox_git.bb | |||
@@ -16,9 +16,10 @@ SRC_URI = "\ | |||
16 | git://git.openwrt.org/project/libubox.git \ | 16 | git://git.openwrt.org/project/libubox.git \ |
17 | file://0001-version-libraries.patch \ | 17 | file://0001-version-libraries.patch \ |
18 | file://fix-libdir.patch \ | 18 | file://fix-libdir.patch \ |
19 | file://0001-blobmsg-fix-array-out-of-bounds-GCC-10-warning.patch \ | ||
19 | " | 20 | " |
20 | 21 | ||
21 | SRCREV = "155bf39896f126b1ba121b816922a88dc34c31e3" | 22 | SRCREV = "07413cce72e19520af55dfcbc765484f5ab41dd9" |
22 | PV = "1.0.1+git${SRCPV}" | 23 | PV = "1.0.1+git${SRCPV}" |
23 | 24 | ||
24 | S = "${WORKDIR}/git" | 25 | S = "${WORKDIR}/git" |