diff options
author | Martin Jansa <martin.jansa@gmail.com> | 2025-03-21 10:56:40 +0100 |
---|---|---|
committer | Khem Raj <raj.khem@gmail.com> | 2025-03-21 11:07:33 -0700 |
commit | 5bca3a7b5dc75c6389b7538f16674a4d6ebcbc44 (patch) | |
tree | 247bfdf5a1ecfb488c0d0305aeb4c42b76360b19 | |
parent | bf70a667752124b1babb92f8f8e9097e872c1900 (diff) | |
download | meta-openembedded-5bca3a7b5dc75c6389b7538f16674a4d6ebcbc44.tar.gz |
android-tools: fix build with gcc-15
* fixes build with gcc-15:
http://errors.yoctoproject.org/Errors/Details/848455/
Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2 files changed, 70 insertions, 0 deletions
diff --git a/meta-oe/recipes-devtools/android-tools/android-tools/extras/0003-ext4_utils-drop-unused-parameter-from-allocate_inode.patch b/meta-oe/recipes-devtools/android-tools/android-tools/extras/0003-ext4_utils-drop-unused-parameter-from-allocate_inode.patch new file mode 100644 index 0000000000..b77c0ebc13 --- /dev/null +++ b/meta-oe/recipes-devtools/android-tools/android-tools/extras/0003-ext4_utils-drop-unused-parameter-from-allocate_inode.patch | |||
@@ -0,0 +1,69 @@ | |||
1 | From c9f8cb184a7218c97ff966db44da6dd814c0e273 Mon Sep 17 00:00:00 2001 | ||
2 | From: Martin Jansa <martin.jansa@gmail.com> | ||
3 | Date: Fri, 21 Mar 2025 09:49:32 +0000 | ||
4 | Subject: [PATCH] ext4_utils: drop unused parameter from allocate_inode() | ||
5 | |||
6 | * fixes build with gcc-15: | ||
7 | http://errors.yoctoproject.org/Errors/Details/848455/ | ||
8 | |||
9 | TOPDIR/tmp/work/core2-64-oe-linux/android-tools/5.1.1.r37/git/system/extras/ext4_utils/contents.c: In function 'make_directory': | ||
10 | TOPDIR/tmp/work/core2-64-oe-linux/android-tools/5.1.1.r37/git/system/extras/ext4_utils/contents.c:115:29: error: too many arguments to function 'allocate_inode'; expected 0, have 1 | ||
11 | 115 | inode_num = allocate_inode(info); | ||
12 | | ^~~~~~~~~~~~~~ ~~~~ | ||
13 | In file included from TOPDIR/tmp/work/core2-64-oe-linux/android-tools/5.1.1.r37/git/system/extras/ext4_utils/contents.c:32: | ||
14 | TOPDIR/tmp/work/core2-64-oe-linux/android-tools/5.1.1.r37/git/system/extras/ext4_utils/allocate.h:61:5: note: declared here | ||
15 | 61 | u32 allocate_inode(); | ||
16 | | ^~~~~~~~~~~~~~ | ||
17 | TOPDIR/tmp/work/core2-64-oe-linux/android-tools/5.1.1.r37/git/system/extras/ext4_utils/contents.c: In function 'make_file': | ||
18 | TOPDIR/tmp/work/core2-64-oe-linux/android-tools/5.1.1.r37/git/system/extras/ext4_utils/contents.c:183:21: error: too many arguments to function 'allocate_inode'; expected 0, have 1 | ||
19 | 183 | inode_num = allocate_inode(info); | ||
20 | | ^~~~~~~~~~~~~~ ~~~~ | ||
21 | TOPDIR/tmp/work/core2-64-oe-linux/android-tools/5.1.1.r37/git/system/extras/ext4_utils/allocate.h:61:5: note: declared here | ||
22 | 61 | u32 allocate_inode(); | ||
23 | | ^~~~~~~~~~~~~~ | ||
24 | TOPDIR/tmp/work/core2-64-oe-linux/android-tools/5.1.1.r37/git/system/extras/ext4_utils/contents.c: In function 'make_link': | ||
25 | TOPDIR/tmp/work/core2-64-oe-linux/android-tools/5.1.1.r37/git/system/extras/ext4_utils/contents.c:218:21: error: too many arguments to function 'allocate_inode'; expected 0, have 1 | ||
26 | 218 | inode_num = allocate_inode(info); | ||
27 | | ^~~~~~~~~~~~~~ ~~~~ | ||
28 | TOPDIR/tmp/work/core2-64-oe-linux/android-tools/5.1.1.r37/git/system/extras/ext4_utils/allocate.h:61:5: note: declared here | ||
29 | 61 | u32 allocate_inode(); | ||
30 | | ^~~~~~~~~~~~~~ | ||
31 | make: *** [<builtin>: contents.o] Error 1 | ||
32 | |||
33 | Upstream-Status: Pending [this whole code was removed in newer version android-9.0.0_r1 https://android.googlesource.com/platform/system/extras/+/7a837fcd6e9c0e0219f743052c78cc1c5988dfaf] | ||
34 | Signed-off-by: Martin Jansa <martin.jansa@gmail.com> | ||
35 | --- | ||
36 | ext4_utils/contents.c | 6 +++--- | ||
37 | 1 file changed, 3 insertions(+), 3 deletions(-) | ||
38 | |||
39 | diff --git a/ext4_utils/contents.c b/ext4_utils/contents.c | ||
40 | index 3144de93f..ac1b71706 100644 | ||
41 | --- a/ext4_utils/contents.c | ||
42 | +++ b/ext4_utils/contents.c | ||
43 | @@ -112,7 +112,7 @@ u32 make_directory(u32 dir_inode_num, u32 entries, struct dentry *dentries, | ||
44 | len = blocks * info.block_size; | ||
45 | |||
46 | if (dir_inode_num) { | ||
47 | - inode_num = allocate_inode(info); | ||
48 | + inode_num = allocate_inode(); | ||
49 | } else { | ||
50 | dir_inode_num = EXT4_ROOT_INO; | ||
51 | inode_num = EXT4_ROOT_INO; | ||
52 | @@ -180,7 +180,7 @@ u32 make_file(const char *filename, u64 len) | ||
53 | struct ext4_inode *inode; | ||
54 | u32 inode_num; | ||
55 | |||
56 | - inode_num = allocate_inode(info); | ||
57 | + inode_num = allocate_inode(); | ||
58 | if (inode_num == EXT4_ALLOCATE_FAILED) { | ||
59 | error("failed to allocate inode\n"); | ||
60 | return EXT4_ALLOCATE_FAILED; | ||
61 | @@ -215,7 +215,7 @@ u32 make_link(const char *link) | ||
62 | u32 inode_num; | ||
63 | u32 len = strlen(link); | ||
64 | |||
65 | - inode_num = allocate_inode(info); | ||
66 | + inode_num = allocate_inode(); | ||
67 | if (inode_num == EXT4_ALLOCATE_FAILED) { | ||
68 | error("failed to allocate inode\n"); | ||
69 | return EXT4_ALLOCATE_FAILED; | ||
diff --git a/meta-oe/recipes-devtools/android-tools/android-tools_5.1.1.r37.bb b/meta-oe/recipes-devtools/android-tools/android-tools_5.1.1.r37.bb index 7c27efb093..fe915c3e30 100644 --- a/meta-oe/recipes-devtools/android-tools/android-tools_5.1.1.r37.bb +++ b/meta-oe/recipes-devtools/android-tools/android-tools_5.1.1.r37.bb | |||
@@ -48,6 +48,7 @@ SRC_URI = " \ | |||
48 | file://core/0001-memory.h-Always-define-strlcpy-for-glibc-based-syste.patch;patchdir=system/core \ | 48 | file://core/0001-memory.h-Always-define-strlcpy-for-glibc-based-syste.patch;patchdir=system/core \ |
49 | file://extras/0001-ext4_utils-remove-selinux-extensions.patch;patchdir=system/extras \ | 49 | file://extras/0001-ext4_utils-remove-selinux-extensions.patch;patchdir=system/extras \ |
50 | file://extras/0002-ext4_utils-add-o-argument-to-preserve-ownership.patch;patchdir=system/extras \ | 50 | file://extras/0002-ext4_utils-add-o-argument-to-preserve-ownership.patch;patchdir=system/extras \ |
51 | file://extras/0003-ext4_utils-drop-unused-parameter-from-allocate_inode.patch;patchdir=system/extras \ | ||
51 | file://libselinux/0001-Remove-bionic-specific-calls.patch;patchdir=external/libselinux \ | 52 | file://libselinux/0001-Remove-bionic-specific-calls.patch;patchdir=external/libselinux \ |
52 | file://libselinux/0001-libselinux-Do-not-define-gettid-if-glibc-2.30-is-use.patch;patchdir=external/libselinux \ | 53 | file://libselinux/0001-libselinux-Do-not-define-gettid-if-glibc-2.30-is-use.patch;patchdir=external/libselinux \ |
53 | file://android-tools-adbd.service \ | 54 | file://android-tools-adbd.service \ |