diff options
author | Alper Ak <alperyasinak1@gmail.com> | 2025-06-23 15:56:08 +0300 |
---|---|---|
committer | Khem Raj <raj.khem@gmail.com> | 2025-06-26 07:26:19 -0700 |
commit | 9650061e408de7c9d8619c3915732ce0e3e1074c (patch) | |
tree | f26b1b52bddcce7b61c97a5a2773b20b6d4da842 | |
parent | 2f941edce174ee1063f2c28821b81976bd6989de (diff) | |
download | meta-openembedded-9650061e408de7c9d8619c3915732ce0e3e1074c.tar.gz |
wifi-test-suite: Fix compile issue
- Variables such as CC, CXX and related variables are usually assigned in core class like gcc.bbclass. For example, CC is assigned this specific value:
CC = "${CCACHE}${HOST_PREFIX}gcc ${HOST_CC_ARCH}${TOOLCHAIN_OPTIONS}"
If you use the += operator to add flags to the CC variable early in your recipe, your changes will be overwritten and lost because BitBake applies class assignments to CC at a later stage, which replaces any previous modifications.
We should use :append operation to ensures that additions are applied to the final value, after all assignments from core classes have been processed. As a result, when you want to extend variables that may be set in core classes (like CC in gcc.bbclass), you should use the :append syntax to guarantee your changes are preserved in the final build environment.
- Using CFLAGS is the standard way to pass compiler flag for C projects.
- The Makefile of the project doesn't respect to append to CFLAGS so added 0006-make-CFLAGS-appendable.patch to make CFLAGS appendable.
Signed-off-by: Alper Ak <alperyasinak1@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
-rw-r--r-- | meta-oe/recipes-connectivity/wifi-test-suite/files/0005-wfa_cmdproc-Store-return-value-into-location.patch (renamed from meta-oe/recipes-connectivity/wifi-test-suite/files/0001-wfa_cmdproc-Store-return-value-into-location.patch) | 0 | ||||
-rw-r--r-- | meta-oe/recipes-connectivity/wifi-test-suite/files/0006-make-CFLAGS-appendable.patch | 60 | ||||
-rw-r--r-- | meta-oe/recipes-connectivity/wifi-test-suite/wifi-test-suite_10.10.1.bb | 7 |
3 files changed, 65 insertions, 2 deletions
diff --git a/meta-oe/recipes-connectivity/wifi-test-suite/files/0001-wfa_cmdproc-Store-return-value-into-location.patch b/meta-oe/recipes-connectivity/wifi-test-suite/files/0005-wfa_cmdproc-Store-return-value-into-location.patch index 074f0fe7bb..074f0fe7bb 100644 --- a/meta-oe/recipes-connectivity/wifi-test-suite/files/0001-wfa_cmdproc-Store-return-value-into-location.patch +++ b/meta-oe/recipes-connectivity/wifi-test-suite/files/0005-wfa_cmdproc-Store-return-value-into-location.patch | |||
diff --git a/meta-oe/recipes-connectivity/wifi-test-suite/files/0006-make-CFLAGS-appendable.patch b/meta-oe/recipes-connectivity/wifi-test-suite/files/0006-make-CFLAGS-appendable.patch new file mode 100644 index 0000000000..9d20403866 --- /dev/null +++ b/meta-oe/recipes-connectivity/wifi-test-suite/files/0006-make-CFLAGS-appendable.patch | |||
@@ -0,0 +1,60 @@ | |||
1 | From ef4ead927f69452c95b80e5bf042f67897f67e9d Mon Sep 17 00:00:00 2001 | ||
2 | From: Alper Ak <alperyasinak1@gmail.com> | ||
3 | Date: Mon, 23 Jun 2025 15:46:37 +0300 | ||
4 | Subject: [PATCH] Allow extra CFLAGS via EXTRA_CFLAGS variable | ||
5 | |||
6 | This patch introduces an EXTRA_CFLAGS variable to the Makefile, which is | ||
7 | appended to CFLAGS. This allows users or external build systems to pass | ||
8 | their additional compiler flags. | ||
9 | |||
10 | Upstream-Status: Submitted [https://github.com/Wi-FiTestSuite/Wi-FiTestSuite-Linux-DUT/pull/61] | ||
11 | |||
12 | Signed-off-by: Alper Ak <alperyasinak1@gmail.com> | ||
13 | --- | ||
14 | Makefile.inc | 15 ++++++++------- | ||
15 | 1 file changed, 8 insertions(+), 7 deletions(-) | ||
16 | |||
17 | diff --git a/Makefile.inc b/Makefile.inc | ||
18 | index 0094bdf..76729b9 100644 | ||
19 | --- a/Makefile.inc | ||
20 | +++ b/Makefile.inc | ||
21 | @@ -22,28 +22,29 @@ UCC=ucc | ||
22 | CON=console_src | ||
23 | WTG=WTGService | ||
24 | MAKE?=make | ||
25 | +EXTRA_CFLAGS ?= | ||
26 | |||
27 | # This is for WMM-PS | ||
28 | #for Ext TG | ||
29 | -#CFLAGS = -g -O2 -D_REENTRANT -DWFA_WMM_PS_EXT -Wall -I../inc | ||
30 | +#CFLAGS = -g -O2 -D_REENTRANT -DWFA_WMM_PS_EXT -Wall -I../inc ${EXTRA_CFLAGS} | ||
31 | |||
32 | ## for WMM-AC, WMM-PS, Voice, PMF, TDLS Test-Bed | ||
33 | -#CFLAGS = -g -O2 -D_REENTRANT -DWFA_WMM_PS_EXT -DWFA_WMM_AC -DWFA_VOICE_EXT -DWFA_STA_TB -Wall -I../inc | ||
34 | +#CFLAGS = -g -O2 -D_REENTRANT -DWFA_WMM_PS_EXT -DWFA_WMM_AC -DWFA_VOICE_EXT -DWFA_STA_TB -Wall -I../inc ${EXTRA_CFLAGS} | ||
35 | |||
36 | ## for WMM-AC, WMM-PS Test-Bed | ||
37 | -#CFLAGS = -g -O2 -D_REENTRANT -DWFA_WMM_PS_EXT -DWFA_WMM_AC -DWFA_STA_TB -Wall -I../inc | ||
38 | +#CFLAGS = -g -O2 -D_REENTRANT -DWFA_WMM_PS_EXT -DWFA_WMM_AC -DWFA_STA_TB -Wall -I../inc ${EXTRA_CFLAGS} | ||
39 | |||
40 | ## for non-Test-Bed WMM-AC, WMM-PS and Voice | ||
41 | -#CFLAGS = -g -O2 -D_REENTRANT -DWFA_WMM_PS_EXT -DWFA_WMM_AC -DWFA_VOICE_EXT -Wall -I../inc | ||
42 | +#CFLAGS = -g -O2 -D_REENTRANT -DWFA_WMM_PS_EXT -DWFA_WMM_AC -DWFA_VOICE_EXT -Wall -I../inc ${EXTRA_CFLAGS} | ||
43 | |||
44 | ## for PC-ENDPOINT | ||
45 | -#CFLAGS = -g -O2 -D_REENTRANT -DWFA_WMM_PS_EXT -DWFA_WMM_AC -DWFA_VOICE_EXT -DWFA_PC_CONSOLE -Wall -I../inc | ||
46 | +#CFLAGS = -g -O2 -D_REENTRANT -DWFA_WMM_PS_EXT -DWFA_WMM_AC -DWFA_VOICE_EXT -DWFA_PC_CONSOLE -Wall -I../inc ${EXTRA_CFLAGS} | ||
47 | |||
48 | ## for PC-ENDPOINT No Voice | ||
49 | -#CFLAGS = -g -O2 -D_REENTRANT -DWFA_WMM_PS_EXT -DWFA_WMM_AC -DWFA_PC_CONSOLE -DWFA_STA_TB -Wall -I../inc | ||
50 | +#CFLAGS = -g -O2 -D_REENTRANT -DWFA_WMM_PS_EXT -DWFA_WMM_AC -DWFA_PC_CONSOLE -DWFA_STA_TB -Wall -I../inc ${EXTRA_CFLAGS} | ||
51 | |||
52 | # This is for WPA2 as default | ||
53 | -CFLAGS = -g -O2 -D_REENTRANT -Wall -I../inc | ||
54 | +CFLAGS = -g -O2 -D_REENTRANT -Wall -I../inc ${EXTRA_CFLAGS} | ||
55 | |||
56 | DUTLIBS = ../lib/libwfa_dut.a -lpthread | ||
57 | CALIBS = ../lib/libwfa_ca.a -lpthread | ||
58 | -- | ||
59 | 2.43.0 | ||
60 | |||
diff --git a/meta-oe/recipes-connectivity/wifi-test-suite/wifi-test-suite_10.10.1.bb b/meta-oe/recipes-connectivity/wifi-test-suite/wifi-test-suite_10.10.1.bb index 9703c10452..357789ad88 100644 --- a/meta-oe/recipes-connectivity/wifi-test-suite/wifi-test-suite_10.10.1.bb +++ b/meta-oe/recipes-connectivity/wifi-test-suite/wifi-test-suite_10.10.1.bb | |||
@@ -14,7 +14,8 @@ SRC_URI = "git://github.com/Wi-FiTestSuite/Wi-FiTestSuite-Linux-DUT.git;branch=m | |||
14 | file://0003-fix-path-to-usr-sbin-for-script-and-make-script-for-.patch \ | 14 | file://0003-fix-path-to-usr-sbin-for-script-and-make-script-for-.patch \ |
15 | file://0004-run-ranlib-per-library-and-use-AR.patch \ | 15 | file://0004-run-ranlib-per-library-and-use-AR.patch \ |
16 | file://fno-common.patch \ | 16 | file://fno-common.patch \ |
17 | file://0001-wfa_cmdproc-Store-return-value-into-location.patch \ | 17 | file://0005-wfa_cmdproc-Store-return-value-into-location.patch \ |
18 | file://0006-make-CFLAGS-appendable.patch \ | ||
18 | " | 19 | " |
19 | 20 | ||
20 | # to avoid host path QA error | 21 | # to avoid host path QA error |
@@ -41,4 +42,6 @@ RDEPENDS:${PN} = "wpa-supplicant" | |||
41 | # http://errors.yoctoproject.org/Errors/Details/766893/ | 42 | # http://errors.yoctoproject.org/Errors/Details/766893/ |
42 | # wfa_cmdproc.c:467:68: error: passing argument 3 of 'strtok_r' from incompatible pointer type [-Wincompatible-pointer-types] | 43 | # wfa_cmdproc.c:467:68: error: passing argument 3 of 'strtok_r' from incompatible pointer type [-Wincompatible-pointer-types] |
43 | # wfa_cs.c:4175:57: error: initialization of 'caStaGetEventDetails_t *' {aka 'struct ca_sta_get_event_details *'} from incompatible pointer type 'caStaMngServ_t *' {aka 'struct ca_sta_manage_service *'} [-Wincompatible-pointer-types] | 44 | # wfa_cs.c:4175:57: error: initialization of 'caStaGetEventDetails_t *' {aka 'struct ca_sta_get_event_details *'} from incompatible pointer type 'caStaMngServ_t *' {aka 'struct ca_sta_manage_service *'} [-Wincompatible-pointer-types] |
44 | CC += "-Wno-error=incompatible-pointer-types" | 45 | CFLAGS += "-Wno-error=incompatible-pointer-types" |
46 | |||
47 | export EXTRA_CFLAGS = "${CFLAGS}" | ||